public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -rt] include linux/delay.h in hwlat_detector
@ 2009-06-14 21:31 Uwe Kleine-König
  2009-06-15  0:54 ` Jon Masters
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2009-06-14 21:31 UTC (permalink / raw)
  To: linux-rt-users, linux-kernel; +Cc: Thomas Gleixner, Jon Masters

This broke when compiling on i386 without X86_LOCAL_APIC because then
arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
linux/delay.h.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jon Masters <jcm@redhat.com>
---

diff --git a/drivers/misc/hwlat_detector.c b/drivers/misc/hwlat_detector.c
index dbd9661..e02d8e1 100644
--- a/drivers/misc/hwlat_detector.c
+++ b/drivers/misc/hwlat_detector.c
@@ -49,6 +49,7 @@
 #include <linux/seq_file.h>
 #include <linux/uaccess.h>
 #include <linux/version.h>
+#include <linux/delay.h>
 
 #define BUF_SIZE_DEFAULT	262144UL		/* 8K*(sizeof(entry)) */
 #define BUF_FLAGS		(RB_FL_OVERWRITE)	/* no block on full */
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -rt] include linux/delay.h in hwlat_detector
  2009-06-14 21:31 [PATCH -rt] include linux/delay.h in hwlat_detector Uwe Kleine-König
@ 2009-06-15  0:54 ` Jon Masters
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Masters @ 2009-06-15  0:54 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: linux-rt-users, linux-kernel, Thomas Gleixner

On Sun, 2009-06-14 at 23:31 +0200, Uwe Kleine-König wrote:
> This broke when compiling on i386 without X86_LOCAL_APIC because then
> arch/x86/include/asm/smp.h doesn't include asm/apic.h which in turn includes
> linux/delay.h.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jon Masters <jcm@redhat.com>
> ---

Oh, thanks. I will also look at better handling hotplug CPU just to make
Paul happy (probably just disable on hotplug as you'll need to restart
any testing then), though as he said, it's obvious one shouldn't be
removing CPUs at the same time as benchmarking.

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-06-15  0:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-14 21:31 [PATCH -rt] include linux/delay.h in hwlat_detector Uwe Kleine-König
2009-06-15  0:54 ` Jon Masters

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox