[PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[GeunSik Lim]

>From 63c01db3e4b2c3a76f0dd5191f46535137e310c8 Mon Sep 17 00:00:00 2001
From: GeunSik,Lim <leemgs1@gmail.com>
Date: Fri, 26 Jun 2009 23:36:45 +0900
Subject: [PATCH 2/3] cyclictest: Fix priority-- method of many threads with -h.

If we run a many threads with -t option, "priority--" rt priority will assign
per thread in sequence. But, If we use -h option, all threads is same priority.
Adjust the same prirotiy method about below two examples for consistency.
ex) cyclictest -t 5 -p 50        [enter] <-- without -h
ex) cyclictest -t 5 -p 50 -h 100 [enter] <-- with    -h

        Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
---
 src/cyclictest/cyclictest.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index ad4c421..3505de5 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -1150,7 +1150,7 @@ int main(int argc, char **argv)
 		}
 
 		par[i].prio = priority;
-		if (priority && !histogram)
+		if (priority)
 			priority--;
                 if      ( policy == 0) par[i].policy = SCHED_OTHER;
                 else if ( policy == 1) par[i].policy = SCHED_FIFO;
-- 
1.6.3.1


-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***" 
in the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

GeunSik Lim ( Samsung Electronics )
e-Mail  :1) geunsik.lim@samsung.com
         2) leemgs@gmail.com , leemgs1@gmail.com
HomePage: http://blog.naver.com/invain/
-----------------------------------------------

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[Sven-Thorsten Dietrich]

Nak.

Sorry for terse, top-post. I'll respond in more detail within 24 hrs.

+ 1 (415) 694 2930

On Jun 26, 2009, at 8:38, GeunSik Lim <leemgs1@gmail.com> wrote:

>
>
>> From 63c01db3e4b2c3a76f0dd5191f46535137e310c8 Mon Sep 17 00:00:00  
>> 2001
> From: GeunSik,Lim <leemgs1@gmail.com>
> Date: Fri, 26 Jun 2009 23:36:45 +0900
> Subject: [PATCH 2/3] cyclictest: Fix priority-- method of many  
> threads with -h.
>
> If we run a many threads with -t option, "priority--" rt priority  
> will assign
> per thread in sequence. But, If we use -h option, all threads is  
> same priority.
> Adjust the same prirotiy method about below two examples for  
> consistency.
> ex) cyclictest -t 5 -p 50        [enter] <-- without -h
> ex) cyclictest -t 5 -p 50 -h 100 [enter] <-- with    -h
>
>        Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
> ---
> src/cyclictest/cyclictest.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index ad4c421..3505de5 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -1150,7 +1150,7 @@ int main(int argc, char **argv)
>        }
>
>        par[i].prio = priority;
> -        if (priority && !histogram)
> +        if (priority)
>            priority--;
>                 if      ( policy == 0) par[i].policy = SCHED_OTHER;
>                 else if ( policy == 1) par[i].policy = SCHED_FIFO;
> -- 
> 1.6.3.1
>
>
> -----------------------------------------------
> To unsubscribe from this list: send the line "unsubscribe linux-***"
> in the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
> GeunSik Lim ( Samsung Electronics )
> e-Mail  :1) geunsik.lim@samsung.com
>         2) leemgs@gmail.com , leemgs1@gmail.com
> HomePage: http://blog.naver.com/invain/
> -----------------------------------------------
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt- 
> users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[GeunSik Lim]

On Mon, Jun 29, 2009 at 8:05 PM, Sven-Thorsten
Dietrich<sven@thebigcorporation.com> wrote:
> Nak.
>
> Sorry for terse, top-post. I'll respond in more detail within 24 hrs.
>
> + 1 (415) 694 2930
Your are welcome.
I am glad that you replied  as reponse of my patch.
I will wait  explanation about NAK response with pleasure. :-)
Thanks,


-- 
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[Sven-Thorsten Dietrich]

On Sat, 2009-06-27 at 00:38 +0900, GeunSik Lim wrote:
> 
> >From 63c01db3e4b2c3a76f0dd5191f46535137e310c8 Mon Sep 17 00:00:00 2001
> From: GeunSik,Lim <leemgs1@gmail.com>
> Date: Fri, 26 Jun 2009 23:36:45 +0900
> Subject: [PATCH 2/3] cyclictest: Fix priority-- method of many threads with -h.
> 
> If we run a many threads with -t option, "priority--" rt priority will assign
> per thread in sequence. But, If we use -h option, all threads is same priority.
> Adjust the same prirotiy method about below two examples for consistency.
> ex) cyclictest -t 5 -p 50        [enter] <-- without -h
> ex) cyclictest -t 5 -p 50 -h 100 [enter] <-- with    -h
> 
>         Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
> ---
>  src/cyclictest/cyclictest.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index ad4c421..3505de5 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -1150,7 +1150,7 @@ int main(int argc, char **argv)
>  		}
>  
>  		par[i].prio = priority;
> -		if (priority && !histogram)
> +		if (priority)
>  			priority--;

When generating a histogram on multiple cores, the priority of
cyclictest threads should be the same on each CPU.

This change would make the priority lower on higher CPU ids, resulting
in apparent performance skew in favor of CPU0.

Sven

>                  if      ( policy == 0) par[i].policy = SCHED_OTHER;
>                  else if ( policy == 1) par[i].policy = SCHED_FIFO;

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[GeunSik Lim]

On Tue, Jun 30, 2009 at 11:56 AM, Sven-Thorsten
Dietrich<sven@thebigcorporation.com> wrote:
> When generating a histogram on multiple cores, the priority of
> cyclictest threads should be the same on each CPU.
Of course, But original cyclictest is different  test scenario using
many threads.

> This change would make the priority lower on higher CPU ids, resulting
> in apparent performance skew in favor of CPU0.
Um. I don't agree with your opinions because we can try  cyclictest
commands like belows
using "-h" option.

In other words,
If cyclictest user want to same priority about many threads ,
They can assign same priority  with belows method or additional  bash scripts.

For example,

case )  before remove your some patches
#> cyclictest -t 3    -p 90 -h -D 100 &[enter]

case )  after remove your some patches
#> cyclictest -t 1    -p 90 -h -D 100 &[enter]
#> cyclictest -t 1    -p 90 -h -D 100 &[enter]
#> cyclictest -t 1    -p 90 -h -D 100 &[enter]

or
#> define i=3; while ($i) do  cyclictest -t 1   -p 90 -h -D 100 & ;
$i-- ; done

I think that many users will confuse  output  results  because of the
differnece output style
between  "without -h" option and "with -h" option.
If I mistake , Pleasse correct me.

Thks.

-- 
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[Sven-Thorsten Dietrich]

On Tue, 2009-06-30 at 16:12 +0900, GeunSik Lim wrote:
> On Tue, Jun 30, 2009 at 11:56 AM, Sven-Thorsten
> Dietrich<sven@thebigcorporation.com> wrote:
> > When generating a histogram on multiple cores, the priority of
> > cyclictest threads should be the same on each CPU.
> Of course, But original cyclictest is different  test scenario using
> many threads.
> 

I that was a single CPU scenario.

For testing on SMP, the cyclictest threads need to behave identicallly
(even in priority) on all CPUs. 

> > This change would make the priority lower on higher CPU ids, resulting
> > in apparent performance skew in favor of CPU0.
> Um. I don't agree with your opinions because we can try  cyclictest
> commands like belows
> using "-h" option.
> 

That same argument also applies to this patch, doesn't it?

In other words, without changing the existing code, you could change the
prios for the histogram mode via a similar script, right?

> In other words,
> If cyclictest user want to same priority about many threads ,
> They can assign same priority  with belows method or additional  bash scripts.
> 
> For example,
> 
> case )  before remove your some patches
> #> cyclictest -t 3    -p 90 -h -D 100 &[enter]
> 
> case )  after remove your some patches
> #> cyclictest -t 1    -p 90 -h -D 100 &[enter]
> #> cyclictest -t 1    -p 90 -h -D 100 &[enter]
> #> cyclictest -t 1    -p 90 -h -D 100 &[enter]
> 
> or
> #> define i=3; while ($i) do  cyclictest -t 1   -p 90 -h -D 100 & ;
> $i-- ; done
> 
> I think that many users will confuse  output  results  because of the
> differnece output style
> between  "without -h" option and "with -h" option.
> If I mistake , Pleasse correct me.
> 

I don't disagree, but I think the proper fix may be to decouple
histogram from priority, via another parameter.

Note that the thread interval is also held constant when histogram is
configured -- not just the priority.

                if (!histogram) /* histogram requires same interval on CPUs*/
                        interval += distance;
  

The patch you sent basically reverts a bug-fix for the histogram
application on SMP, but doesn't change the interval behavior.

So you would also have to decouple the interval code as well.

It would be better to be able to explicitly set priorities and intervals
to be the same, when distributed per-CPU on SMP. That is one kind of
test, which is important. 

Inversely relating priority versus interval on UP is another kind of
test. This seems to be what you are trying to do.

So to have both, means you can to stack threads on SMP and have multiple
threads on each CPU, operating at increasing intervals. Each thread
would report data. 

But that implies a 3-D table to log the data returned from cyclictest
threads at lower priorities (lower than the highest priority). 

The histogram code is only able to log one set of data for each thread
as it is today. 

And as-is, the histogram assumes threads are distributed per-cpu via
affinity on SMP. Changing to a 3-D matrix is interesting, but how would
you represent that / store ?

What exactly are you testing / looking for?

Sven 

> Thks.
> 

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[GeunSik Lim]

Sorry I'm late according to going out.

On Tue, Jun 30, 2009 at 6:30 PM, Sven-Thorsten
Dietrich<sven@thebigcorporation.com> wrote:
> I that was a single CPU scenario.
> For testing on SMP, the cyclictest threads need to behave identicallly
> (even in priority) on all CPUs.
Additionally, I want you to consider  both Unicore  and Multicore
when some users  will use  -h option.

> That same argument also applies to this patch, doesn't it?
> In other words, without changing the existing code, you could change the
> prios for the histogram mode via a similar script, right?
Yes, It's right.
But. I am talking about output style of prios to avoid confusion
between without -h and with -h.
As you know, Cyclictest  display  result of latencies on the console
without detailed  explanation.
So, When we add -h option to get histogram data,  Most users have to
view source code
because of  the different output style suddenly.

> I don't disagree, but I think the proper fix may be to decouple
> histogram from priority, via another parameter.
>
> Note that the thread interval is also held constant when histogram is
> configured -- not just the priority.
>
>                if (!histogram) /* histogram requires same interval on CPUs*/
>                        interval += distance;
>
>
> The patch you sent basically reverts a bug-fix for the histogram
> application on SMP, but doesn't change the interval behavior.
>
> So you would also have to decouple the interval code as well.
Thank you for explanation  of  histogram related  patches like
priority and interval.
If you accept  my proposal to avoid confusion of output style,
I want to change  interval code reversely .  -:)

But,
If you and others don't  agree with my opinions,
I think that  We have to append  additional explanation in the "#>
cyclictest --help" to
understand output  using -h option at least like belows.

 before) "-h       --histogram=US    dump a latency histogram to
stdout after the run\n"
 after   ) "-h       --histogram=US    dump a latency histogram to
stdout after the run (with same priority about threads)\n"

How about you think  this my opinions?

> It would be better to be able to explicitly set priorities and intervals
> to be the same, when distributed per-CPU on SMP. That is one kind of
> test, which is important.
>
> Inversely relating priority versus interval on UP is another kind of
> test. This seems to be what you are trying to do.
>
> So to have both, means you can to stack threads on SMP and have multiple
> threads on each CPU, operating at increasing intervals. Each thread
> would report data.
>
> But that implies a 3-D table to log the data returned from cyclictest
> threads at lower priorities (lower than the highest priority).
>
> The histogram code is only able to log one set of data for each thread
> as it is today.
>
> And as-is, the histogram assumes threads are distributed per-cpu via
> affinity on SMP. Changing to a 3-D matrix is interesting, but how would
> you represent that / store ?
>
> What exactly are you testing / looking for?
I want to test maximum latencies based on background stress conditions  on SMP.
And, I  want to get histogram data about worstcase latencies using -h option.


-- 
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[Sven-Thorsten Dietrich]

On Wed, 2009-07-01 at 22:42 +0900, GeunSik Lim wrote:
> Sorry I'm late according to going out.
> 
> On Tue, Jun 30, 2009 at 6:30 PM, Sven-Thorsten
> Dietrich<sven@thebigcorporation.com> wrote:
> > I that was a single CPU scenario.
> > For testing on SMP, the cyclictest threads need to behave identicallly
> > (even in priority) on all CPUs.
> Additionally, I want you to consider  both Unicore  and Multicore
> when some users  will use  -h option.
> 

-h works fine that way now, but only for one thread / CPU.

> > That same argument also applies to this patch, doesn't it?
> > In other words, without changing the existing code, you could change the
> > prios for the histogram mode via a similar script, right?
> Yes, It's right.
> But. I am talking about output style of prios to avoid confusion
> between without -h and with -h.
> As you know, Cyclictest  display  result of latencies on the console
> without detailed  explanation.
> So, When we add -h option to get histogram data,  Most users have to
> view source code
> because of  the different output style suddenly.
> 

Well the out put IS different. So I don't understand your point?

If you want to document the format, that would be great, but I don't see
how this relates at all to this patch.

> > I don't disagree, but I think the proper fix may be to decouple
> > histogram from priority, via another parameter.
> >
> > Note that the thread interval is also held constant when histogram is
> > configured -- not just the priority.
> >
> >                if (!histogram) /* histogram requires same interval on CPUs*/
> >                        interval += distance;
> >
> >
> > The patch you sent basically reverts a bug-fix for the histogram
> > application on SMP, but doesn't change the interval behavior.
> >
> > So you would also have to decouple the interval code as well.
> Thank you for explanation  of  histogram related  patches like
> priority and interval.
> If you accept  my proposal to avoid confusion of output style,
> I want to change  interval code reversely .  -:)
> 

Not sure what you mean, but I still object to having different
priorities on different CPUs on SMP.

> But,
> If you and others don't  agree with my opinions,
> I think that  We have to append  additional explanation in the "#>
> cyclictest --help" to
> understand output  using -h option at least like belows.
> 
>  before) "-h       --histogram=US    dump a latency histogram to
> stdout after the run\n"
>  after   ) "-h       --histogram=US    dump a latency histogram to
> stdout after the run (with same priority about threads)\n"
> 
> How about you think  this my opinions?
> 

Sounds good. So you want to document this? 

You are still omitting the interval issue here, which is equally
important.

> > It would be better to be able to explicitly set priorities and intervals
> > to be the same, when distributed per-CPU on SMP. That is one kind of
> > test, which is important.
> >
> > Inversely relating priority versus interval on UP is another kind of
> > test. This seems to be what you are trying to do.
> >
> > So to have both, means you can to stack threads on SMP and have multiple
> > threads on each CPU, operating at increasing intervals. Each thread
> > would report data.
> >
> > But that implies a 3-D table to log the data returned from cyclictest
> > threads at lower priorities (lower than the highest priority).
> >
> > The histogram code is only able to log one set of data for each thread
> > as it is today.
> >
> > And as-is, the histogram assumes threads are distributed per-cpu via
> > affinity on SMP. Changing to a 3-D matrix is interesting, but how would
> > you represent that / store ?
> >
> > What exactly are you testing / looking for?
> I want to test maximum latencies based on background stress conditions  on SMP.
> And, I  want to get histogram data about worstcase latencies using -h option.
> 
> 

You can get that now. But if you run cyclictest on SMP at PRIO < 99, you
will get preempted by the migration thread, which is exactly why it
doesn't make sense to stagger the priorities.

In summary, I don't see the benefit of a 3-D histogram to log multiple
cyclic threads per-cpu, but if you want to send a patch to make this
happen, be my guest.

Otherwise, send a patch to add to the man pages to document the output
format.

Or send a patch to add parameters to control the interval and prio
staggering individually. 

But the patch you sent doesn't make any sense and won't produce correct
results on SMP, which you should have verified yourself by now.

Thanks,

Sven

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[GeunSik Lim]

On Thu, Jul 2, 2009 at 8:43 AM, Sven-Thorsten
Dietrich<sven@thebigcorporation.com> wrote:
>> But,
>> If you and others don't  agree with my opinions,
>> I think that  We have to append  additional explanation in the "#>
>> cyclictest --help" to
>> understand output  using -h option at least like belows.
>>
>>  before) "-h       --histogram=US    dump a latency histogram to
>> stdout after the run\n"
>>  after   ) "-h       --histogram=US    dump a latency histogram to
>> stdout after the run (with same priority about threads)\n"
>>
>> How about you think  this my opinions?
>>
>
> Sounds good. So you want to document this?
Yes. It's right.

> You can get that now. But if you run cyclictest on SMP at PRIO < 99, you
> will get preempted by the migration thread, which is exactly why it
> doesn't make sense to stagger the priorities.
>
> In summary, I don't see the benefit of a 3-D histogram to log multiple
> cyclic threads per-cpu, but if you want to send a patch to make this
> happen, be my guest.
I agree with your explanation.
> Otherwise, send a patch to add to the man pages to document the output
> format.
 I will send patch again with belows contents.
------------------------------------------------------------------------
diff --git a/src/cyclictest/cyclictest.8 b/src/cyclictest/cyclictest.8
index 48b2c5e..1bbdac0 100644
--- a/src/cyclictest/cyclictest.8
+++ b/src/cyclictest/cyclictest.8
@@ -91,7 +91,8 @@ event tracing (used with \-b)
 Enable function tracing using ftrace as tracer. This option is
available only with \-b.
 .TP
 .B \-h, \-\-histogram=MAXLATENCYINUS
-Dump latency histogram to stdout
+Dump latency histogram to stdout. US means that the max time to be be

tracked in microseconds. When you use -h option to get histogram data,
Cyclictest runs many threads with same priority without priority--.

+
 .TP
 .B \-i, \-\-interval=INTV
 Set the base interval of the thread(s) in microseconds (default is

1000us). This sets the interval of the first thread. See also \-d.

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 3e2d500..8ebeb33 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -774,6 +774,7 @@ static void display_help(void)
              "                           to modify value to minutes,
hours or days\n"
              "-h       --histogram=US    dump a latency histogram to
stdout after the run\n"
              "                           US is the max time to be be

tracked in microseconds\n"
----------------------------------------------------------------------------

>
> Or send a patch to add parameters to control the interval and prio
> staggering individually.
>
> But the patch you sent doesn't make any sense and won't produce correct
> results on SMP, which you should have verified yourself by now.





-- 
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[GeunSik Lim]

>  I will send patch again with belows contents.
> ------------------------------------------------------------------------
> diff --git a/src/cyclictest/cyclictest.8 b/src/cyclictest/cyclictest.8
> index 48b2c5e..1bbdac0 100644
> --- a/src/cyclictest/cyclictest.8
> +++ b/src/cyclictest/cyclictest.8
> @@ -91,7 +91,8 @@ event tracing (used with \-b)
>  Enable function tracing using ftrace as tracer. This option is
> available only with \-b.
>  .TP
>  .B \-h, \-\-histogram=MAXLATENCYINUS
> -Dump latency histogram to stdout
> +Dump latency histogram to stdout. US means that the max time to be be
>
> tracked in microseconds. When you use -h option to get histogram data,
> Cyclictest runs many threads with same priority without priority--.
>
> +
>  .TP
>  .B \-i, \-\-interval=INTV
>  Set the base interval of the thread(s) in microseconds (default is
>
> 1000us). This sets the interval of the first thread. See also \-d.
>
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 3e2d500..8ebeb33 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -774,6 +774,7 @@ static void display_help(void)
>              "                           to modify value to minutes,
> hours or days\n"
>              "-h       --histogram=US    dump a latency histogram to
> stdout after the run\n"
>              "                           US is the max time to be be
>
> tracked in microseconds\n"
> ----------------------------------------------------------------------------

Sorry. I mistook. I attached patch contents again.
Sven, Can you tell me your opinion about below contents?
Thks,

diff --git a/src/cyclictest/cyclictest.8 b/src/cyclictest/cyclictest.8
index 48b2c5e..1bbdac0 100644
--- a/src/cyclictest/cyclictest.8
+++ b/src/cyclictest/cyclictest.8
@@ -91,7 +91,8 @@ event tracing (used with \-b)
 Enable function tracing using ftrace as tracer. This option is
available only with \-b.
 .TP
 .B \-h, \-\-histogram=MAXLATENCYINUS
-Dump latency histogram to stdout
+Dump latency histogram to stdout. US means that the max time to be be
tracked in microseconds. When you use -h option to get histogram data,
Cyclictest runs many threads with same priority without priority--.
+
 .TP
 .B \-i, \-\-interval=INTV
 Set the base interval of the thread(s) in microseconds (default is
1000us). This sets the interval of the first thread. See also \-d.
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 3e2d500..8ebeb33 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -774,6 +774,7 @@ static void display_help(void)
 	       "                           to modify value to minutes, hours
or days\n"
 	       "-h       --histogram=US    dump a latency histogram to
stdout after the run\n"
 	       "                           US is the max time to be be
tracked in microseconds\n"
+	       "                           (with same priority about many threads)\n"
                "-w       --wakeup          task wakeup tracing (used
with -b)\n"
                "-W       --wakeuprt        rt task wakeup tracing
(used with -b)\n",
 	       tracers




-- 
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] cyclictest: Fix the same priority method of many threads with -h option.

[Sven-Thorsten Dietrich]

On Thu, 2009-07-02 at 12:06 +0900, GeunSik Lim wrote:
> >  I will send patch again with belows contents.

I'm ok with that.

Ack.

> > ------------------------------------------------------------------------
> > diff --git a/src/cyclictest/cyclictest.8 b/src/cyclictest/cyclictest.8
> > index 48b2c5e..1bbdac0 100644
> > --- a/src/cyclictest/cyclictest.8
> > +++ b/src/cyclictest/cyclictest.8
> > @@ -91,7 +91,8 @@ event tracing (used with \-b)
> >  Enable function tracing using ftrace as tracer. This option is
> > available only with \-b.
> >  .TP
> >  .B \-h, \-\-histogram=MAXLATENCYINUS
> > -Dump latency histogram to stdout
> > +Dump latency histogram to stdout. US means that the max time to be be
> >
> > tracked in microseconds. When you use -h option to get histogram data,
> > Cyclictest runs many threads with same priority without priority--.
> >
> > +
> >  .TP
> >  .B \-i, \-\-interval=INTV
> >  Set the base interval of the thread(s) in microseconds (default is
> >
> > 1000us). This sets the interval of the first thread. See also \-d.
> >
> > diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> > index 3e2d500..8ebeb33 100644
> > --- a/src/cyclictest/cyclictest.c
> > +++ b/src/cyclictest/cyclictest.c
> > @@ -774,6 +774,7 @@ static void display_help(void)
> >              "                           to modify value to minutes,
> > hours or days\n"
> >              "-h       --histogram=US    dump a latency histogram to
> > stdout after the run\n"
> >              "                           US is the max time to be be
> >
> > tracked in microseconds\n"
> > ----------------------------------------------------------------------------
> 
> Sorry. I mistook. I attached patch contents again.
> Sven, Can you tell me your opinion about below contents?
> Thks,
> 
> diff --git a/src/cyclictest/cyclictest.8 b/src/cyclictest/cyclictest.8
> index 48b2c5e..1bbdac0 100644
> --- a/src/cyclictest/cyclictest.8
> +++ b/src/cyclictest/cyclictest.8
> @@ -91,7 +91,8 @@ event tracing (used with \-b)
>  Enable function tracing using ftrace as tracer. This option is
> available only with \-b.
>  .TP
>  .B \-h, \-\-histogram=MAXLATENCYINUS
> -Dump latency histogram to stdout
> +Dump latency histogram to stdout. US means that the max time to be be
> tracked in microseconds. When you use -h option to get histogram data,
> Cyclictest runs many threads with same priority without priority--.
> +
>  .TP
>  .B \-i, \-\-interval=INTV
>  Set the base interval of the thread(s) in microseconds (default is
> 1000us). This sets the interval of the first thread. See also \-d.
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 3e2d500..8ebeb33 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -774,6 +774,7 @@ static void display_help(void)
>  	       "                           to modify value to minutes, hours
> or days\n"
>  	       "-h       --histogram=US    dump a latency histogram to
> stdout after the run\n"
>  	       "                           US is the max time to be be
> tracked in microseconds\n"
> +	       "                           (with same priority about many threads)\n"
>                 "-w       --wakeup          task wakeup tracing (used
> with -b)\n"
>                 "-W       --wakeuprt        rt task wakeup tracing
> (used with -b)\n",
>  	       tracers
> 
> 
> 
>