public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: John Kacur <jkacur@redhat.com>
Cc: RT <linux-rt-users@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] drivers/dca: convert dca_lock to a raw spinlock V2
Date: Thu, 29 Jul 2010 06:24:57 +0200	[thread overview]
Message-ID: <1280377497.9275.9.camel@marge.simson.net> (raw)
In-Reply-To: <AANLkTi=tp3NvXnEpko-9OHWePOMunCDUVFH7Nx_9yruG@mail.gmail.com>

On Wed, 2010-07-28 at 23:29 +0200, John Kacur wrote:

> Since the above looks slightly cleaner, maybe you just need to spin a
> clean-up patch
> of what is in tip/rt/2.6.33

Ok, dinky delta below.

drivers/dca: minor cleanup of dca-core.c

Signed-off-by: Mike Galbraith <efault@gmx.de>

--- a/drivers/dca/dca-core.c	2010-07-29 05:43:34.000000000 +0200
+++ b/drivers/dca/dca-core.c	2010-07-28 05:00:05.000000000 +0200
@@ -297,17 +297,19 @@ int register_dca_provider(struct dca_pro
 	int err;
 	unsigned long flags;
 	struct dca_domain *domain, *newdomain = NULL;
+        struct pci_bus *rc;
 
 	err = dca_sysfs_add_provider(dca, dev);
 	if (err)
 		return err;
 
 	raw_spin_lock_irqsave(&dca_lock, flags);
+	rc = dca_pci_rc_from_dev(dev);
 	domain = dca_get_domain(dev);
 	if (!domain) {
 		raw_spin_unlock_irqrestore(&dca_lock, flags);
 
-		newdomain = dca_allocate_domain(dca_pci_rc_from_dev(dev));
+		newdomain = dca_allocate_domain(rc);
 		if (!newdomain)
 			return -ENODEV;
 



  reply	other threads:[~2010-07-29  4:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07  8:29 [patch] drivers/dca: convert dca_lock to a raw spinlock Mike Galbraith
2010-07-23 10:18 ` [patch] drivers/dca: convert dca_lock to a raw spinlock V2 Mike Galbraith
2010-07-28 21:29   ` John Kacur
2010-07-29  4:24     ` Mike Galbraith [this message]
2010-07-29 18:44       ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280377497.9275.9.camel@marge.simson.net \
    --to=efault@gmx.de \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox