Re: [patch] drivers/dca: convert dca_lock to a raw spinlock V2

[John Kacur <jkacur@redhat.com>]

On Thu, 29 Jul 2010, Mike Galbraith wrote:

> On Wed, 2010-07-28 at 23:29 +0200, John Kacur wrote:
> 
> > Since the above looks slightly cleaner, maybe you just need to spin a
> > clean-up patch
> > of what is in tip/rt/2.6.33
> 
> Ok, dinky delta below.
> 
> drivers/dca: minor cleanup of dca-core.c
> 
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> 
> --- a/drivers/dca/dca-core.c	2010-07-29 05:43:34.000000000 +0200
> +++ b/drivers/dca/dca-core.c	2010-07-28 05:00:05.000000000 +0200
> @@ -297,17 +297,19 @@ int register_dca_provider(struct dca_pro
>  	int err;
>  	unsigned long flags;
>  	struct dca_domain *domain, *newdomain = NULL;
> +        struct pci_bus *rc;
>  
>  	err = dca_sysfs_add_provider(dca, dev);
>  	if (err)
>  		return err;
>  
>  	raw_spin_lock_irqsave(&dca_lock, flags);
> +	rc = dca_pci_rc_from_dev(dev);
>  	domain = dca_get_domain(dev);
>  	if (!domain) {
>  		raw_spin_unlock_irqrestore(&dca_lock, flags);
>  
> -		newdomain = dca_allocate_domain(dca_pci_rc_from_dev(dev));
> +		newdomain = dca_allocate_domain(rc);
>  		if (!newdomain)
>  			return -ENODEV;
>  
> 
> 
> --

Thanks Mike, I've applied this to my own tree for testing.
Acked-by: John Kacur <jkacur@redhat.com>