From: Steven Rostedt <rostedt@goodmis.org>
To: John Kacur <jkacur@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
rt-users <linux-rt-users@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'
Date: Thu, 08 Mar 2012 15:17:20 -0500 [thread overview]
Message-ID: <1331237840.25686.470.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1331237591-4406-1-git-send-email-jkacur@redhat.com>
On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> defined the following build break occurs.
>
> /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> make[2]: *** [block/blk-softirq.o] Error 1
> make[1]: *** [block/blk-softirq.o] Error 2
> make: *** [sub-make] Error 2
>
> This patch fixes the build error by adding a define to the
> !CONFIG_PREEMPT_COUNT section.
>
> Signed-off-by: Clark Williams <williams@redhat.com>
Why Clark's SOB? Did he write it and send it to you?
-- Steve
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
> include/linux/preempt.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/preempt.h b/include/linux/preempt.h
> index fa40695..58d8982 100644
> --- a/include/linux/preempt.h
> +++ b/include/linux/preempt.h
> @@ -107,6 +107,7 @@ do { \
> #define preempt_disable_notrace() do { } while (0)
> #define preempt_enable_no_resched_notrace() do { } while (0)
> #define preempt_enable_notrace() do { } while (0)
> +#define preempt_check_resched_rt() do { } while (0)
>
> #endif /* CONFIG_PREEMPT_COUNT */
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-08 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 20:13 [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt' John Kacur
2012-03-08 20:17 ` Steven Rostedt [this message]
2012-03-08 20:22 ` Clark Williams
2012-03-08 20:34 ` Steven Rostedt
2012-03-08 21:04 ` John Kacur
2012-03-13 19:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331237840.25686.470.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox