Re: [PATCH-RT] preempt.h: Fix implicit declaration of 'preempt_check_resched_rt'

[Clark Williams <williams@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On Thu, 08 Mar 2012 15:17:20 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Thu, 2012-03-08 at 21:13 +0100, John Kacur wrote:
> > When building a non-preempt kernel where CONFIG_PREEMPT_COUNT is not
> > defined the following build break occurs.
> > 
> > /home/jkacur/linux-rt/block/blk-softirq.c: In function ‘trigger_softirq’:
> > /home/jkacur/linux-rt/block/blk-softirq.c:54: error: implicit declaration of function ‘preempt_check_resched_rt’
> > make[2]: *** [block/blk-softirq.o] Error 1
> > make[1]: *** [block/blk-softirq.o] Error 2
> > make: *** [sub-make] Error 2
> > 
> > This patch fixes the build error by adding a define to the
> > !CONFIG_PREEMPT_COUNT section.
> > 
> > Signed-off-by: Clark Williams <williams@redhat.com>
> 
> Why Clark's SOB? Did he write it and send it to you?

I suppose to be technically correct it should have been a Tested-by:

John found it while I was working on it and I tested it for him.

Clark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]