Re: [RESEND] [PATCH V2 ]cyclictest: fix invalid comment of debugfs mount directory.

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

Hi,

On Mon, Jun 08, 2009 at 10:52:09AM +0900, GeunSik Lim wrote:
> Dear Clark Williams, 
> 
> This is tracing(ftrace) directory's comment related patch file.
> Please, merge this patch.
> 
> 
> 
> Regards,
> GeunSik Lim. 
> 
> 
> Subject: [RESEND] [PATCH V2 ]cyclictest: Fix invalid comment of debugfs mount directory.
> 
> The "debugfs/tracing" name is invalid as the mountpont of debugfs filesystem.
> 
> For example,
> /sys/kernel/debug/tracing/ or
> /debug/tracing/ or
> /debugfs/tracing/ ...
> 
> Fix directory name normally from debugfs/tracing to */tracing.
> 
>          Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
>          Reviewed-by  : Luis Claudio R. Goncalves <lclaudio@uudg.org>
hhm, I don't know how Clark handles these flags, but I wouldn't count
the comments by Luis Claudio R. Goncalves as review.  Still more as you
didn't follow his advice and I would only add this tag after the
reviewer is OK with the result.
<nitpick>
In the kernel the colons and names usually are not aligned.
</nitpick>

> ---
>  src/cyclictest/cyclictest.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index be9a3f9..2186de2 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -179,7 +179,9 @@ static char functiontracer[MAX_PATH];
>  static char traceroptions[MAX_PATH];
>  
>  /*
> - * Finds the path to the debugfs/tracing
> + * Finds the path to the tracing direcroty inside the default 
s/direcroty/directory/

> + * mountpoint of debugfs filesystem.
> + * - debugfs related reference: http://lwn.net/Articles/334546/
set_debugfileprefix doesn't depend on a "default mountpoint", it parses
/proc/mounts, so it should even work if you mount it somewhere below /home.

And I'm not convinced that adding a link to lwn is a good idea.  I would
expect that the normal cyclictest hacker knows about debugfs.

So what about simply

+ * Finds the tracing directory in a mounted debugfs.

?  Ah, just see that is similar to the suggestion by Luis Claudio R.
Goncalves.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html