[PATCH ]cyclictest: fix invalid comment of debugfs mount directory.

[PATCH ]cyclictest: fix invalid comment of debugfs mount directory.

[GeunSik Lim]

Dear Clark Williams, 

Please, Fix the "debugfs/tracing" name in cyclictest.c source file. 

P.S: Now, version is differenct between shortlog(v0.39) and tags(v0.40). 
     Maybe, You have to check version name of shortlog table. 
     http://git.kernel.org/?p=linux/kernel/git/clrkwllms/rt-tests.git;a=summary

Thanks,
GeunSik Lim. 



Subject: [PATCH ]cyclictest: Fix invalid comment of debugfs mount directory.

The "debugfs/tracing" name is invalid.
Example,
#> mount -t debugfs nodev /sys/kernel/debug [enter]
#> ln -s /sys/kernel/debug /debug [enter]

Fix directory name normally from debugfs/tracing to debug/tracing.

         Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
---
 src/cyclictest/cyclictest.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index be9a3f9..32a120a 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -179,7 +179,7 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the path to the debug/tracing
  */
 static int set_debugfileprefix(void)
 {
-- 
1.6.3.1


-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***" 
in the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

GeunSik Lim (  S A M S U N G     E L E C T R O N I C S  )
e-Mail  :1) geunsik.lim@samsung.com
         2) leemgs@gmail.com , leemgs1@gmail.com
HomePage: http://blog.naver.com/invain/
-----------------------------------------------

Re: [PATCH ]cyclictest: fix invalid comment of debugfs mount directory.

[Luis Claudio R. Goncalves]

On Mon, Jun 01, 2009 at 11:06:27AM +0900, GeunSik Lim wrote:
| 
| 
| Dear Clark Williams, 
| 
| Please, Fix the "debugfs/tracing" name in cyclictest.c source file. 
| 
| P.S: Now, version is differenct between shortlog(v0.39) and tags(v0.40). 
|      Maybe, You have to check version name of shortlog table. 
|      http://git.kernel.org/?p=linux/kernel/git/clrkwllms/rt-tests.git;a=summary
| 
| Thanks,
| GeunSik Lim. 
| 
| 
| 
| Subject: [PATCH ]cyclictest: Fix invalid comment of debugfs mount directory.
| 
| The "debugfs/tracing" name is invalid.
| Example,
| #> mount -t debugfs nodev /sys/kernel/debug [enter]
| #> ln -s /sys/kernel/debug /debug [enter]
| 
| Fix directory name normally from debugfs/tracing to debug/tracing.

GeunSik,

I would suggest changing your comment in the patch to something like:

	/* finds the path to the tracing dir inside debugfs mountpoint */

Because it is not written in the stone where debugfs should be mounted.
There is a suggested place, that already changed at least twice. So, the
function locates the debugfs mountpoint, wherever it is and looks for the
tracing directory.

Luis


|          Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
| ---
|  src/cyclictest/cyclictest.c |    2 +-
|  1 files changed, 1 insertions(+), 1 deletions(-)
| 
| diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
| index be9a3f9..32a120a 100644
| --- a/src/cyclictest/cyclictest.c
| +++ b/src/cyclictest/cyclictest.c
| @@ -179,7 +179,7 @@ static char functiontracer[MAX_PATH];
|  static char traceroptions[MAX_PATH];
|  
|  /*
| - * Finds the path to the debugfs/tracing
| + * Finds the path to the debug/tracing
|   */
|  static int set_debugfileprefix(void)
|  {
| -- 
| 1.6.3.1

-- 
[ Luis Claudio R. Goncalves             Red Hat  -  Realtime Team ]
[ Fingerprint: 4FDD B8C4 3C59 34BD 8BE9  2696 7203 D980 A448 C8F8 ]

Re: [PATCH ]cyclictest: fix invalid comment of debugfs mount directory.

[GeunSik Lim]

On Mon, Jun 1, 2009 at 9:01 PM, Luis Claudio R. Goncalves
<lclaudio@uudg.org> wrote:

> GeunSik,
> I would suggest changing your comment in the patch to something like:
>
>        /* finds the path to the tracing dir inside debugfs mountpoint */
>
> Because it is not written in the stone where debugfs should be mounted.
> There is a suggested place, that already changed at least twice. So, the
> function locates the debugfs mountpoint, wherever it is and looks for the
> tracing directory.
Thanks your opinion. It's right.
I will modify  ftrace directory name from "debug/tracing" to " tracing".

-- 
Regards,
GeunSik Lim ( SAMSUNG ELECTRONICS)
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH V2 ]cyclictest: fix invalid comment of debugfs mount directory.

[GeunSik Lim]

 
Dear Clark Williams, 

This is tracing directory's comment related patch files.
Please, merge my patch.

Regards,
GeunSik Lim. 




Subject: [PATCH V2] cyclictest: Fix invalid comment of debugfs mount directory.

The "debugfs/tracing" name is invalid in cyclictest.c source file.
Example,
#> mount -t debugfs nodev /sys/kernel/debug [enter]
#> ln -s /sys/kernel/debug /debug [enter]
#> ls /debug/tracing [enter]

I updated a initial patch thanks to Luis Claudio R. Goncalves.
Fix directory name normally from debugfs/tracing to */tracing.

         Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
         Reviewed-by  : Luis Claudio R. Goncalves <lclaudio@uudg.org>
---
 src/cyclictest/cyclictest.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index be9a3f9..2186de2 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -179,7 +179,9 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the path to the tracing direcroty inside the default 
+ * mountpoint of debugfs filesystem.
+ * - debugfs related reference: http://lwn.net/Articles/334546/
  */
 static int set_debugfileprefix(void)
 {
-- 
1.6.3.1



-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***" 
in the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

GeunSik Lim ( Samsung Electronics )
e-Mail  :1) geunsik.lim@samsung.com
         2) leemgs@gmail.com , leemgs1@gmail.com
HomePage: http://blog.naver.com/invain/
-----------------------------------------------

[RESEND] [PATCH V2 ]cyclictest: fix invalid comment of debugfs mount directory.

[GeunSik Lim]

Dear Clark Williams, 

This is tracing(ftrace) directory's comment related patch file.
Please, merge this patch.



Regards,
GeunSik Lim. 


Subject: [RESEND] [PATCH V2 ]cyclictest: Fix invalid comment of debugfs mount directory.

The "debugfs/tracing" name is invalid as the mountpont of debugfs filesystem.

For example,
/sys/kernel/debug/tracing/ or
/debug/tracing/ or
/debugfs/tracing/ ...

Fix directory name normally from debugfs/tracing to */tracing.

         Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
         Reviewed-by  : Luis Claudio R. Goncalves <lclaudio@uudg.org>
---
 src/cyclictest/cyclictest.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index be9a3f9..2186de2 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -179,7 +179,9 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the path to the tracing direcroty inside the default 
+ * mountpoint of debugfs filesystem.
+ * - debugfs related reference: http://lwn.net/Articles/334546/
  */
 static int set_debugfileprefix(void)
 {
-- 
1.6.3.1




-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***" 
in the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

GeunSik Lim ( Samsung Electronics )
e-Mail  :1) geunsik.lim@samsung.com
         2) leemgs@gmail.com , leemgs1@gmail.com
HomePage: http://blog.naver.com/invain/
-----------------------------------------------

Re: [RESEND] [PATCH V2 ]cyclictest: fix invalid comment of debugfs mount directory.

[Uwe Kleine-König]

Hi,

On Mon, Jun 08, 2009 at 10:52:09AM +0900, GeunSik Lim wrote:
> Dear Clark Williams, 
> 
> This is tracing(ftrace) directory's comment related patch file.
> Please, merge this patch.
> 
> 
> 
> Regards,
> GeunSik Lim. 
> 
> 
> Subject: [RESEND] [PATCH V2 ]cyclictest: Fix invalid comment of debugfs mount directory.
> 
> The "debugfs/tracing" name is invalid as the mountpont of debugfs filesystem.
> 
> For example,
> /sys/kernel/debug/tracing/ or
> /debug/tracing/ or
> /debugfs/tracing/ ...
> 
> Fix directory name normally from debugfs/tracing to */tracing.
> 
>          Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
>          Reviewed-by  : Luis Claudio R. Goncalves <lclaudio@uudg.org>
hhm, I don't know how Clark handles these flags, but I wouldn't count
the comments by Luis Claudio R. Goncalves as review.  Still more as you
didn't follow his advice and I would only add this tag after the
reviewer is OK with the result.
<nitpick>
In the kernel the colons and names usually are not aligned.
</nitpick>

> ---
>  src/cyclictest/cyclictest.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index be9a3f9..2186de2 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -179,7 +179,9 @@ static char functiontracer[MAX_PATH];
>  static char traceroptions[MAX_PATH];
>  
>  /*
> - * Finds the path to the debugfs/tracing
> + * Finds the path to the tracing direcroty inside the default 
s/direcroty/directory/

> + * mountpoint of debugfs filesystem.
> + * - debugfs related reference: http://lwn.net/Articles/334546/
set_debugfileprefix doesn't depend on a "default mountpoint", it parses
/proc/mounts, so it should even work if you mount it somewhere below /home.

And I'm not convinced that adding a link to lwn is a good idea.  I would
expect that the normal cyclictest hacker knows about debugfs.

So what about simply

+ * Finds the tracing directory in a mounted debugfs.

?  Ah, just see that is similar to the suggestion by Luis Claudio R.
Goncalves.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RESEND] [PATCH V2 ]cyclictest: fix invalid comment of debugfs mount directory.

[GeunSik Lim]

2009/6/8 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
>>          Signed-off-by: GeunSik Lim <geunsik.lim@samsung.com>
>>          Reviewed-by  : Luis Claudio R. Goncalves <lclaudio@uudg.org>
> hhm, I don't know how Clark handles these flags, but I wouldn't count
> the comments by Luis Claudio R. Goncalves as review.  Still more as you
> didn't follow his advice and I would only add this tag after the
> reviewer is OK with the result.
> <nitpick>
> In the kernel the colons and names usually are not aligned.
> </nitpick>
Thank you for your advice and opinion about my trivital patch.
Sorry.  Maybe, I mistooked  about  how to append  "Reviewed-by tag".

>> + * mountpoint of debugfs filesystem.
>> + * - debugfs related reference: http://lwn.net/Articles/334546/
> set_debugfileprefix doesn't depend on a "default mountpoint", it parses
> /proc/mounts, so it should even work if you mount it somewhere below /home.
> And I'm not convinced that adding a link to lwn is a good idea.  I would
> expect that the normal cyclictest hacker knows about debugfs.
Yes, It's correct.  But, I think that a detailed remark is not bad.

>
> So what about simply
>
> + * Finds the tracing directory in a mounted debugfs.
>
> ?  Ah, just see that is similar to the suggestion by Luis Claudio R.
> Goncalves.
Your comment is also correct.
Anyway, I want Clark to edit "debugfs/tracing" comment  with a suitable
expression normally.

-- 
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
           leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] Make comment describing set_debugfileprefix a bit clearer

[Uwe Kleine-König]

This was noticed by GeunSik Lim.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: GeunSik Lim <leemgs1@gmail.com>
Cc: Luis Claudio R. Goncalves <lclaudio@uudg.org>
Cc: Clark Williams <williams@redhat.com>
---
Hello,

just to have the alternative suggestion in patch form, too.

@Clark:  If you prefer this version, too, you can pull it from my repo at:

	git://git.pengutronix.de/git/ukl/rt-tests.git for-clark

together with a manpage format fix.

Best regards
Uwe

 src/cyclictest/cyclictest.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index be9a3f9..558091e 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -179,7 +179,7 @@ static char functiontracer[MAX_PATH];
 static char traceroptions[MAX_PATH];
 
 /*
- * Finds the path to the debugfs/tracing
+ * Finds the tracing directory in a mounted debugfs
  */
 static int set_debugfileprefix(void)
 {
-- 
1.6.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Make comment describing set_debugfileprefix a bit clearer

[Clark Williams]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 12 Jun 2009 15:41:26 +0200
Uwe Kleine-König  <u.kleine-koenig@pengutronix.de> wrote:

> This was noticed by GeunSik Lim.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: GeunSik Lim <leemgs1@gmail.com>
> Cc: Luis Claudio R. Goncalves <lclaudio@uudg.org>
> Cc: Clark Williams <williams@redhat.com>
> ---
> Hello,
> 
> just to have the alternative suggestion in patch form, too.
> 
> @Clark:  If you prefer this version, too, you can pull it from my repo at:
> 
> 	git://git.pengutronix.de/git/ukl/rt-tests.git for-clark
> 
> together with a manpage format fix.
> 
> Best regards
> Uwe
> 

Thanks Uwe (and GeunSik). I pulled from the above and merged. 

I'm working on getting hwlatdetect to work properly with jcm's latest
version, so it will be a bit before I push a new version of rt-tests.

Clark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)

iEYEARECAAYFAkoydesACgkQHyuj/+TTEp0qEwCeLHj9Z8SzdX1zSLPJnvMV6p0+
VscAn2KTlSinzvkIWSrBNW3oLztgRqKA
=JCFd
-----END PGP SIGNATURE-----