From: Sven-Thorsten Dietrich <thebigcorporation@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andrew Chew" <achew@nvidia.com>,
linux-rt-users@vger.kernel.org,
"Alessandro Zummo" <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, jkastner@redhat.com
Subject: Re: [PATCH] rtc-tegra: properly initialize spinlock
Date: Fri, 22 Jul 2011 16:19:19 -0700 [thread overview]
Message-ID: <58E25CAF-EAC4-4613-81B2-D713F5DC8CEF@gmail.com> (raw)
In-Reply-To: <20110722151338.9b1e9594.akpm@linux-foundation.org>
On Jul 22, 2011, at 3:13 PM, Andrew Morton wrote:
> On Fri, 22 Jul 2011 10:35:56 +0200
> Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:
>
>> Using __SPIN_LOCK_UNLOCKED for a dynamically allocated lock is wrong and
>> breaks with PREEMPT_RT_FULL.
>
> Please define "breaks". Lockdep warnings? Deadlocks?
Narrr, I think its a compile-time problem with the static initializer.
Sven
>
>> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c
>> index 2fc31aa..75259fe 100644
>> --- a/drivers/rtc/rtc-tegra.c
>> +++ b/drivers/rtc/rtc-tegra.c
>> @@ -343,7 +343,7 @@ static int __devinit tegra_rtc_probe(struct platform_device *pdev)
>>
>> /* set context info. */
>> info->pdev = pdev;
>> - info->tegra_rtc_lock = __SPIN_LOCK_UNLOCKED(info->tegra_rtc_lock);
>> + spin_lock_init(&info->tegra_rtc_lock);
>>
>> platform_set_drvdata(pdev, info);
>>
>> --
>> 1.7.5.4
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-22 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 8:35 [PATCH] rtc-tegra: properly initialize spinlock Uwe Kleine-König
2011-07-22 22:13 ` Andrew Morton
2011-07-22 23:19 ` Sven-Thorsten Dietrich [this message]
2011-07-23 7:29 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58E25CAF-EAC4-4613-81B2-D713F5DC8CEF@gmail.com \
--to=thebigcorporation@gmail.com \
--cc=a.zummo@towertech.it \
--cc=achew@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jkastner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox