From: Thomas Gleixner <tglx@linutronix.de>
To: Sven-Thorsten Dietrich <thebigcorporation@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andrew Chew" <achew@nvidia.com>,
linux-rt-users@vger.kernel.org,
"Alessandro Zummo" <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org, jkastner@redhat.com
Subject: Re: [PATCH] rtc-tegra: properly initialize spinlock
Date: Sat, 23 Jul 2011 09:29:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1107230926420.2702@ionos> (raw)
In-Reply-To: <58E25CAF-EAC4-4613-81B2-D713F5DC8CEF@gmail.com>
On Fri, 22 Jul 2011, Sven-Thorsten Dietrich wrote:
>
> On Jul 22, 2011, at 3:13 PM, Andrew Morton wrote:
>
> > On Fri, 22 Jul 2011 10:35:56 +0200
> > Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:
> >
> >> Using __SPIN_LOCK_UNLOCKED for a dynamically allocated lock is wrong and
> >> breaks with PREEMPT_RT_FULL.
> >
> > Please define "breaks". Lockdep warnings? Deadlocks?
>
> Narrr, I think its a compile-time problem with the static initializer.
Correct. The macro expansion magic of the static initializer barfs and
with lockdep the lockdep key assignment is missing.
Thanks,
tglx
prev parent reply other threads:[~2011-07-23 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 8:35 [PATCH] rtc-tegra: properly initialize spinlock Uwe Kleine-König
2011-07-22 22:13 ` Andrew Morton
2011-07-22 23:19 ` Sven-Thorsten Dietrich
2011-07-23 7:29 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1107230926420.2702@ionos \
--to=tglx@linutronix.de \
--cc=a.zummo@towertech.it \
--cc=achew@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jkastner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=thebigcorporation@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox