Re: [PATCH 1/4] Fixed missing parsing of short arguments in classic_pi

[John Kacur <jkacur@redhat.com>]

On Tue, 22 Dec 2009, David Sommerseth wrote:

> Signed-off-by: David Sommerseth <davids@redhat.com>
> ---
>  src/pi_tests/classic_pi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/pi_tests/classic_pi.c b/src/pi_tests/classic_pi.c
> index 59e907b..2b8ef3d 100644
> --- a/src/pi_tests/classic_pi.c
> +++ b/src/pi_tests/classic_pi.c
> @@ -198,7 +198,7 @@ int main(int argc, char **argv)
>  	setvbuf (stdout, NULL, _IONBF, 0);
>  
>  	/* process command line arguments */
> -	while ((opt = getopt_long(argc, argv, "+", options, NULL)) != -1) {
> +	while ((opt = getopt_long(argc, argv, "vqni:", options, NULL)) != -1) {
>  		switch (opt) {
>  		case '?':
>  			usage();
> -- 
> 1.6.2.5

David

Thanks - I fixed-up your patch to put back the leading '+' or else you 
change the behaviour when a non-option is given between two real options.

We have been actively maintaining pi_stress, but classic_stress is a proof
of concept, so I don't know how much longer we want to maintain the code
here.

I pushed your patch with my modification to
git://git.kernel.org/pub/scm/linux/kernel/git/jkacur/rt-tests.git
branch: rt-tests-dev-new

Clark please pull above.
>From 2e2c1eb6ae2147ae68f1af4a0cc90066ad3c4bd0 Mon Sep 17 00:00:00 2001
From: David Sommerseth <davids@redhat.com>
Date: Tue, 22 Dec 2009 16:47:35 +0100
Subject: [PATCH] Fixed missing parsing of short arguments in classic_pi (David)
 - Added the '+' back to the arguments (John)

Signed-off-by: David Sommerseth <davids@redhat.com>
Signed-off-by: John Kacur <jkacur@redhat.com>
---
 src/pi_tests/classic_pi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/pi_tests/classic_pi.c b/src/pi_tests/classic_pi.c
index 59e907b..91a8d6a 100644
--- a/src/pi_tests/classic_pi.c
+++ b/src/pi_tests/classic_pi.c
@@ -198,7 +198,7 @@ int main(int argc, char **argv)
 	setvbuf (stdout, NULL, _IONBF, 0);
 
 	/* process command line arguments */
-	while ((opt = getopt_long(argc, argv, "+", options, NULL)) != -1) {
+	while ((opt = getopt_long(argc, argv, "+vqni:", options, NULL)) != -1) {
 		switch (opt) {
 		case '?':
 			usage();
-- 
1.6.0.6