From: John Kacur <jkacur@redhat.com>
To: David Sommerseth <davids@redhat.com>
Cc: linux-rt-users@vger.kernel.org, williams@redhat.com
Subject: Re: [PATCH 3/4] Added --help screen info about -M / --refresh-on-max in cyclictest
Date: Tue, 22 Dec 2009 22:02:38 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0912222201120.8838@localhost.localdomain> (raw)
In-Reply-To: <1261496858-12744-4-git-send-email-davids@redhat.com>
On Tue, 22 Dec 2009, David Sommerseth wrote:
> Also renamed --refresh_on_max to --refresh-on-max
>
> Signed-off-by: David Sommerseth <davids@redhat.com>
> ---
> src/cyclictest/cyclictest.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 223f343..7979a77 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -788,6 +788,7 @@ static void display_help(int error)
> "-I --irqsoff Irqsoff tracing (used with -b)\n"
> "-l LOOPS --loops=LOOPS number of loops: default=0(endless)\n"
> "-m --mlockall lock current and future memory allocations\n"
> + "-M --refresh-on-max delay updating the screen until a new max latency is hit\n"
> "-n --nanosleep use clock_nanosleep\n"
> "-N --nsecs print results in ns instead of us (default us)\n"
> "-o RED --oscope=RED oscilloscope mode, reduce verbose output by RED\n"
> @@ -910,7 +911,7 @@ static void process_options (int argc, char *argv[])
> {"irqsoff", no_argument, NULL, 'I'},
> {"loops", required_argument, NULL, 'l'},
> {"mlockall", no_argument, NULL, 'm' },
> - {"refresh_on_max", no_argument, NULL, 'M' },
> + {"refresh-on-max", no_argument, NULL, 'M' },
> {"nanosleep", no_argument, NULL, 'n'},
> {"nsecs", no_argument, NULL, 'N'},
> {"oscope", required_argument, NULL, 'o'},
> --
> 1.6.2.5
>
>
Hmnn, I'm not sure that I want to apply this one.
What is the motifivation for changing the name to refresh-on-max?
Right now refresh_on_max matches the global variable.
next prev parent reply other threads:[~2009-12-22 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 15:47 [PATCH 0/4] Minor rt-tests updates David Sommerseth
2009-12-22 15:47 ` [PATCH 1/4] Fixed missing parsing of short arguments in classic_pi David Sommerseth
2009-12-22 20:50 ` John Kacur
2009-12-22 15:47 ` [PATCH 2/4] Missing parsing of --mlockall in signaltest David Sommerseth
2009-12-22 21:00 ` John Kacur
2009-12-22 15:47 ` [PATCH 3/4] Added --help screen info about -M / --refresh-on-max in cyclictest David Sommerseth
2009-12-22 21:02 ` John Kacur [this message]
2009-12-23 9:09 ` David Sommerseth
2009-12-22 21:59 ` John Kacur
2009-12-22 15:47 ` [PATCH 4/4] Updated man page to reflect --refresh-on-max agrument name change David Sommerseth
2009-12-22 22:00 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912222201120.8838@localhost.localdomain \
--to=jkacur@redhat.com \
--cc=davids@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox