From: John Kacur <jkacur@redhat.com>
To: Josh Cartwright <joshc@ni.com>
Cc: Clark Williams <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
linux-rt-users@vger.kernel.org,
Robert Yang <liezhi.yang@windriver.com>,
Kai Kang <kai.kang@windriver.com>
Subject: Re: [PATCH rt-tests 3/4] rt-tests: workaround poor gzip implementations
Date: Wed, 2 Sep 2015 14:58:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.20.1509021458250.19826@riemann> (raw)
In-Reply-To: <c2b24f2ac77833c8bf32d3e1a7d2fe8ff22ffda9.1440720422.git.joshc@ni.com>
On Thu, 27 Aug 2015, Josh Cartwright wrote:
> Some 'gzip' implementations, in particular 'pigz' don't properly handle
> the '-c' argument if it's passed after the name of the input files.
>
> Work around this by putting the '-c' option before the file names.
>
> Inspired by patches in OpenEmbedded by Robert Yang and Kai Kang.
>
> Cc: Robert Yang <liezhi.yang@windriver.com>
> Cc: Kai Kang <kai.kang@windriver.com>
> Signed-off-by: Josh Cartwright <joshc@ni.com>
> ---
> Makefile | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e5a9942..5c4dd04 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -137,15 +137,15 @@ install: all install_hwlatdetect
> cp $(TARGETS) "$(DESTDIR)$(bindir)"
> install -D -m 644 src/backfire/backfire.c "$(DESTDIR)$(srcdir)/backfire/backfire.c"
> install -m 644 src/backfire/Makefile "$(DESTDIR)$(srcdir)/backfire/Makefile"
> - gzip src/backfire/backfire.4 -c >"$(DESTDIR)$(mandir)/man4/backfire.4.gz"
> - gzip src/cyclictest/cyclictest.8 -c >"$(DESTDIR)$(mandir)/man8/cyclictest.8.gz"
> - gzip src/pi_tests/pi_stress.8 -c >"$(DESTDIR)$(mandir)/man8/pi_stress.8.gz"
> - gzip src/ptsematest/ptsematest.8 -c >"$(DESTDIR)$(mandir)/man8/ptsematest.8.gz"
> - gzip src/sigwaittest/sigwaittest.8 -c >"$(DESTDIR)$(mandir)/man8/sigwaittest.8.gz"
> - gzip src/svsematest/svsematest.8 -c >"$(DESTDIR)$(mandir)/man8/svsematest.8.gz"
> - gzip src/pmqtest/pmqtest.8 -c >"$(DESTDIR)$(mandir)/man8/pmqtest.8.gz"
> - gzip src/backfire/sendme.8 -c >"$(DESTDIR)$(mandir)/man8/sendme.8.gz"
> - gzip src/hackbench/hackbench.8 -c >"$(DESTDIR)$(mandir)/man8/hackbench.8.gz"
> + gzip -c src/backfire/backfire.4 >"$(DESTDIR)$(mandir)/man4/backfire.4.gz"
> + gzip -c src/cyclictest/cyclictest.8 >"$(DESTDIR)$(mandir)/man8/cyclictest.8.gz"
> + gzip -c src/pi_tests/pi_stress.8 >"$(DESTDIR)$(mandir)/man8/pi_stress.8.gz"
> + gzip -c src/ptsematest/ptsematest.8 >"$(DESTDIR)$(mandir)/man8/ptsematest.8.gz"
> + gzip -c src/sigwaittest/sigwaittest.8 >"$(DESTDIR)$(mandir)/man8/sigwaittest.8.gz"
> + gzip -c src/svsematest/svsematest.8 >"$(DESTDIR)$(mandir)/man8/svsematest.8.gz"
> + gzip -c src/pmqtest/pmqtest.8 >"$(DESTDIR)$(mandir)/man8/pmqtest.8.gz"
> + gzip -c src/backfire/sendme.8 >"$(DESTDIR)$(mandir)/man8/sendme.8.gz"
> + gzip -c src/hackbench/hackbench.8 >"$(DESTDIR)$(mandir)/man8/hackbench.8.gz"
>
> .PHONY: install_hwlatdetect
> install_hwlatdetect: hwlatdetect
> @@ -154,7 +154,7 @@ install_hwlatdetect: hwlatdetect
> install -D -m 755 src/hwlatdetect/hwlatdetect.py $(DESTDIR)$(PYLIB)/hwlatdetect.py ; \
> rm -f "$(DESTDIR)$(bindir)/hwlatdetect" ; \
> ln -s $(PYLIB)/hwlatdetect.py "$(DESTDIR)$(bindir)/hwlatdetect" ; \
> - gzip src/hwlatdetect/hwlatdetect.8 -c >"$(DESTDIR)$(mandir)/man8/hwlatdetect.8.gz" ; \
> + gzip -c src/hwlatdetect/hwlatdetect.8 >"$(DESTDIR)$(mandir)/man8/hwlatdetect.8.gz" ; \
> fi
>
> .PHONY: release
> --
> 2.5.0
Signed-off-by: John Kacur <jkacur@redhat.com>
next prev parent reply other threads:[~2015-09-02 12:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 0:19 [PATCH rt-tests 0/4] build tweaks and a bug fix Josh Cartwright
2015-08-28 0:19 ` [PATCH rt-tests 1/4] rt-tests: Allow for user-specified PYLIB Josh Cartwright
2015-09-02 12:53 ` John Kacur
2015-08-28 0:19 ` [PATCH rt-tests 2/4] rt-tests: Break out install_hwlatdetect Josh Cartwright
2015-09-02 12:56 ` John Kacur
2015-08-28 0:19 ` [PATCH rt-tests 3/4] rt-tests: workaround poor gzip implementations Josh Cartwright
2015-09-02 12:58 ` John Kacur [this message]
2015-08-28 0:19 ` [PATCH rt-tests 4/4] hackbench: cleanup error handling in create_worker Josh Cartwright
2015-09-02 13:01 ` John Kacur
2015-08-28 17:50 ` [PATCH rt-tests 0/4] build tweaks and a bug fix Clark Williams
2015-08-28 17:54 ` Darren Hart
2015-08-28 18:11 ` Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1509021458250.19826@riemann \
--to=jkacur@redhat.com \
--cc=joshc@ni.com \
--cc=kai.kang@windriver.com \
--cc=liezhi.yang@windriver.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox