* [PATCH v3 0/4] rtc: rzn1: cleanups, R-Car X5H enablement
@ 2026-09-17 11:13 Wolfram Sang
2026-09-17 11:13 ` [PATCH v3 1/4] dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example Wolfram Sang
` (3 more replies)
0 siblings, 4 replies; 15+ messages in thread
From: Wolfram Sang @ 2026-09-17 11:13 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Lad Prabhakar, Wolfram Sang, Alexandre Belloni, Conor Dooley,
devicetree, Geert Uytterhoeven, Krzysztof Kozlowski, linux-rtc,
Magnus Damm, Miquel Raynal, Rob Herring
This series adds RTC support for the Renesas R-Car X5H SoC.
Changes since v2:
* X5H is not compatible with the generic Gen5 family. So, only support
X5H for now and add the Gen5 family later once HW is available
* added tags
Thanks for all the reviews of v2!
These patches have been tested on the original RZ/N1D board and the new
X5H Ironhide board. 'rtctest' passed on both SoCs. On X5H, some tests
are skipped, of course, because no alarms are supported.
'dt_binding_check' and 'dtbs_check' did not find any issues, for both,
RZ/N1D and R-Car X5H. I also verified for both that it rightfully
complains when irqs are different from what is expected.
A branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/x5h/rtc-experimental
Looking forward to comments.
Wolfram Sang (4):
dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example
dt-bindings: rtc: rzn1: add SoC names next to their IDs
dt-bindings: rtc: rzn1: add R-Car X5H support
rtc: rzn1: add R-Car X5H support
.../bindings/rtc/renesas,rzn1-rtc.yaml | 30 ++++++++---
drivers/rtc/rtc-rzn1.c | 53 ++++++++++++-------
2 files changed, 57 insertions(+), 26 deletions(-)
--
2.53.0
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3 1/4] dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example
2026-09-17 11:13 [PATCH v3 0/4] rtc: rzn1: cleanups, R-Car X5H enablement Wolfram Sang
@ 2026-09-17 11:13 ` Wolfram Sang
2026-09-17 11:17 ` sashiko-bot
2026-09-17 11:13 ` [PATCH v3 2/4] dt-bindings: rtc: rzn1: add SoC names next to their IDs Wolfram Sang
` (2 subsequent siblings)
3 siblings, 1 reply; 15+ messages in thread
From: Wolfram Sang @ 2026-09-17 11:13 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Lad Prabhakar, Wolfram Sang, Lad Prabhakar, Conor Dooley,
Geert Uytterhoeven, Miquel Raynal, Alexandre Belloni, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, linux-rtc,
devicetree
We don't use 'start-year' in upstream DTs because the driver does the
right thing by default, ranging from 2000 to 2099. So, drop it from the
example, too.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Change since v2:
* added tag
Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
index ea7b039a91e7..e96007981c34 100644
--- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
@@ -91,5 +91,4 @@ examples:
clocks = <&sysctrl R9A06G032_HCLK_RTC>;
clock-names = "hclk";
power-domains = <&sysctrl>;
- start-year = <2000>;
};
--
2.53.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 2/4] dt-bindings: rtc: rzn1: add SoC names next to their IDs
2026-09-17 11:13 [PATCH v3 0/4] rtc: rzn1: cleanups, R-Car X5H enablement Wolfram Sang
2026-09-17 11:13 ` [PATCH v3 1/4] dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example Wolfram Sang
@ 2026-09-17 11:13 ` Wolfram Sang
2026-09-17 11:16 ` sashiko-bot
2026-09-17 11:13 ` [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support Wolfram Sang
2026-09-17 11:13 ` [PATCH v3 4/4] " Wolfram Sang
3 siblings, 1 reply; 15+ messages in thread
From: Wolfram Sang @ 2026-09-17 11:13 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Lad Prabhakar, Wolfram Sang, Lad Prabhakar, Conor Dooley,
Geert Uytterhoeven, Miquel Raynal, Alexandre Belloni, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Magnus Damm, linux-rtc,
devicetree
This helps maintaining because the numbers are easy to confuse.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Change since v2:
* added tag
.../devicetree/bindings/rtc/renesas,rzn1-rtc.yaml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
index e96007981c34..7ea77cd0bee1 100644
--- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
@@ -14,14 +14,14 @@ properties:
oneOf:
- items:
- enum:
- - renesas,r9a06g032-rtc
- - const: renesas,rzn1-rtc
+ - renesas,r9a06g032-rtc # RZ/N1D
+ - const: renesas,rzn1-rtc # RZ/N1
- - const: renesas,r9a09g077-rtc
+ - const: renesas,r9a09g077-rtc # RZ/T2H
- items:
- - const: renesas,r9a09g087-rtc
- - const: renesas,r9a09g077-rtc
+ - const: renesas,r9a09g087-rtc # RZ/N2H
+ - const: renesas,r9a09g077-rtc # RZ/T2H
reg:
maxItems: 1
--
2.53.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 [PATCH v3 0/4] rtc: rzn1: cleanups, R-Car X5H enablement Wolfram Sang
2026-09-17 11:13 ` [PATCH v3 1/4] dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example Wolfram Sang
2026-09-17 11:13 ` [PATCH v3 2/4] dt-bindings: rtc: rzn1: add SoC names next to their IDs Wolfram Sang
@ 2026-09-17 11:13 ` Wolfram Sang
2026-09-17 11:19 ` sashiko-bot
` (3 more replies)
2026-09-17 11:13 ` [PATCH v3 4/4] " Wolfram Sang
3 siblings, 4 replies; 15+ messages in thread
From: Wolfram Sang @ 2026-09-17 11:13 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Lad Prabhakar, Wolfram Sang, Miquel Raynal, Alexandre Belloni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Geert Uytterhoeven, Magnus Damm, linux-rtc, devicetree
The RTC on R-Car X5H is a bit special because interrupts are not wired.
Future R-Car Gen5 SoCs will have them wired again. So, create a
dedicated entry for X5H without interrupts.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Change since v2:
* handle only X5H for now and do not fall back to generic Gen5
.../bindings/rtc/renesas,rzn1-rtc.yaml | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
index 7ea77cd0bee1..b448725671ec 100644
--- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
@@ -23,6 +23,8 @@ properties:
- const: renesas,r9a09g087-rtc # RZ/N2H
- const: renesas,r9a09g077-rtc # RZ/T2H
+ - const: renesas,r8a78000-rtc # R-Car X5H
+
reg:
maxItems: 1
@@ -52,8 +54,6 @@ properties:
required:
- compatible
- reg
- - interrupts
- - interrupt-names
- clocks
- clock-names
- power-domains
@@ -66,6 +66,7 @@ allOf:
compatible:
contains:
enum:
+ - renesas,r8a78000-rtc
- renesas,r9a09g077-rtc
- renesas,r9a09g087-rtc
then:
@@ -75,6 +76,20 @@ allOf:
clock-names:
minItems: 2
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: renesas,r8a78000-rtc
+ then:
+ properties:
+ interrupts: false
+ interrupt-names: false
+ else:
+ required:
+ - interrupts
+ - interrupt-names
+
unevaluatedProperties: false
examples:
--
2.53.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v3 4/4] rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 [PATCH v3 0/4] rtc: rzn1: cleanups, R-Car X5H enablement Wolfram Sang
` (2 preceding siblings ...)
2026-09-17 11:13 ` [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support Wolfram Sang
@ 2026-09-17 11:13 ` Wolfram Sang
2026-09-17 11:25 ` sashiko-bot
2026-09-17 12:38 ` Geert Uytterhoeven
3 siblings, 2 replies; 15+ messages in thread
From: Wolfram Sang @ 2026-09-17 11:13 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Lad Prabhakar, Wolfram Sang, Lad Prabhakar, Miquel Raynal,
Alexandre Belloni, Geert Uytterhoeven, Magnus Damm, linux-rtc
The RTC on R-Car X5H is a bit special because interrupts are not wired.
Future R-Car Gen5 SoCs will have them wired again. So, create a
dedicated entry for X5H without interrupts.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Change since v2:
* drop Gen5-family compatible since X5H is not compatible with it
* added tag
drivers/rtc/rtc-rzn1.c | 53 ++++++++++++++++++++++++++++--------------
1 file changed, 35 insertions(+), 18 deletions(-)
diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
index b9d69ebdd224..855158da5f6c 100644
--- a/drivers/rtc/rtc-rzn1.c
+++ b/drivers/rtc/rtc-rzn1.c
@@ -68,6 +68,7 @@
struct rzn1_rtc_data {
bool has_subu;
+ bool broken_irqs;
};
struct rzn1_rtc {
@@ -396,6 +397,11 @@ static const struct rtc_class_ops rzn1_rtc_ops_scmp = {
.alarm_irq_enable = rzn1_rtc_alarm_irq_enable,
};
+static const struct rtc_class_ops rzn1_rtc_ops_scmp_no_alarm = {
+ .read_time = rzn1_rtc_read_time,
+ .set_time = rzn1_rtc_set_time,
+};
+
static void rzn1_rtc_disable_hardware(void *data)
{
struct device *dev = data;
@@ -431,10 +437,6 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
if (IS_ERR(rtc->base))
return dev_err_probe(dev, PTR_ERR(rtc->base), "Missing reg\n");
- irq = platform_get_irq_byname(pdev, "alarm");
- if (irq < 0)
- return irq;
-
rtc->rtcdev = devm_rtc_allocate_device(dev);
if (IS_ERR(rtc->rtcdev))
return PTR_ERR(rtc->rtcdev);
@@ -503,25 +505,39 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
spin_lock_init(&rtc->ctl1_access_lock);
- ret = devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm", rtc);
- if (ret)
- return dev_err_probe(dev, ret, "RTC alarm interrupt not available\n");
-
- irq = platform_get_irq_byname_optional(pdev, "pps");
- if (irq == -EPROBE_DEFER)
- return irq;
- if (irq >= 0)
- ret = devm_request_irq(dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC 1s", rtc);
-
- if (irq < 0 || ret) {
- set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features);
- clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features);
- dev_warn(dev, "RTC pps interrupt not available. Alarm has only minute accuracy\n");
+ if (data->broken_irqs) {
+ /* All known broken irqs are on SCMP only variants */
+ rtc->rtcdev->ops = &rzn1_rtc_ops_scmp_no_alarm;
+ } else {
+ irq = platform_get_irq_byname(pdev, "alarm");
+ if (irq < 0)
+ return irq;
+
+ ret = devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm", rtc);
+ if (ret)
+ return dev_err_probe(dev, ret, "RTC alarm interrupt not available\n");
+
+ irq = platform_get_irq_byname_optional(pdev, "pps");
+ if (irq == -EPROBE_DEFER)
+ return irq;
+ if (irq >= 0)
+ ret = devm_request_irq(dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC 1s", rtc);
+
+ if (irq < 0 || ret) {
+ set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features);
+ clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features);
+ dev_warn(dev, "RTC pps interrupt not available. Alarm has only minute accuracy\n");
+ }
}
return devm_rtc_register_device(rtc->rtcdev);
}
+static const struct rzn1_rtc_data rzn1_rtc_r8a78000_data = {
+ .has_subu = false,
+ .broken_irqs = true,
+};
+
static const struct rzn1_rtc_data rzn1_rtc_rzt2h_data = {
.has_subu = false,
};
@@ -531,6 +547,7 @@ static const struct rzn1_rtc_data rzn1_rtc_rzn1_data = {
};
static const struct of_device_id rzn1_rtc_of_match[] = {
+ { .compatible = "renesas,r8a78000-rtc", .data = &rzn1_rtc_r8a78000_data },
{ .compatible = "renesas,r9a09g077-rtc", .data = &rzn1_rtc_rzt2h_data },
{ .compatible = "renesas,rzn1-rtc", .data = &rzn1_rtc_rzn1_data },
{ /* sentinel */ }
--
2.53.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3 2/4] dt-bindings: rtc: rzn1: add SoC names next to their IDs
2026-09-17 11:13 ` [PATCH v3 2/4] dt-bindings: rtc: rzn1: add SoC names next to their IDs Wolfram Sang
@ 2026-09-17 11:16 ` sashiko-bot
0 siblings, 0 replies; 15+ messages in thread
From: sashiko-bot @ 2026-09-17 11:16 UTC (permalink / raw)
To: Wolfram Sang
Cc: conor+dt, devicetree, wsa+renesas, robh, linux-rtc,
Alexandre Belloni
> This helps maintaining because the numbers are easy to confuse.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917111349.52250-1-wsa+renesas@sang-engineering.com?part=2
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example
2026-09-17 11:13 ` [PATCH v3 1/4] dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example Wolfram Sang
@ 2026-09-17 11:17 ` sashiko-bot
0 siblings, 0 replies; 15+ messages in thread
From: sashiko-bot @ 2026-09-17 11:17 UTC (permalink / raw)
To: Wolfram Sang
Cc: conor+dt, wsa+renesas, Alexandre Belloni, devicetree, robh,
linux-rtc
> We don't use 'start-year' in upstream DTs because the driver does the
> right thing by default, ranging from 2000 to 2099. So, drop it from the
> example, too.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917111349.52250-1-wsa+renesas@sang-engineering.com?part=1
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 ` [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support Wolfram Sang
@ 2026-09-17 11:19 ` sashiko-bot
2026-09-17 12:35 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 15+ messages in thread
From: sashiko-bot @ 2026-09-17 11:19 UTC (permalink / raw)
To: Wolfram Sang
Cc: conor+dt, devicetree, wsa+renesas, Alexandre Belloni, linux-rtc,
robh
> The RTC on R-Car X5H is a bit special because interrupts are not wired.
> Future R-Car Gen5 SoCs will have them wired again. So, create a
> dedicated entry for X5H without interrupts.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917111349.52250-1-wsa+renesas@sang-engineering.com?part=3
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 4/4] rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 ` [PATCH v3 4/4] " Wolfram Sang
@ 2026-09-17 11:25 ` sashiko-bot
2026-09-17 12:38 ` Geert Uytterhoeven
1 sibling, 0 replies; 15+ messages in thread
From: sashiko-bot @ 2026-09-17 11:25 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-rtc, Alexandre Belloni, wsa+renesas
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] rtc: rzn1: falsely advertising RTC_FEATURE_UPDATE_INTERRUPT for broken_irqs
--
commit 526064073abaf5e11d2cc3b65e8bf7e6092cd549
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
rtc: rzn1: add R-Car X5H support
The RTC on R-Car X5H is a bit special because interrupts are not wired.
This creates a dedicated entry for X5H without interrupts.
> diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
> --- a/drivers/rtc/rtc-rzn1.c
> +++ b/drivers/rtc/rtc-rzn1.c
[ ... ]
> @@ -504,25 +506,39 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
>
> spin_lock_init(&rtc->ctl1_access_lock);
>
> - ret = devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm", rtc);
> - if (ret)
> - return dev_err_probe(dev, ret, "RTC alarm interrupt not available\n");
> -
> - irq = platform_get_irq_byname_optional(pdev, "pps");
> - if (irq == -EPROBE_DEFER)
> - return irq;
> - if (irq >= 0)
> - ret = devm_request_irq(dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC 1s", rtc);
> -
> - if (irq < 0 || ret) {
> - set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features);
> - clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features);
> - dev_warn(dev, "RTC pps interrupt not available. Alarm has only minute accuracy\n");
> + if (data->broken_irqs) {
> + /* All known broken irqs are on SCMP only variants */
> + rtc->rtcdev->ops = &rzn1_rtc_ops_scmp_no_alarm;
> + } else {
[Severity: Medium]
Does this branch need to clear the RTC_FEATURE_UPDATE_INTERRUPT bit from
rtc->rtcdev->features?
Since devm_rtc_allocate_device() allocates the RTC device and
unconditionally sets RTC_FEATURE_UPDATE_INTERRUPT, drivers that do not
support hardware update interrupts are expected to clear this bit.
The original code cleared this bit when PPS interrupts were missing, but
this new branch for broken_irqs skips that clearing logic.
Could this expose false hardware capabilities to userspace when queried
via RTC_PARAM_FEATURES?
> + irq = platform_get_irq_byname(pdev, "alarm");
> + if (irq < 0)
> + return irq;
> +
> + ret = devm_request_irq(dev, irq, rzn1_rtc_alarm_irq, 0, "RZN1 RTC Alarm", rtc);
> + if (ret)
> + return dev_err_probe(dev, ret, "RTC alarm interrupt not available\n");
> +
> + irq = platform_get_irq_byname_optional(pdev, "pps");
> + if (irq == -EPROBE_DEFER)
> + return irq;
> + if (irq >= 0)
> + ret = devm_request_irq(dev, irq, rzn1_rtc_1s_irq, 0, "RZN1 RTC 1s", rtc);
> +
> + if (irq < 0 || ret) {
> + set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features);
> + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features);
> + dev_warn(dev, "RTC pps interrupt not available. Alarm has only minute accuracy\n");
> + }
> }
>
> return devm_rtc_register_device(rtc->rtcdev);
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917111349.52250-1-wsa+renesas@sang-engineering.com?part=4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 ` [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support Wolfram Sang
2026-09-17 11:19 ` sashiko-bot
@ 2026-09-17 12:35 ` Geert Uytterhoeven
2026-09-24 22:17 ` Rob Herring (Arm)
2026-09-25 7:43 ` Geert Uytterhoeven
3 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2026-09-17 12:35 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Lad Prabhakar, Miquel Raynal,
Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Magnus Damm, linux-rtc, devicetree
On Thu, 17 Sept 2026 at 13:14, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> The RTC on R-Car X5H is a bit special because interrupts are not wired.
> Future R-Car Gen5 SoCs will have them wired again. So, create a
> dedicated entry for X5H without interrupts.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since v2:
> * handle only X5H for now and do not fall back to generic Gen5
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 4/4] rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 ` [PATCH v3 4/4] " Wolfram Sang
2026-09-17 11:25 ` sashiko-bot
@ 2026-09-17 12:38 ` Geert Uytterhoeven
1 sibling, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2026-09-17 12:38 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Lad Prabhakar, Lad Prabhakar, Miquel Raynal,
Alexandre Belloni, Magnus Damm, linux-rtc
On Thu, 17 Sept 2026 at 13:14, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> The RTC on R-Car X5H is a bit special because interrupts are not wired.
> Future R-Car Gen5 SoCs will have them wired again. So, create a
> dedicated entry for X5H without interrupts.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>
> Change since v2:
> * drop Gen5-family compatible since X5H is not compatible with it
> * added tag
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 ` [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support Wolfram Sang
2026-09-17 11:19 ` sashiko-bot
2026-09-17 12:35 ` Geert Uytterhoeven
@ 2026-09-24 22:17 ` Rob Herring (Arm)
2026-09-25 7:43 ` Geert Uytterhoeven
3 siblings, 0 replies; 15+ messages in thread
From: Rob Herring (Arm) @ 2026-09-24 22:17 UTC (permalink / raw)
To: Wolfram Sang
Cc: Lad Prabhakar, Magnus Damm, Conor Dooley, Krzysztof Kozlowski,
Alexandre Belloni, linux-rtc, devicetree, linux-renesas-soc,
Miquel Raynal, Geert Uytterhoeven
On Thu, 17 Sep 2026 13:13:47 +0200, Wolfram Sang wrote:
> The RTC on R-Car X5H is a bit special because interrupts are not wired.
> Future R-Car Gen5 SoCs will have them wired again. So, create a
> dedicated entry for X5H without interrupts.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since v2:
> * handle only X5H for now and do not fall back to generic Gen5
>
> .../bindings/rtc/renesas,rzn1-rtc.yaml | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support
2026-09-17 11:13 ` [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support Wolfram Sang
` (2 preceding siblings ...)
2026-09-24 22:17 ` Rob Herring (Arm)
@ 2026-09-25 7:43 ` Geert Uytterhoeven
2026-09-27 16:14 ` Wolfram Sang
3 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2026-09-25 7:43 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Lad Prabhakar, Miquel Raynal,
Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Geert Uytterhoeven, Magnus Damm, linux-rtc, devicetree
Hi Wolfram,
On Thu, 17 Sept 2026 at 13:14, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> The RTC on R-Car X5H is a bit special because interrupts are not wired.
> Future R-Car Gen5 SoCs will have them wired again. So, create a
> dedicated entry for X5H without interrupts.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> --- a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml
> @@ -23,6 +23,8 @@ properties:
> - const: renesas,r9a09g087-rtc # RZ/N2H
> - const: renesas,r9a09g077-rtc # RZ/T2H
>
> + - const: renesas,r8a78000-rtc # R-Car X5H
> +
> reg:
> maxItems: 1
>
> @@ -52,8 +54,6 @@ properties:
> required:
> - compatible
> - reg
> - - interrupts
> - - interrupt-names
> - clocks
> - clock-names
> - power-domains
> @@ -66,6 +66,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - renesas,r8a78000-rtc
> - renesas,r9a09g077-rtc
> - renesas,r9a09g087-rtc
> then:
> @@ -75,6 +76,20 @@ allOf:
> clock-names:
> minItems: 2
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r8a78000-rtc
> + then:
> + properties:
> + interrupts: false
> + interrupt-names: false
> + else:
> + required:
> + - interrupts
> + - interrupt-names
> +
Sorry for missing this before: the "resets" property is
completely missing.
> unevaluatedProperties: false
>
> examples:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support
2026-09-25 7:43 ` Geert Uytterhoeven
@ 2026-09-27 16:14 ` Wolfram Sang
2026-09-28 8:36 ` Geert Uytterhoeven
0 siblings, 1 reply; 15+ messages in thread
From: Wolfram Sang @ 2026-09-27 16:14 UTC (permalink / raw)
To: Geert Uytterhoeven, Lad Prabhakar
Cc: linux-renesas-soc, Miquel Raynal, Alexandre Belloni, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
Magnus Damm, linux-rtc, devicetree
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
> > + required:
> > + - interrupts
> > + - interrupt-names
> > +
>
> Sorry for missing this before: the "resets" property is
> completely missing.
Yes. Prabhakar, looking at the N2H and T2H DTSI files, I assume that
those also have resets for the RTC and only N1D has none?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support
2026-09-27 16:14 ` Wolfram Sang
@ 2026-09-28 8:36 ` Geert Uytterhoeven
0 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2026-09-28 8:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: Lad Prabhakar, linux-renesas-soc, Miquel Raynal,
Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Geert Uytterhoeven, Magnus Damm, linux-rtc, devicetree
Hi Wolfram,
On Sun, 27 Sept 2026 at 18:14, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > > + required:
> > > + - interrupts
> > > + - interrupt-names
> > > +
> >
> > Sorry for missing this before: the "resets" property is
> > completely missing.
>
> Yes. Prabhakar, looking at the N2H and T2H DTSI files, I assume that
> those also have resets for the RTC and only N1D has none?
RTC on RZ/T2H and RZ/N2H does not have a reset.
Please check the MRCTLx registers.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2026-09-28 8:37 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-17 11:13 [PATCH v3 0/4] rtc: rzn1: cleanups, R-Car X5H enablement Wolfram Sang
2026-09-17 11:13 ` [PATCH v3 1/4] dt-bindings: rtc: rzn1: drop unneeded 'start-year' from example Wolfram Sang
2026-09-17 11:17 ` sashiko-bot
2026-09-17 11:13 ` [PATCH v3 2/4] dt-bindings: rtc: rzn1: add SoC names next to their IDs Wolfram Sang
2026-09-17 11:16 ` sashiko-bot
2026-09-17 11:13 ` [PATCH v3 3/4] dt-bindings: rtc: rzn1: add R-Car X5H support Wolfram Sang
2026-09-17 11:19 ` sashiko-bot
2026-09-17 12:35 ` Geert Uytterhoeven
2026-09-24 22:17 ` Rob Herring (Arm)
2026-09-25 7:43 ` Geert Uytterhoeven
2026-09-27 16:14 ` Wolfram Sang
2026-09-28 8:36 ` Geert Uytterhoeven
2026-09-17 11:13 ` [PATCH v3 4/4] " Wolfram Sang
2026-09-17 11:25 ` sashiko-bot
2026-09-17 12:38 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox