From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Sangbeom Kim <sbkim73@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: [rtc-linux] Re: [PATCH] rtc: s5m: Add support for S2MPS13 RTC
Date: Thu, 26 Mar 2015 14:11:54 +0000 [thread overview]
Message-ID: <20150326141154.GN5951@x1> (raw)
In-Reply-To: <1427207619-26742-1-git-send-email-k.kozlowski@samsung.com>
On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote:
> The S2MPS13 RTC is almost the same as S2MPS14. The differences when
> updating alarm are:
> 1. Set WUDR+AUDR field instead of WUDR+RUDR.
> 2. Clear the AUDR field later (it is not auto-cleared).
>=20
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/rtc/rtc-s5m.c | 20 +++++++++++++++++++-
> include/linux/mfd/samsung/rtc.h | 2 ++
> 2 files changed, 21 insertions(+), 1 deletion(-)
[...]
> diff --git a/include/linux/mfd/samsung/rtc.h b/include/linux/mfd/samsung/=
rtc.h
> index b6401e7661c7..29c30ac36020 100644
> --- a/include/linux/mfd/samsung/rtc.h
> +++ b/include/linux/mfd/samsung/rtc.h
> @@ -105,6 +105,8 @@ enum s2mps_rtc_reg {
> #define S5M_RTC_UDR_MASK (1 << S5M_RTC_UDR_SHIFT)
> #define S2MPS_RTC_WUDR_SHIFT 4
> #define S2MPS_RTC_WUDR_MASK (1 << S2MPS_RTC_WUDR_SHIFT)
> +#define S2MPS13_RTC_AUDR_SHIFT 1
> +#define S2MPS13_RTC_AUDR_MASK (1 << S2MPS13_RTC_AUDR_SHIFT)
> #define S2MPS_RTC_RUDR_SHIFT 0
> #define S2MPS_RTC_RUDR_MASK (1 << S2MPS_RTC_RUDR_SHIFT)
> #define RTC_TCON_SHIFT 1
Please consider writing these like:
#define S2MPS_RTC_WUDR_MASK bit(4)
#define S2MPS13_RTC_AUDR_MASK bit(1)
#define S2MPS_RTC_RUDR_MASK bit(0)
But for the MFD part of this patch:
Acked-by: Lee Jones <lee.jones@linaro.org>
--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
parent reply other threads:[~2015-03-26 14:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1427207619-26742-1-git-send-email-k.kozlowski@samsung.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326141154.GN5951@x1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox