* [rtc-linux] Re: [PATCH] rtc: s5m: Add support for S2MPS13 RTC
[not found] <1427207619-26742-1-git-send-email-k.kozlowski@samsung.com>
@ 2015-03-26 14:11 ` Lee Jones
0 siblings, 0 replies; only message in thread
From: Lee Jones @ 2015-03-26 14:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alessandro Zummo, Sangbeom Kim, Samuel Ortiz, rtc-linux,
linux-kernel, Chanwoo Choi
On Tue, 24 Mar 2015, Krzysztof Kozlowski wrote:
> The S2MPS13 RTC is almost the same as S2MPS14. The differences when
> updating alarm are:
> 1. Set WUDR+AUDR field instead of WUDR+RUDR.
> 2. Clear the AUDR field later (it is not auto-cleared).
>=20
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/rtc/rtc-s5m.c | 20 +++++++++++++++++++-
> include/linux/mfd/samsung/rtc.h | 2 ++
> 2 files changed, 21 insertions(+), 1 deletion(-)
[...]
> diff --git a/include/linux/mfd/samsung/rtc.h b/include/linux/mfd/samsung/=
rtc.h
> index b6401e7661c7..29c30ac36020 100644
> --- a/include/linux/mfd/samsung/rtc.h
> +++ b/include/linux/mfd/samsung/rtc.h
> @@ -105,6 +105,8 @@ enum s2mps_rtc_reg {
> #define S5M_RTC_UDR_MASK (1 << S5M_RTC_UDR_SHIFT)
> #define S2MPS_RTC_WUDR_SHIFT 4
> #define S2MPS_RTC_WUDR_MASK (1 << S2MPS_RTC_WUDR_SHIFT)
> +#define S2MPS13_RTC_AUDR_SHIFT 1
> +#define S2MPS13_RTC_AUDR_MASK (1 << S2MPS13_RTC_AUDR_SHIFT)
> #define S2MPS_RTC_RUDR_SHIFT 0
> #define S2MPS_RTC_RUDR_MASK (1 << S2MPS_RTC_RUDR_SHIFT)
> #define RTC_TCON_SHIFT 1
Please consider writing these like:
#define S2MPS_RTC_WUDR_MASK bit(4)
#define S2MPS13_RTC_AUDR_MASK bit(1)
#define S2MPS_RTC_RUDR_MASK bit(0)
But for the MFD part of this patch:
Acked-by: Lee Jones <lee.jones@linaro.org>
--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] only message in thread