* [rtc-linux] [PATCH 1/2] rtc-isl1208: Add device tree binding @ 2015-05-26 19:12 Jean-Baptiste Theou 2015-05-26 19:12 ` [rtc-linux] [PATCH 2/2] rtc-isl1208: add device tree support Jean-Baptiste Theou 0 siblings, 1 reply; 4+ messages in thread From: Jean-Baptiste Theou @ 2015-05-26 19:12 UTC (permalink / raw) To: Alessandro Zummo Cc: Alexandre Belloni, rtc-linux, linux-kernel, Jean-Baptiste Theou ISL 1208/1218 require a trival i2c binding Signed-off-by: Jean-Baptiste Theou <jtheou@adeneo-embedded.us> --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt index ad0c4ac..a6f6257 100644 --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt @@ -61,6 +61,8 @@ fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz) +isil,isl1208 Intersil ISL1208 RTC driver +isil,isl1218 Intersil ISL1218 RTC driver isil,isl12057 Intersil ISL12057 I2C RTC Chip isil,isl29028 Intersil ISL29028 Ambient Light and Proximity Sensor maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator -- 2.4.0 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [rtc-linux] [PATCH 2/2] rtc-isl1208: add device tree support 2015-05-26 19:12 [rtc-linux] [PATCH 1/2] rtc-isl1208: Add device tree binding Jean-Baptiste Theou @ 2015-05-26 19:12 ` Jean-Baptiste Theou 2015-05-26 20:20 ` [rtc-linux] " Alexandre Belloni 0 siblings, 1 reply; 4+ messages in thread From: Jean-Baptiste Theou @ 2015-05-26 19:12 UTC (permalink / raw) To: Alessandro Zummo Cc: Alexandre Belloni, rtc-linux, linux-kernel, Jean-Baptiste Theou Add a basic device tree support for isl1208 driver Signed-off-by: Jean-Baptiste Theou <jtheou@adeneo-embedded.us> --- drivers/rtc/rtc-isl1208.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index c3c549d..b47a3f9 100644 --- a/drivers/rtc/rtc-isl1208.c +++ b/drivers/rtc/rtc-isl1208.c @@ -692,6 +692,14 @@ isl1208_remove(struct i2c_client *client) return 0; } +#ifdef CONFIG_OF +static const struct of_device_id isl1208_dt_match[] = { + { .compatible = "isil,isl1208" }, + { .compatible = "isil,isl1218" }, + { }, +}; +#endif + static const struct i2c_device_id isl1208_id[] = { { "isl1208", 0 }, { "isl1218", 0 }, @@ -702,6 +710,7 @@ MODULE_DEVICE_TABLE(i2c, isl1208_id); static struct i2c_driver isl1208_driver = { .driver = { .name = "rtc-isl1208", + .of_match_table = of_match_ptr(isl1208_dt_match), }, .probe = isl1208_probe, .remove = isl1208_remove, -- 2.4.0 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [rtc-linux] Re: [PATCH 2/2] rtc-isl1208: add device tree support 2015-05-26 19:12 ` [rtc-linux] [PATCH 2/2] rtc-isl1208: add device tree support Jean-Baptiste Theou @ 2015-05-26 20:20 ` Alexandre Belloni 2015-05-26 20:49 ` Jean-Baptiste Theou 0 siblings, 1 reply; 4+ messages in thread From: Alexandre Belloni @ 2015-05-26 20:20 UTC (permalink / raw) To: Jean-Baptiste Theou; +Cc: Alessandro Zummo, rtc-linux, linux-kernel Hi, On 26/05/2015 at 12:12:30 -0700, Jean-Baptiste Theou wrote : > Add a basic device tree support for isl1208 driver > > Signed-off-by: Jean-Baptiste Theou <jtheou@adeneo-embedded.us> > --- > drivers/rtc/rtc-isl1208.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c > index c3c549d..b47a3f9 100644 > --- a/drivers/rtc/rtc-isl1208.c > +++ b/drivers/rtc/rtc-isl1208.c > @@ -692,6 +692,14 @@ isl1208_remove(struct i2c_client *client) > return 0; > } > > +#ifdef CONFIG_OF > +static const struct of_device_id isl1208_dt_match[] = { > + { .compatible = "isil,isl1208" }, > + { .compatible = "isil,isl1218" }, > + { }, > +}; > +#endif > + > static const struct i2c_device_id isl1208_id[] = { > { "isl1208", 0 }, > { "isl1218", 0 }, > @@ -702,6 +710,7 @@ MODULE_DEVICE_TABLE(i2c, isl1208_id); > static struct i2c_driver isl1208_driver = { > .driver = { > .name = "rtc-isl1208", > + .of_match_table = of_match_ptr(isl1208_dt_match), This patch is unnecessary as the i2c subsystem will already match isil,isl1208 or isil,isl1218 with the i2c_device_id array. > }, > .probe = isl1208_probe, > .remove = isl1208_remove, > -- > 2.4.0 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [rtc-linux] Re: [PATCH 2/2] rtc-isl1208: add device tree support 2015-05-26 20:20 ` [rtc-linux] " Alexandre Belloni @ 2015-05-26 20:49 ` Jean-Baptiste Theou 0 siblings, 0 replies; 4+ messages in thread From: Jean-Baptiste Theou @ 2015-05-26 20:49 UTC (permalink / raw) To: Alexandre Belloni; +Cc: Alessandro Zummo, rtc-linux, linux-kernel Hi, Indeed. Sorry for the noise. Best regards On Tue, 26 May 2015 22:20:32 +0200 Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > Hi, > > On 26/05/2015 at 12:12:30 -0700, Jean-Baptiste Theou wrote : > > Add a basic device tree support for isl1208 driver > > > > Signed-off-by: Jean-Baptiste Theou <jtheou@adeneo-embedded.us> > > --- > > drivers/rtc/rtc-isl1208.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c > > index c3c549d..b47a3f9 100644 > > --- a/drivers/rtc/rtc-isl1208.c > > +++ b/drivers/rtc/rtc-isl1208.c > > @@ -692,6 +692,14 @@ isl1208_remove(struct i2c_client *client) > > return 0; > > } > > > > +#ifdef CONFIG_OF > > +static const struct of_device_id isl1208_dt_match[] = { > > + { .compatible = "isil,isl1208" }, > > + { .compatible = "isil,isl1218" }, > > + { }, > > +}; > > +#endif > > + > > static const struct i2c_device_id isl1208_id[] = { > > { "isl1208", 0 }, > > { "isl1218", 0 }, > > @@ -702,6 +710,7 @@ MODULE_DEVICE_TABLE(i2c, isl1208_id); > > static struct i2c_driver isl1208_driver = { > > .driver = { > > .name = "rtc-isl1208", > > + .of_match_table = of_match_ptr(isl1208_dt_match), > > This patch is unnecessary as the i2c subsystem will already match > isil,isl1208 or isil,isl1218 with the i2c_device_id array. > > > }, > > .probe = isl1208_probe, > > .remove = isl1208_remove, > > -- > > 2.4.0 > > > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- Jean-Baptiste Theou <jtheou@adeneo-embedded.us> -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-26 20:49 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-05-26 19:12 [rtc-linux] [PATCH 1/2] rtc-isl1208: Add device tree binding Jean-Baptiste Theou 2015-05-26 19:12 ` [rtc-linux] [PATCH 2/2] rtc-isl1208: add device tree support Jean-Baptiste Theou 2015-05-26 20:20 ` [rtc-linux] " Alexandre Belloni 2015-05-26 20:49 ` Jean-Baptiste Theou
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox