Linux RTC
 help / color / mirror / Atom feed
* [rtc-linux] [PATCH v2] rtc: ab8500: Add a sentinel to ab85xx_rtc_ids[]
@ 2015-09-04 11:58 Fabio Estevam
  2015-09-05 11:24 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2015-09-04 11:58 UTC (permalink / raw)
  To: alexandre.belloni; +Cc: k.kozlowski, ryabinin.a.a, rtc-linux, Fabio Estevam

From: Fabio Estevam <fabio.estevam@freescale.com>

Add a sentinel to ab85xx_rtc_ids[] in order to fix the following error:

drivers/rtc/rtc-ab8500: struct platform_device_id is 24 bytes.  The last of 2 is:
0x61 0x62 0x38 0x35 0x34 0x30 0x2d 0x72 0x74 0x63 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x8c 
FATAL: drivers/rtc/rtc-ab8500: struct platform_device_id is not terminated with a NULL entry!

Reported-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
Changes since v1:
- Add also a Reported-by tag from Andrey Ryabinin and also Reviewed-by from
Krzysztof Kozlowski.

 drivers/rtc/rtc-ab8500.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 8537d1e..51407c4 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -445,6 +445,7 @@ static const struct rtc_class_ops ab8540_rtc_ops = {
 static const struct platform_device_id ab85xx_rtc_ids[] = {
 	{ "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
 	{ "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
+	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
 
-- 
1.9.1

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [rtc-linux] [PATCH v2] rtc: ab8500: Add a sentinel to ab85xx_rtc_ids[]
  2015-09-04 11:58 [rtc-linux] [PATCH v2] rtc: ab8500: Add a sentinel to ab85xx_rtc_ids[] Fabio Estevam
@ 2015-09-05 11:24 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2015-09-05 11:24 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: k.kozlowski, ryabinin.a.a, rtc-linux, Fabio Estevam

On 04/09/2015 at 08:58:05 -0300, Fabio Estevam wrote :
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Add a sentinel to ab85xx_rtc_ids[] in order to fix the following error:
> 
> drivers/rtc/rtc-ab8500: struct platform_device_id is 24 bytes.  The last of 2 is:
> 0x61 0x62 0x38 0x35 0x34 0x30 0x2d 0x72 0x74 0x63 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x8c 
> FATAL: drivers/rtc/rtc-ab8500: struct platform_device_id is not terminated with a NULL entry!
> 
> Reported-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> Changes since v1:
> - Add also a Reported-by tag from Andrey Ryabinin and also Reviewed-by from
> Krzysztof Kozlowski.
> 
>  drivers/rtc/rtc-ab8500.c | 1 +
>  1 file changed, 1 insertion(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-05 11:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-04 11:58 [rtc-linux] [PATCH v2] rtc: ab8500: Add a sentinel to ab85xx_rtc_ids[] Fabio Estevam
2015-09-05 11:24 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox