[rtc-linux] [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

[rtc-linux] [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

[Wenyou Yang]

This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

 drivers/rtc/rtc-at91rm9200.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
 	/* this IRQ is shared with DBGU and other hardware which isn't
 	 * necessarily doing PM like we are...
 	 */
+	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
 	at91_rtc_imr = at91_rtc_read_imr()
 			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
 	if (at91_rtc_imr) {
-- 
1.7.9.5

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

[Alexandre Belloni]

Hi Wenyou,

On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity.
> 

Is this a new issue appearing with the sama5d2 or was it present from
the beginning?

> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
>  drivers/rtc/rtc-at91rm9200.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index cb62e21..b60fd47 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
>  	/* this IRQ is shared with DBGU and other hardware which isn't
>  	 * necessarily doing PM like we are...
>  	 */
> +	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> +
>  	at91_rtc_imr = at91_rtc_read_imr()
>  			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
>  	if (at91_rtc_imr) {
> -- 
> 1.7.9.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] RE: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

[Yang, Wenyou]

Hi Alexandre,

> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> Sent: 2015=E5=B9=B410=E6=9C=8812=E6=97=A5 14:53
> To: Yang, Wenyou
> Cc: Alessandro Zummo; Ferre, Nicolas; Desroches, Ludovic; rtc-
> linux@googlegroups.com; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior t=
o
> suspending
>=20
> Hi Wenyou,
>=20
> On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> > This patch is to clear the RTC alarm status flag prior to suspending
> > to avoid the erroneous wake-up activity.
> >
>=20
> Is this a new issue appearing with the sama5d2 or was it present from the
> beginning?
With the sama5d2 ULP1 mode, not from the beginning.

>=20
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> >  drivers/rtc/rtc-at91rm9200.c |    2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/rtc/rtc-at91rm9200.c
> > b/drivers/rtc/rtc-at91rm9200.c index cb62e21..b60fd47 100644
> > --- a/drivers/rtc/rtc-at91rm9200.c
> > +++ b/drivers/rtc/rtc-at91rm9200.c
> > @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
> >  	/* this IRQ is shared with DBGU and other hardware which isn't
> >  	 * necessarily doing PM like we are...
> >  	 */
> > +	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> > +
> >  	at91_rtc_imr =3D at91_rtc_read_imr()
> >  			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
> >  	if (at91_rtc_imr) {
> > --
> > 1.7.9.5
> >
>=20
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

Best Regards,
Wenyou Yang

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

[Alexandre Belloni]

On 12/10/2015 at 07:48:18 +0000, Yang, Wenyou wrote :
> > On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> > > This patch is to clear the RTC alarm status flag prior to suspending
> > > to avoid the erroneous wake-up activity.
> > >
> > 
> > Is this a new issue appearing with the sama5d2 or was it present from the
> > beginning?
> With the sama5d2 ULP1 mode, not from the beginning.
> 

I think this information should appear in the commit log.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[rtc-linux] RE: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

[Yang, Wenyou]

> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> Sent: 2015=E5=B9=B410=E6=9C=8812=E6=97=A5 15:51
> To: Yang, Wenyou
> Cc: Alessandro Zummo; Ferre, Nicolas; Desroches, Ludovic; rtc-
> linux@googlegroups.com; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior t=
o
> suspending
>=20
> On 12/10/2015 at 07:48:18 +0000, Yang, Wenyou wrote :
> > > On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> > > > This patch is to clear the RTC alarm status flag prior to
> > > > suspending to avoid the erroneous wake-up activity.
> > > >
> > >
> > > Is this a new issue appearing with the sama5d2 or was it present
> > > from the beginning?
> > With the sama5d2 ULP1 mode, not from the beginning.
> >
>=20
> I think this information should appear in the commit log.
I will add it in the next version, thanks.

>=20
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering http://free-electrons.com

Best Regards,
Wenyou Yang

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.