From: Rob Herring <robh@kernel.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, rtc-linux@googlegroups.com,
kernel@pengutronix.de
Subject: [rtc-linux] Re: [PATCH 1/2] Documentation: devicetree: add epson rx6110 binding
Date: Tue, 24 Nov 2015 17:54:00 -0600 [thread overview]
Message-ID: <20151124235337.GA18195@rob-hp-laptop> (raw)
In-Reply-To: <1448361533-10728-1-git-send-email-s.trumtrar@pengutronix.de>
On Tue, Nov 24, 2015 at 11:38:52AM +0100, Steffen Trumtrar wrote:
> Add the binding documentation for the Epson RX6110 RTC.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> I'm not sure what the current policy for such simple SPI bindings is.
> Are they necessary?
Yes. We do have trivial-devices.txt for i2c. We could do one for spi.
Although, you need the mode configuration for each device, so spi is not
so trivial.
>
> .../devicetree/bindings/rtc/epson,rtc-rx6110.txt | 25 ++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt
> new file mode 100644
> index 000000000000..7ce7ae761657
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt
> @@ -0,0 +1,25 @@
> +Epson RX6110 Real Time Clock
> +============================
> +
> +The Epson RX6110 can be used with SPI or I2C busses. The kind of
> +bus depends on the SPISEL pin and can not be configured via software.
Can you document I2C mode. It should just be the compatible and reg
properties.
> +
> +SPI mode
> +--------
> +
> +Required properties:
> +- compatible: should be: "epson,rtc-rx6110"
> +- reg: chip select number
> +- spi-cs-high: RX6110 needs chipselect high
> +- spi-cpha: RX6110 works with SPI shifted clock phase
> +- spi-cpol: RX6110 works with SPI inverse clock polarity
> +
> +Example:
> +
> + rtc: rtc@3 {
> + compatible = "epson,rtc-rx6110"
> + reg = <3>
> + spi-cs-high;
> + spi-cpba;
> + spi-cpol;
> + };
> --
> 2.6.2
>
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-11-24 23:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 10:38 [rtc-linux] [PATCH 1/2] Documentation: devicetree: add epson rx6110 binding Steffen Trumtrar
2015-11-24 10:38 ` [rtc-linux] [PATCH 2/2] rtc: add driver for RX6110SA real time clock Steffen Trumtrar
2015-11-24 11:12 ` [rtc-linux] Re: [PATCH 1/2] Documentation: devicetree: add epson rx6110 binding Philipp Zabel
2015-11-24 23:55 ` Rob Herring
2015-11-25 9:02 ` Steffen Trumtrar
2015-11-25 9:02 ` Steffen Trumtrar
2015-11-24 23:54 ` Rob Herring [this message]
2015-11-25 9:00 ` Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124235337.GA18195@rob-hp-laptop \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rtc-linux@googlegroups.com \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox