From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Piotr Stankiewicz <piotrs@opensource.wolfsonmicro.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
patches@opensource.wolfsonmicro.com
Subject: [rtc-linux] Re: [PATCH] rtc: rx8581: adding Device Tree support
Date: Thu, 26 Nov 2015 11:16:34 +0100 [thread overview]
Message-ID: <20151126101634.GR3950@piout.net> (raw)
In-Reply-To: <1448531917-14994-1-git-send-email-piotrs@opensource.wolfsonmicro.com>
Hi,
On 26/11/2015 at 09:58:37 +0000, Piotr Stankiewicz wrote :
> Signed-off-by: Piotr Stankiewicz <piotrs@opensource.wolfsonmicro.com>
> ---
> drivers/rtc/rtc-rx8581.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c
> index 161e25d0..a4c86c5 100644
> --- a/drivers/rtc/rtc-rx8581.c
> +++ b/drivers/rtc/rtc-rx8581.c
> @@ -312,9 +312,18 @@ static const struct i2c_device_id rx8581_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, rx8581_id);
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id rx8581_of_match[] = {
> + { .compatible = "epson,rx8581"},
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, rx8581_of_match);
> +#endif
> +
Is that necessary? epson,rx8581 is already matching the only
i2c_device_id of this driver.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-11-26 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 9:58 [rtc-linux] [PATCH] rtc: rx8581: adding Device Tree support Piotr Stankiewicz
2015-11-26 10:16 ` Alexandre Belloni [this message]
2015-11-26 11:28 ` [rtc-linux] " Piotr Stankiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126101634.GR3950@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=patches@opensource.wolfsonmicro.com \
--cc=piotrs@opensource.wolfsonmicro.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox