[rtc-linux] Re: [PATCH] rtc: rx8581: adding Device Tree support

[Piotr Stankiewicz <piotrs@opensource.wolfsonmicro.com>]

On Thu, Nov 26, 2015 at 11:16:34AM +0100, Alexandre Belloni wrote:
Hi,
> Hi,
> 
> On 26/11/2015 at 09:58:37 +0000, Piotr Stankiewicz wrote :
> > Signed-off-by: Piotr Stankiewicz <piotrs@opensource.wolfsonmicro.com>
> > ---
> >  drivers/rtc/rtc-rx8581.c |    9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c
> > index 161e25d0..a4c86c5 100644
> > --- a/drivers/rtc/rtc-rx8581.c
> > +++ b/drivers/rtc/rtc-rx8581.c
> > @@ -312,9 +312,18 @@ static const struct i2c_device_id rx8581_id[] = {
> >  };
> >  MODULE_DEVICE_TABLE(i2c, rx8581_id);
> >  
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id rx8581_of_match[] = {
> > +	{ .compatible = "epson,rx8581"},
> > +	{}
> > +};
> > +MODULE_DEVICE_TABLE(of, rx8581_of_match);
> > +#endif
> > +
> 
> Is that necessary? epson,rx8581 is already matching the only
> i2c_device_id of this driver.

It seems it is not necessary indeed, I just did a full clean build
without my patch and my clock works correctly. I guess my original issue
must have been caused by a dodgy defconfig/device tree.

Sorry for the confusion.

Greetings,
Piotr

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.