[rtc-linux] Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

On Mon, Feb 08, 2016 at 10:26:20PM +0530, Laxman Dewangan wrote:
> Adding Thomas in the discussion.

> >This does not explain why anyone would ever want to use this interface
> >(which was my question), why would anyone ever want to do this as a
> >separate step?

> OK, so you want to say that irq_domain_remove() should take care of doing
> unmap also?

My main focus is on the regmap-irq interface you are trying to add - why
would a user of this interface want to do this as a separate step (which
would require changing all the existing users...)?  We're providing an
interface to get the virq mapped to a particular interrupt in the
device, it's not obvious that that is an allocation and it certainly
wasn't the intention (this code predates us using domains).

> So fix need to go in the irq_domain_remove() to unamp before actually
> destroying the irq domain?

That's one option, but you could also do this at the regmap-irq level.

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]