From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Michael Büsch" <m@bues.ch>
Cc: Gregory Hermant <gregory.hermant@calao-systems.com>,
rtc-linux@googlegroups.com
Subject: Re: [rtc-linux] rv3029 EEPROM handling
Date: Sun, 28 Feb 2016 11:41:10 +0100 [thread overview]
Message-ID: <20160228104110.GC2398@piout.net> (raw)
In-Reply-To: <20160228094452.132c1938@wiggum>
On 28/02/2016 at 09:44:52 +0100, Michael B=C3=BCsch wrote :
> On Sun, 28 Feb 2016 01:31:39 +0100
> Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
>=20
> > trickle charging is usually enabled using device tree, however, I'd
> > really like to see more standardization on the property names.
>=20
> Is there an example of an rtc driver implementing this?
> For the rv3029 it's more than just enabling it. It also has a bunch of
> charging resistors to choose from.
>=20
ds1339, ds1390 and bq32k are using trickle-resistor-ohms and
trickle-diode-disable.
> > I'm not sure yet about the temperature compensation. I've just merged
> > the crystal offset modification api with a sysfs interface in rtc-next:
> > http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?=
h=3Drtc-next&id=3D5f23807caab7801c3333c68417bb13c7e2439193
> >=20
> > But this doesn't seem enough for that particular RTC.
>=20
> The rv3029 does the compensation internally. It just needs to be
> enabled via a bit in its EEPROM. We could probably always set that bit
> though. I'm not sure whether there is a case where one would not want
> that.
>=20
If you want to enable it without changing the values, just enable it
unconditionally.
--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-02-28 10:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-27 14:39 [rtc-linux] rv3029 EEPROM handling Michael Büsch
2016-02-28 0:31 ` Alexandre Belloni
2016-02-28 8:44 ` Michael Büsch
2016-02-28 10:41 ` Alexandre Belloni [this message]
2016-02-28 11:58 ` Michael Büsch
2016-02-28 12:36 ` Alexandre Belloni
2016-02-28 17:14 ` Michael Büsch
2016-02-28 21:39 ` Alexandre Belloni
2016-02-29 17:07 ` Michael Büsch
2016-02-29 19:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228104110.GC2398@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=gregory.hermant@calao-systems.com \
--cc=m@bues.ch \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox