Linux RTC
 help / color / mirror / Atom feed
From: "Michael Büsch" <m@bues.ch>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Gregory Hermant <gregory.hermant@calao-systems.com>,
	rtc-linux@googlegroups.com
Subject: Re: [rtc-linux] rv3029 EEPROM handling
Date: Sun, 28 Feb 2016 12:58:52 +0100	[thread overview]
Message-ID: <20160228125852.1a0b271e@wiggum> (raw)
In-Reply-To: <20160228104110.GC2398@piout.net>

[-- Attachment #1: Type: text/plain, Size: 1542 bytes --]

On Sun, 28 Feb 2016 11:41:10 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> ds1339, ds1390 and bq32k are using trickle-resistor-ohms and
> trickle-diode-disable.


The rv3029 datasheet doesn't say anything about a diode (I think it
still has one though). It merely talks about resistors connected
between vdd and the battery pin.
So I'm not sure whether we should use the 'trickle-diode-disable'
property here. One other possibility would be to use
trickle-resistor-ohms=-1 or such to disable the charger.


> > The rv3029 does the compensation internally. It just needs to be
> > enabled via a bit in its EEPROM. We could probably always set that bit
> > though. I'm not sure whether there is a case where one would not want
> > that.
> >   
> 
> If you want to enable it without changing the values, just enable it
> unconditionally.


I think the internal temperature compensation should be enabled by
default and be disabled via DT property ('temp-compensation-disable'
or such).

-- 
Michael

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-02-28 11:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27 14:39 [rtc-linux] rv3029 EEPROM handling Michael Büsch
2016-02-28  0:31 ` Alexandre Belloni
2016-02-28  8:44   ` Michael Büsch
2016-02-28 10:41     ` Alexandre Belloni
2016-02-28 11:58       ` Michael Büsch [this message]
2016-02-28 12:36         ` Alexandre Belloni
2016-02-28 17:14           ` Michael Büsch
2016-02-28 21:39             ` Alexandre Belloni
2016-02-29 17:07               ` Michael Büsch
2016-02-29 19:52                 ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160228125852.1a0b271e@wiggum \
    --to=m@bues.ch \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=gregory.hermant@calao-systems.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox