[PATCH 0/4] Add DT bindings and device tree for Compulab SB-UCM-iMX8MPLUS

[PATCH 0/4] Add DT bindings and device tree for Compulab SB-UCM-iMX8MPLUS

[Laurent Pinchart]

Hello,

This small patch series is a drive-by addition of the Compulab
SB-UCM-iMX8MPLUS to the Linux kernel device tree sources. While porting
the device tree from the Compulab BSP kernel to mainline, I thought I
could as well mainline it, along with related conversion of text DT
bindings to YAML.

The SB-UCM-iMX8MPLUS is a carrier board designed as a reference to
evaluate the Compulab UCM-iMX8MPLUS SoM. The SoM integrates the bare
minimal peripherals (DRAM, eMMC, ethernet PHY, EEPROM and RTC), while
the carrier board includes a much wider range of peripherals. I have
only enabled support for the ones I am interested in, or, as a strech
goal, the ones I could easily test.

The first patch in the series adds compatible strings for the SoM and
the board to the ARM FSL bindings. The next patch then converts text DT
bindings to a YAML schema for the RTC present on the SoM. Finally, the
last two patches add DT sources for the SoM and the carrier board.

Please see individual patches for details.

I have checked the validity of the bindings and the device tree sources.
The only warnings in the DT sources are due to issues in imx8mp.dtsi.

Laurent Pinchart (4):
  dt-bindings: arm: fsl: Add Compulab SB-UCM-iMX8MPLUS carrier board
  dt-bindings: rtc: abx80x: Convert text bindings to YAML
  arm64: dts: freescale: Add device tree for Compulab UCM-iMX8M-Plus
  arm64: dts: freescale: Add device tree for Compulab SB-UCM-iMX8MPLUS

 .../devicetree/bindings/arm/fsl.yaml          |   6 +
 .../bindings/rtc/abracon,abx80x.txt           |  31 --
 .../bindings/rtc/abracon,abx80x.yaml          |  89 +++++
 arch/arm64/boot/dts/freescale/Makefile        |   1 +
 .../boot/dts/freescale/imx8mp-sb-ucm.dts      | 284 ++++++++++++++++
 arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi | 309 ++++++++++++++++++
 6 files changed, 689 insertions(+), 31 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi

-- 
Regards,

Laurent Pinchart

[PATCH 2/4] dt-bindings: rtc: abx80x: Convert text bindings to YAML

[Laurent Pinchart]

Convert the abx80x DT bindings to YAML schema. The existing properties
are kept without modification, and the interrupt property is added as it
is supported by the driver.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
If someone wants to volunteer as a maintainer, by all means, please fee
to replace me :-)
---
 .../bindings/rtc/abracon,abx80x.txt           | 31 -------
 .../bindings/rtc/abracon,abx80x.yaml          | 89 +++++++++++++++++++
 2 files changed, 89 insertions(+), 31 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml

diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt b/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
deleted file mode 100644
index 2405e35a1bc0..000000000000
--- a/Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
+++ /dev/null
@@ -1,31 +0,0 @@
-Abracon ABX80X I2C ultra low power RTC/Alarm chip
-
-The Abracon ABX80X family consist of the ab0801, ab0803, ab0804, ab0805, ab1801,
-ab1803, ab1804 and ab1805. The ab0805 is the superset of ab080x and the ab1805
-is the superset of ab180x.
-
-Required properties:
-
- - "compatible": should one of:
-        "abracon,abx80x"
-        "abracon,ab0801"
-        "abracon,ab0803"
-        "abracon,ab0804"
-        "abracon,ab0805"
-        "abracon,ab1801"
-        "abracon,ab1803"
-        "abracon,ab1804"
-        "abracon,ab1805"
-        "microcrystal,rv1805"
-	Using "abracon,abx80x" will enable chip autodetection.
- - "reg": I2C bus address of the device
-
-Optional properties:
-
-The abx804 and abx805 have a trickle charger that is able to charge the
-connected battery or supercap. Both the following properties have to be defined
-and valid to enable charging:
-
- - "abracon,tc-diode": should be "standard" (0.6V) or "schottky" (0.3V)
- - "abracon,tc-resistor": should be <0>, <3>, <6> or <11>. 0 disables the output
-                          resistor, the other values are in kOhm.
diff --git a/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
new file mode 100644
index 000000000000..02bee3038b0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/abracon,abx80x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Abracon ABX80X I2C ultra low power RTC/alarm chip
+
+maintainers:
+  - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description:
+  The Abracon ABX80X family consists of the ab0801, ab0803, ab0804, ab0805,
+  ab1801, ab1803, ab1804 and ab1805. The ab0805 is the superset of ab080x and
+  the ab1805 is the superset of ab180x.
+
+properties:
+  compatible:
+    enum:
+      - abracon,abx80x    # Enables chip auto-detection
+      - abracon,ab0801
+      - abracon,ab0803
+      - abracon,ab0804
+      - abracon,ab0805
+      - abracon,ab1801
+      - abracon,ab1803
+      - abracon,ab1804
+      - abracon,ab1805
+      - microcrystal,rv1805
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  abracon,tc-diode:
+    description:
+      Select the series diode configuration for the trickle charger, between a
+      standard diode (0.6V) and a Schottky diode (0.3V).
+    enum: [standard, schottky]
+
+  abracon,tc-resistor:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Select the series output resistor value for the tricker charger, in kOhm.
+    enum: [0, 3, 6, 11]
+
+dependentRequired:
+  abracon,tc-diode: ["abracon,tc-resistor"]
+  abracon,tc-resistor: ["abracon,tc-diode"]
+
+required:
+  - compatible
+  - reg
+
+allOf:
+  - $ref: rtc.yaml#
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              enum:
+                - abracon,ab0804
+                - abracon,ab1804
+                - abracon,ab0805
+                - abracon,ab1805
+    then:
+      properties:
+        abracon,tc-diode: false
+        abracon,tc-resistor: false
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        rtc@69 {
+            compatible = "abracon,ab1805";
+            reg = <0x69>;
+            abracon,tc-diode = "schottky";
+            abracon,tc-resistor = <3>;
+        };
+    };
+...
-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/4] dt-bindings: rtc: abx80x: Convert text bindings to YAML

[Baruch Siach]

Hi Laurent,

On Tue, Mar 05 2024, Laurent Pinchart wrote:
> Convert the abx80x DT bindings to YAML schema. The existing properties
> are kept without modification, and the interrupt property is added as it
> is supported by the driver.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Done already in rtc-next:

https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=626e2b54645a4e9b58bcb479a565b4a06ff76a26

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Re: [PATCH 2/4] dt-bindings: rtc: abx80x: Convert text bindings to YAML

[Laurent Pinchart]

On Tue, Mar 05, 2024 at 06:46:10AM +0200, Baruch Siach wrote:
> On Tue, Mar 05 2024, Laurent Pinchart wrote:
> > Convert the abx80x DT bindings to YAML schema. The existing properties
> > are kept without modification, and the interrupt property is added as it
> > is supported by the driver.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Done already in rtc-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=626e2b54645a4e9b58bcb479a565b4a06ff76a26

Great :-) Thanks for the link.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/4] Add DT bindings and device tree for Compulab SB-UCM-iMX8MPLUS

[Rob Herring]

On Tue, 05 Mar 2024 02:42:17 +0200, Laurent Pinchart wrote:
> Hello,
> 
> This small patch series is a drive-by addition of the Compulab
> SB-UCM-iMX8MPLUS to the Linux kernel device tree sources. While porting
> the device tree from the Compulab BSP kernel to mainline, I thought I
> could as well mainline it, along with related conversion of text DT
> bindings to YAML.
> 
> The SB-UCM-iMX8MPLUS is a carrier board designed as a reference to
> evaluate the Compulab UCM-iMX8MPLUS SoM. The SoM integrates the bare
> minimal peripherals (DRAM, eMMC, ethernet PHY, EEPROM and RTC), while
> the carrier board includes a much wider range of peripherals. I have
> only enabled support for the ones I am interested in, or, as a strech
> goal, the ones I could easily test.
> 
> The first patch in the series adds compatible strings for the SoM and
> the board to the ARM FSL bindings. The next patch then converts text DT
> bindings to a YAML schema for the RTC present on the SoM. Finally, the
> last two patches add DT sources for the SoM and the carrier board.
> 
> Please see individual patches for details.
> 
> I have checked the validity of the bindings and the device tree sources.
> The only warnings in the DT sources are due to issues in imx8mp.dtsi.
> 
> Laurent Pinchart (4):
>   dt-bindings: arm: fsl: Add Compulab SB-UCM-iMX8MPLUS carrier board
>   dt-bindings: rtc: abx80x: Convert text bindings to YAML
>   arm64: dts: freescale: Add device tree for Compulab UCM-iMX8M-Plus
>   arm64: dts: freescale: Add device tree for Compulab SB-UCM-iMX8MPLUS
> 
>  .../devicetree/bindings/arm/fsl.yaml          |   6 +
>  .../bindings/rtc/abracon,abx80x.txt           |  31 --
>  .../bindings/rtc/abracon,abx80x.yaml          |  89 +++++
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../boot/dts/freescale/imx8mp-sb-ucm.dts      | 284 ++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi | 309 ++++++++++++++++++
>  6 files changed, 689 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
>  create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi
> 
> --
> Regards,
> 
> Laurent Pinchart
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx8mp-sb-ucm.dtb' for 20240305004222.622-1-laurent.pinchart@ideasonboard.com:

Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:68.1-10 Label or path hdmi_pvi not found
Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:72.1-9 Label or path hdmi_tx not found
Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:86.1-13 Label or path hdmi_tx_phy not found
Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:208.1-8 Label or path lcdif3 not found
FATAL ERROR: Syntax error parsing input tree
make[3]: *** [scripts/Makefile.lib:419: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb] Error 1
make[2]: *** [scripts/Makefile.build:481: arch/arm64/boot/dts/freescale] Error 2
make[2]: Target 'arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb' not remade because of errors.
make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1385: freescale/imx8mp-sb-ucm.dtb] Error 2
make: *** [Makefile:240: __sub-make] Error 2
make: Target 'freescale/imx8mp-sb-ucm.dtb' not remade because of errors.

Re: [PATCH 0/4] Add DT bindings and device tree for Compulab SB-UCM-iMX8MPLUS

[Laurent Pinchart]

Hi Rob,

On Tue, Mar 05, 2024 at 07:20:21AM -0600, Rob Herring wrote:
> On Tue, 05 Mar 2024 02:42:17 +0200, Laurent Pinchart wrote:
> > Hello,
> > 
> > This small patch series is a drive-by addition of the Compulab
> > SB-UCM-iMX8MPLUS to the Linux kernel device tree sources. While porting
> > the device tree from the Compulab BSP kernel to mainline, I thought I
> > could as well mainline it, along with related conversion of text DT
> > bindings to YAML.
> > 
> > The SB-UCM-iMX8MPLUS is a carrier board designed as a reference to
> > evaluate the Compulab UCM-iMX8MPLUS SoM. The SoM integrates the bare
> > minimal peripherals (DRAM, eMMC, ethernet PHY, EEPROM and RTC), while
> > the carrier board includes a much wider range of peripherals. I have
> > only enabled support for the ones I am interested in, or, as a strech
> > goal, the ones I could easily test.
> > 
> > The first patch in the series adds compatible strings for the SoM and
> > the board to the ARM FSL bindings. The next patch then converts text DT
> > bindings to a YAML schema for the RTC present on the SoM. Finally, the
> > last two patches add DT sources for the SoM and the carrier board.
> > 
> > Please see individual patches for details.
> > 
> > I have checked the validity of the bindings and the device tree sources.
> > The only warnings in the DT sources are due to issues in imx8mp.dtsi.
> > 
> > Laurent Pinchart (4):
> >   dt-bindings: arm: fsl: Add Compulab SB-UCM-iMX8MPLUS carrier board
> >   dt-bindings: rtc: abx80x: Convert text bindings to YAML
> >   arm64: dts: freescale: Add device tree for Compulab UCM-iMX8M-Plus
> >   arm64: dts: freescale: Add device tree for Compulab SB-UCM-iMX8MPLUS
> > 
> >  .../devicetree/bindings/arm/fsl.yaml          |   6 +
> >  .../bindings/rtc/abracon,abx80x.txt           |  31 --
> >  .../bindings/rtc/abracon,abx80x.yaml          |  89 +++++
> >  arch/arm64/boot/dts/freescale/Makefile        |   1 +
> >  .../boot/dts/freescale/imx8mp-sb-ucm.dts      | 284 ++++++++++++++++
> >  arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi | 309 ++++++++++++++++++
> >  6 files changed, 689 insertions(+), 31 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.txt
> >  create mode 100644 Documentation/devicetree/bindings/rtc/abracon,abx80x.yaml
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-ucm.dtsi
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y freescale/imx8mp-sb-ucm.dtb' for 20240305004222.622-1-laurent.pinchart@ideasonboard.com:
> 
> Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:68.1-10 Label or path hdmi_pvi not found
> Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:72.1-9 Label or path hdmi_tx not found
> Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:86.1-13 Label or path hdmi_tx_phy not found
> Error: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dts:208.1-8 Label or path lcdif3 not found

I forgot to mention in the cover letter that this depends on i.MX8MP
HDMI integration in DT that is currently pending. As it's not in
linux-next yet, I'll send a v2 that splits HDMI support in a separate
patch. Depending on when the HDMI integration gets merged, the base
SB-UCM support can go in by itself or with HDMI support in v6.10.

> FATAL ERROR: Syntax error parsing input tree
> make[3]: *** [scripts/Makefile.lib:419: arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb] Error 1
> make[2]: *** [scripts/Makefile.build:481: arch/arm64/boot/dts/freescale] Error 2
> make[2]: Target 'arch/arm64/boot/dts/freescale/imx8mp-sb-ucm.dtb' not remade because of errors.
> make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1385: freescale/imx8mp-sb-ucm.dtb] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
> make: Target 'freescale/imx8mp-sb-ucm.dtb' not remade because of errors.

-- 
Regards,

Laurent Pinchart