From: sashiko-bot@kernel.org
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
robh@kernel.org, wsa+renesas@sang-engineering.com,
conor+dt@kernel.org
Subject: Re: [PATCH v3 08/12] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate
Date: Mon, 06 Jul 2026 17:58:13 +0000 [thread overview]
Message-ID: <20260706175814.348E61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260706175138.12587-9-prabhakar.mahadev-lad.rj@bp.renesas.com>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Replace the hardcoded hardware synchronization delays with a calculated
> time window derived from the operating sub-clock frequency.
>
> The driver currently hardcodes microsecond ranges assuming a fixed
> sub-clock frequency of 32.768 kHz. Newer SoC variants, such as the
> RZ/T2H, drive this hardware block using a much faster clock rate
> (~195.3 kHz). Hardcoding these wait windows forces faster blocks to
> over-sleep, introducing unnecessary delays during clock initialization
> and register configuration.
>
> Calculate the duration of the required clock cycles in microseconds based
> on the runtime clock rate, and store this value in the driver private
> structure to adjust the usleep_range() and readl_poll_timeout() boundaries
> dynamically.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260706175138.12587-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=8
next prev parent reply other threads:[~2026-07-06 17:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 17:51 [PATCH v3 00/12] Add RTC support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-07-06 17:51 ` [PATCH v3 01/12] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support Prabhakar
2026-07-06 17:58 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 02/12] rtc: rzn1: Handle EPROBE_DEFER for optional pps interrupt Prabhakar
2026-07-06 17:56 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 03/12] rtc: rzn1: fix weekday underflow when alarm crosses month boundary Prabhakar
2026-07-06 18:00 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 04/12] rtc: rzn1: Fix malformed MODULE_AUTHOR string Prabhakar
2026-07-06 17:53 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 05/12] rtc: Kconfig: Broaden RTC_DRV_RZN1 dependency to ARCH_RENESAS Prabhakar
2026-07-06 17:54 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 06/12] rtc: rzn1: Fix alarm range check truncation on 32-bit systems Prabhakar
2026-07-06 18:04 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 07/12] rtc: rzn1: Replace remove callback with devm_add_action_or_reset() Prabhakar
2026-07-06 17:58 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 08/12] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate Prabhakar
2026-07-06 17:58 ` sashiko-bot [this message]
2026-07-06 17:51 ` [PATCH v3 09/12] rtc: rzn1: Use temporary variable for struct device Prabhakar
2026-07-06 17:56 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 10/12] rtc: rzn1: Consistently use dev_err_probe() Prabhakar
2026-07-06 17:55 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 11/12] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access Prabhakar
2026-07-06 17:57 ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 12/12] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-07-06 18:03 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706175814.348E61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox