[PATCH v3] rtc: bd70528: properly enable wakeup

[PATCH v3] rtc: bd70528: properly enable wakeup

[Andreas Kemnade]

Wakeup on RTC alarm now only accidentially works when wakeup for the power
button connected to the same PMIC is also enabled. Fix that by properly
specifying the wakeup irq.

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
---
Changes in v3:
- no changes in code, add fixes tag
- Link to v2: https://patch.msgid.link/20260916-rtc-bd-v2-1-ee5c15937d25@kemnade.info

Changes in v2:
- add error check
- Link to v1: https://patch.msgid.link/20260910092558.1008998-1-andreas@kemnade.info

To: Matti Vaittinen <mazziesaccount@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/rtc/rtc-bd70528.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/rtc/rtc-bd70528.c b/drivers/rtc/rtc-bd70528.c
index 482810b61495d..a58cf85bc1beb 100644
--- a/drivers/rtc/rtc-bd70528.c
+++ b/drivers/rtc/rtc-bd70528.c
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
+#include <linux/pm_wakeirq.h>
 #include <linux/regmap.h>
 #include <linux/rtc.h>
 
@@ -321,6 +322,10 @@ static int bd70528_probe(struct platform_device *pdev)
 	device_set_wakeup_capable(&pdev->dev, true);
 	device_wakeup_enable(&pdev->dev);
 
+	ret = devm_pm_set_wake_irq(&pdev->dev, irq);
+	if (ret)
+		return ret;
+
 	rtc = devm_rtc_allocate_device(&pdev->dev);
 	if (IS_ERR(rtc)) {
 		dev_err(&pdev->dev, "RTC device creation failed\n");

---
base-commit: df2908090cda368b01ff43709f51890076c56157
change-id: 20260916-rtc-bd-7d7b0e1c31b0

Best regards,
--  
Andreas Kemnade <andreas@kemnade.info>

Re: [PATCH v3] rtc: bd70528: properly enable wakeup

[sashiko-bot]

> Wakeup on RTC alarm now only accidentially works when wakeup for the power
> button connected to the same PMIC is also enabled. Fix that by properly
> specifying the wakeup irq.
> 
> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-rtc-bd-v3-1-7f2580c55d58@kemnade.info?part=1

Re: [PATCH v3] rtc: bd70528: properly enable wakeup

[Alexandre Belloni]

On Tue, 22 Sep 2026 15:20:15 +0200, Andreas Kemnade wrote:
> Wakeup on RTC alarm now only accidentially works when wakeup for the power
> button connected to the same PMIC is also enabled. Fix that by properly
> specifying the wakeup irq.

Applied, thanks!

[1/1] rtc: bd70528: properly enable wakeup
      https://git.kernel.org/abelloni/c/cb8a6249236f

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com