* [PATCH] rtc: ds1307: fix regmap config
@ 2017-07-25 16:44 Heiner Kallweit
2017-08-21 14:17 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2017-07-25 16:44 UTC (permalink / raw)
To: Alexandre Belloni, linux-rtc
Current max_register setting breaks reading nvram on certain chips and
also reading the standard registers on RX8130 where register map starts
at 0x10.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Fixes: 11e5890b5342 "rtc: ds1307: convert driver to regmap"
---
This fix should make it to 4.13.
---
drivers/rtc/rtc-ds1307.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index 4fac49e5..4b43aa62 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -1301,7 +1301,6 @@ static void ds1307_clks_register(struct ds1307 *ds1307)
static const struct regmap_config regmap_config = {
.reg_bits = 8,
.val_bits = 8,
- .max_register = 0x12,
};
static int ds1307_probe(struct i2c_client *client,
--
2.13.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rtc: ds1307: fix regmap config
2017-07-25 16:44 [PATCH] rtc: ds1307: fix regmap config Heiner Kallweit
@ 2017-08-21 14:17 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2017-08-21 14:17 UTC (permalink / raw)
To: Heiner Kallweit; +Cc: linux-rtc
On 25/07/2017 at 18:44:04 +0200, Heiner Kallweit wrote:
> Current max_register setting breaks reading nvram on certain chips and
> also reading the standard registers on RX8130 where register map starts
> at 0x10.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Fixes: 11e5890b5342 "rtc: ds1307: convert driver to regmap"
> ---
> This fix should make it to 4.13.
> ---
> drivers/rtc/rtc-ds1307.c | 1 -
> 1 file changed, 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-21 14:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-25 16:44 [PATCH] rtc: ds1307: fix regmap config Heiner Kallweit
2017-08-21 14:17 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox