Linux RTC
 help / color / mirror / Atom feed
From: "Csókás Bence" <csokas.bence@prolan.hu>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Szentendrei, Tamás" <szentendrei.tamas@prolan.hu>
Subject: Re: [PATCH resubmit] rtc: ds1307: Detect oscillator fail on mcp794xx
Date: Fri, 28 Jun 2024 10:58:33 +0200	[thread overview]
Message-ID: <83e2d171-86b0-4d51-8481-dc5b482b97a3@prolan.hu> (raw)
In-Reply-To: <202406272237033260538e@mail.local>

Hi!

On 6/28/24 00:37, Alexandre Belloni wrote:
> Hello,
> 
> It is not clear to me why your resent this one but not the other one,
> can you elaborate?

It was kind of an unrelated patch, I'll send it after I get this one 
merged. But so far, there hasn't been any movements on this series at all.

> On 21/06/2024 10:05:13+0200, Csókás, Bence wrote:
>> This patch enables the detection of the oscillator failure
>> on mcp794xx chips.
>>
>> Co-developed-by: Szentendrei, Tamás <szentendrei.tamas@prolan.hu>
>> Signed-off-by: Szentendrei, Tamás <szentendrei.tamas@prolan.hu>
>> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>

The "other one", I assume, refers to this:

On 6/11/24 09:24, Csókás, Bence wrote:
 > `tm_year` may go up to 299 if the device supports the
 > century bit. Therefore, subtracting may not give us
 > a valid 2-digit number, but modulo does.
 >
 > Co-developed-by: Szentendrei, Tamás <szentendrei.tamas@prolan.hu>
 > Signed-off-by: Szentendrei, Tamás <szentendrei.tamas@prolan.hu>
 > Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>

And the only thing they had in common is that they were in the same 
file, which my colleague, Tamás, put into one commit in our tree, that I 
split for upstreaming purposes. But really, they are not really related 
or interdependent on one another.

Bence


      reply	other threads:[~2024-06-28  8:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  8:05 [PATCH resubmit] rtc: ds1307: Detect oscillator fail on mcp794xx Csókás, Bence
2024-06-27 22:37 ` Alexandre Belloni
2024-06-28  8:58   ` Csókás Bence [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83e2d171-86b0-4d51-8481-dc5b482b97a3@prolan.hu \
    --to=csokas.bence@prolan.hu \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=szentendrei.tamas@prolan.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox