* [PATCH] rtc: pxa: fix possible race condition
@ 2017-08-21 15:57 Alexandre Belloni
2017-08-23 19:32 ` Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2017-08-21 15:57 UTC (permalink / raw)
To: linux-rtc; +Cc: Robert Jarzmik, linux-kernel, Alexandre Belloni
pxa_rtc_open() registers the interrupt handler which will access the RTC
registers. However, pxa_rtc_open() is called before the register range is
ioremapped. Instead, call it after devm_ioremap().
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/rtc/rtc-pxa.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index fe4985b54608..47304f5664d8 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
@@ -348,7 +348,7 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
dev_err(dev, "No alarm IRQ resource defined\n");
return -ENXIO;
}
- pxa_rtc_open(dev);
+
pxa_rtc->base = devm_ioremap(dev, pxa_rtc->ress->start,
resource_size(pxa_rtc->ress));
if (!pxa_rtc->base) {
@@ -356,6 +356,8 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
return -ENOMEM;
}
+ pxa_rtc_open(dev);
+
sa1100_rtc->rcnr = pxa_rtc->base + 0x0;
sa1100_rtc->rtsr = pxa_rtc->base + 0x8;
sa1100_rtc->rtar = pxa_rtc->base + 0x4;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: pxa: fix possible race condition
2017-08-21 15:57 [PATCH] rtc: pxa: fix possible race condition Alexandre Belloni
@ 2017-08-23 19:32 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2017-08-23 19:32 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc, linux-kernel
Alexandre Belloni <alexandre.belloni@free-electrons.com> writes:
> pxa_rtc_open() registers the interrupt handler which will access the RTC
> registers. However, pxa_rtc_open() is called before the register range is
> ioremapped. Instead, call it after devm_ioremap().
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-23 19:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-21 15:57 [PATCH] rtc: pxa: fix possible race condition Alexandre Belloni
2017-08-23 19:32 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox