Re: [PATCH] rtc: interface: Alarm race handling should not discard preceding error

[Esben Haabendal <esben@geanix.com>]

"Thorsten Leemhuis" <regressions@leemhuis.info> writes:

> On 12/16/25 16:09, Nick Bowler wrote:
>> On Tue, Dec 16, 2025 at 11:51:30AM +0100, Thorsten Leemhuis wrote:
>>> Lo! FWIW, Nick Bowler (now CCed) reported that below patch fixes a
>>> regression for him caused by the commit from Esben (now also CCed) the
>>> Fixes: tag mentions. See "hwclock busted w/ M48T59 RTC (regression)" for
>>> details:
>>> https://lore.kernel.org/all/2t6bhs4udbu55ctbemkhlluchz2exrwown7kmu2gss6zukaxdm@ughygemahmem/
>>> and
>>>
>>> Nick, could you maybe provide a tested-by tag here? Maybe that would
>>> motivate someone to get this en route to mainline.
>>>
>>> Adding a "Cc: <stable@vger.kernel.org>" would be great, too, as Nick
>>> encountered this on earlier series, as it was backported all the way to
>>> 5.15.y
>>
>> It was backported to 5.10.y and 5.4.y too, but only after I had reported
>> this regression back in October (and I guess 5.4.y is EOL now).
>>
>> Tested-by: Nick Bowler <nbowler@draconx.ca>
>
> Esben (author of the culprit) and Alexandre (who merged it): do you
> still have reviewing/applying the patch at the start of this thread (
> https://lore.kernel.org/all/BN0PR08MB6951415A751F236375A2945683D1A@BN0PR08MB6951.namprd08.prod.outlook.com/#t)
> on your todo list?
>
> Sorry for nagging, would just be good to finally get this 6.18-rc1
> regression fixed in mainline so the fix can be backported to stable,
> too. And due to the holidays I thought a quick reminder might be wise.
>
> Or was this fixed somehow and I just missed it?

Sorry for introducing this error. The fix looks good to me. I have added
my Reviewed-by to it.

Am I correct in that it also fixes the problem reported by Nick Bowler?

/Esben