From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, Thierry Reding <treding@nvidia.com>
Subject: Re: [BUG] 6.16-rc7: lockdep failure with max77620-gpio/max77686-rtc
Date: Thu, 31 Jul 2025 17:28:39 +0100 [thread overview]
Message-ID: <aIuZt3asLeiYncH1@shell.armlinux.org.uk> (raw)
In-Reply-To: <14c68c29-68d8-4119-8f70-616c07397dc4@sirena.org.uk>
On Thu, Jul 31, 2025 at 05:16:13PM +0100, Mark Brown wrote:
> On Thu, Jul 31, 2025 at 04:57:42PM +0100, Russell King (Oracle) wrote:
> > On Thu, Jul 31, 2025 at 02:18:24PM +0100, Mark Brown wrote:
>
> > > I *think* mutex_lock_nested() is what we're looking for here, with the
> > > depth information from the irq_desc but I'm also not super familiar with
> > > this stuff.
>
> > I'm not sure about that, because the irq_desc locks don't nest:
>
> > raw_spin_lock_init(&desc->lock);
> > lockdep_set_class(&desc->lock, &irq_desc_lock_class);
>
> > What saves irq_desc lock nesting in this case is that
> > __irq_put_desc_unlock() unlocks desc->lock calling the
> > irq_bus_sync_unlock() method. So, I don't think we have anything at
> > the irq_desc level which deals with lock-nesting.
>
> Yeah, and that's all internals which we're not super encouraged to peer
> at. There should be something that'll give us a nesting level
> somewhere...
>
> Lockdep's handling of nesting is generally fun.
As I said, I'm just going to disable lockdep to shut up the warning and
not pursue any further time on this. If someone else cares about it
(which I doubt) they can try to come up with a solution. I suspect
nested regmap-irq is extremely rare.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-07-31 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 17:58 [BUG] 6.16-rc7: lockdep failure with max77620-gpio/max77686-rtc Russell King (Oracle)
2025-07-30 19:43 ` Krzysztof Kozlowski
2025-07-31 12:18 ` Russell King (Oracle)
2025-07-31 12:31 ` Mark Brown
2025-07-31 12:43 ` Russell King (Oracle)
2025-07-31 13:18 ` Mark Brown
2025-07-31 15:57 ` Russell King (Oracle)
2025-07-31 16:16 ` Mark Brown
2025-07-31 16:28 ` Russell King (Oracle) [this message]
2025-07-31 17:03 ` Mark Brown
2025-07-31 19:20 ` Russell King (Oracle)
2025-07-31 19:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aIuZt3asLeiYncH1@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.belloni@bootlin.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox