Linux RTC
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Thierry Reding <treding@nvidia.com>
Subject: Re: [BUG] 6.16-rc7: lockdep failure with max77620-gpio/max77686-rtc
Date: Thu, 31 Jul 2025 20:20:51 +0100	[thread overview]
Message-ID: <aIvCE4x24RigKBKF@shell.armlinux.org.uk> (raw)
In-Reply-To: <b91dd3c5-c24e-43d1-8d06-8ec4d01f2762@sirena.org.uk>

On Thu, Jul 31, 2025 at 06:03:43PM +0100, Mark Brown wrote:
> On Thu, Jul 31, 2025 at 05:28:39PM +0100, Russell King (Oracle) wrote:
> > On Thu, Jul 31, 2025 at 05:16:13PM +0100, Mark Brown wrote:
> 
> > > Yeah, and that's all internals which we're not super encouraged to peer
> > > at.  There should be something that'll give us a nesting level
> > > somewhere...  
> 
> > > Lockdep's handling of nesting is generally fun.
> 
> > As I said, I'm just going to disable lockdep to shut up the warning and
> > not pursue any further time on this. If someone else cares about it
> > (which I doubt) they can try to come up with a solution. I suspect
> > nested regmap-irq is extremely rare.
> 
> I'm pretty sure it's extremely rare, and I'll have to construct a
> virtual setup to actually test.  After poking at it some more I think
> we're actually going to need an explicit lock_class_key for each
> regmap-irq rather than relying on the default lockdep one.  I'll try to
> send out a patch for that today or tomorrow but likely not really tested
> - if you could find time to give it a spin on the affected system that'd
> be good, but if not no worries.  Thanks for the report and analysis.

I hope we don't have too many regmap-irq's in a system - see the
section on "Troubleshooting" in the lockdep documentation. There's
a limit on the numbe of classes over the entire kernel.

For reference, on the platform which provokes this lockdep splat,
we already have 1518 lock classes:

# grep "lock-classes" /proc/lockdep_stats
 lock-classes:                         1518 [max: 8192]

As I understand from the documentation, lock classes are create-only,
there's no way of "freeing" them later, so we better not get into a
situation where the number of classes steadily increase while the
system is running!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2025-07-31 19:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 17:58 [BUG] 6.16-rc7: lockdep failure with max77620-gpio/max77686-rtc Russell King (Oracle)
2025-07-30 19:43 ` Krzysztof Kozlowski
2025-07-31 12:18   ` Russell King (Oracle)
2025-07-31 12:31     ` Mark Brown
2025-07-31 12:43       ` Russell King (Oracle)
2025-07-31 13:18         ` Mark Brown
2025-07-31 15:57           ` Russell King (Oracle)
2025-07-31 16:16             ` Mark Brown
2025-07-31 16:28               ` Russell King (Oracle)
2025-07-31 17:03                 ` Mark Brown
2025-07-31 19:20                   ` Russell King (Oracle) [this message]
2025-07-31 19:50                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aIvCE4x24RigKBKF@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=alexandre.belloni@bootlin.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox