Linux RTC
 help / color / mirror / Atom feed
From: Imre Kaloz <kaloz@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	 linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Lee Jones <lee@kernel.org>,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 30/53] rtc: m48t35: support the SGI IP35 timekeeper's 1968 year base
Date: Sat, 17 Oct 2026 01:09:58 +0200 (CEST)	[thread overview]
Message-ID: <afff29f4-c16f-beec-9f59-9a7baa9c7355@kernel.org> (raw)
In-Reply-To: <2026101314285588f70d85@mail.local>

Hello Alexandre,

On Tue, 13 Oct 2026, Alexandre Belloni wrote:

<snip>

> Instead of open coding, you should use start_secs after setting the rtc
> range in probe(). attached i a patch I refreshed for the
> devm_rtc_allocate_device/devm_rtc_register_device conversion that you
> can include in this series. drivers/rtc/rtc-mt6397.c is an example that
> should be working for you.
>
> I never sent the patch because it is not clear from the datasheet how
> well leap year calculation works. My guess is that it worked in 2000 but
> fails in 2100.

Thanks, that is cleaner. In the next posting I'll take your devm
conversion first and set range_min/range_max and start_secs in probe
instead of open-coding the epoch.


Thanks,
Imre

  reply	other threads:[~2026-10-16 23:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 13:16 [PATCH v2 00/53] MIPS: SGI-IP27: add support for the IP35 (Bedrock hub) machines Imre Kaloz
2026-10-13 13:16 ` [PATCH v2 30/53] rtc: m48t35: support the SGI IP35 timekeeper's 1968 year base Imre Kaloz
2026-10-13 14:28   ` Alexandre Belloni
2026-10-16 23:09     ` Imre Kaloz [this message]
2026-10-13 13:35 ` [PATCH v2 00/53] MIPS: SGI-IP27: add support for the IP35 (Bedrock hub) machines Niklas Cassel
2026-10-13 14:25   ` Imre Kaloz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afff29f4-c16f-beec-9f59-9a7baa9c7355@kernel.org \
    --to=kaloz@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox