From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: sashiko-reviews@lists.linux.dev
Cc: Prabhakar <prabhakar.csengg@gmail.com>,
linux-rtc@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers
Date: Sat, 22 Aug 2026 21:22:23 +0200 [thread overview]
Message-ID: <aon271wPK9H8gAvR@ninjato> (raw)
In-Reply-To: <20260821212612.10E0C1F00A3E@smtp.kernel.org>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Fri, Aug 21, 2026 at 09:26:11PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] Data race and TOCTOU in IRQ handler leading to spurious interrupts and incomplete synchronization
> - [High] Hardware state lockup on timeout in rzn1_rtc_set_time()
> - [High] Alarm logic erroneously uses 1-second interrupt for past alarms with the same minute
> - [Medium] Race window in rzn1_rtc_read_time() fallback logic can produce inconsistent timestamps
All pre-existing issues, should be handled incrementally.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-08-22 19:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 21:10 [PATCH v6 00/17] Add RTC support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-08-21 21:10 ` [PATCH v6 01/17] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support Prabhakar
2026-08-21 21:19 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 02/17] rtc: rzn1: Handle EPROBE_DEFER for optional pps interrupt Prabhakar
2026-08-21 21:20 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 03/17] rtc: rzn1: Fix weekday underflow when alarm crosses month boundary Prabhakar
2026-08-21 21:26 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 04/17] rtc: rzn1: Handle unset alarm weekday in rzn1_rtc_read_alarm Prabhakar
2026-08-21 21:18 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 05/17] rtc: rzn1: Fix alarm range check truncation on 32-bit systems Prabhakar
2026-08-21 21:22 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 06/17] rtc: rzn1: Disable alarm interrupt before reprogramming alarm registers Prabhakar
2026-08-21 21:26 ` sashiko-bot
2026-08-22 19:22 ` Wolfram Sang [this message]
2026-08-21 21:10 ` [PATCH v6 07/17] rtc: rzn1: Fix malformed MODULE_AUTHOR string Prabhakar
2026-08-21 21:13 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 08/17] rtc: Kconfig: Broaden RTC_DRV_RZN1 dependency to ARCH_RENESAS Prabhakar
2026-08-21 21:15 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 09/17] rtc: rzn1: Use pm_runtime_put_sync() Prabhakar
2026-08-21 21:19 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 10/17] rtc: rzn1: Replace remove callback with devm_add_action_or_reset() Prabhakar
2026-08-21 21:17 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 11/17] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate Prabhakar
2026-08-21 21:16 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 12/17] rtc: rzn1: Use temporary variable for struct device Prabhakar
2026-08-21 21:18 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 13/17] rtc: rzn1: Consistently use dev_err_probe() Prabhakar
2026-08-21 21:17 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 14/17] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access Prabhakar
2026-08-21 21:20 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 15/17] rtc: rzn1: Add OF match data to gate SUBU " Prabhakar
2026-08-21 21:20 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 16/17] rtc: rzn1: Drop trailing comma from OF match table sentinel Prabhakar
2026-08-21 21:18 ` sashiko-bot
2026-08-21 21:10 ` [PATCH v6 17/17] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-08-21 21:25 ` sashiko-bot
2026-08-22 19:27 ` [PATCH v6 00/17] Add RTC " Wolfram Sang
2026-08-23 19:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aon271wPK9H8gAvR@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox