Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X

[Haipeng Lin <jimmie.lin@gmail.com>]

On 11/15/26 3:20 AM, Val Packett wrote:

[...]>> Would it make sense to move opp-3072000000 and opp-3148800000 into the
>> shared sc8180x-microsoft-surface-pro-x.dtsi? qcom-cpufreq-hw disables
>> all DT OPPs first and only re-enables freqs present in the hardware LUT
>> so this would work for SQ1 and caspar.dtb will cover both the SQ1 and
>> SQ2 Wi-Fi models out of the box and carina.dts won't need its own
>> &cpu4_opp_table override.
> 
> I'm pretty sure mine *did* complain very loudly about having these OPPs and might've even had broken scaling.
> 
> I'll retest again, if it works I'll move it to the shared dtsi (or even the SoC's?)

I like the idea of moving it to the SoC. Did a test on my SQ2 Wi-Fi
with opp-3072000000/opp-3148800000 moved into sc8180x.dtsi, dropping
it from carina.dts, plus a dummy opp-32256000000 above my LUT's top
entry so I can "simulate" the SQ1 situation where there's a DT OPP that
the LUT does not have. Booting that with caspar.dtb:

- no cpufreq/OPP messages at all (e.g., "Voltage update failed" or
  "failed to update OPP" as observed for caspar.dts in this v1 on SQ2)
- policy4 scaling_available_frequencies tops out at 3148800, the dummy
  3225600 is disabled silently (by qcom_cpufreq_hw_read_lut() ?)
- under load time_in_state shows gold cluster sits at 3148800

Hopefully, this solution should work for both SQ1 and SQ2. sc8180x.dtsi
looks like it tops out at 2995200, and that is SQ1's bin above the
"regular" 8cx Gen 1's 2.84 GHz on the gold cluster so if it was broken
it would already be broken for the 8cx G1 due to the SQ1 entries...

[...]> 
> BTW, please send me the output of `sudo fwupdtool hwids`, these are needed to add support to dtbloader/systemd-stub/stubble DT auto-selection.
> 
> (If anyone with the cellular variants reads this: you too :))
> 
> 
> Thanks,
> 
> ~val

This is not the latest BIOS which is 11.504.140 according to
https://support.microsoft.com/en-us/surface/updates/surface-pro-x-update-history
but I don't have dual boot to update it...

Surface Pro X SQ2 Wi-Fi only:

Computer Information
--------------------
BiosVendor: Microsoft Corporation
BiosVersion: 11.311.140
BiosMajorRelease: 255
BiosMinorRelease: 255
BiosReleaseDate: 2/03/2026
FirmwareMajorRelease: ff
FirmwareMinorRelease: ff
Manufacturer: Microsoft Corporation
Family: Surface
ProductName: Surface Pro X
ProductSku: Surface_Pro_X_2010
EnclosureKind: 9
BaseboardManufacturer: Microsoft Corporation
BaseboardProduct: Surface Pro X
Hardware IDs
------------
{bf87a823-6823-50f1-9f18-2030fd86b087}   <- Manufacturer + Family + ProductName + ProductSku + BiosVendor + BiosVersion + BiosMajorRelease + BiosMinorRelease
{43cb3df2-05e6-5637-a89c-718381284f3d}   <- Manufacturer + Family + ProductName + BiosVendor + BiosVersion + BiosMajorRelease + BiosMinorRelease
{1d2505b3-3329-5a15-b934-e1990787e978}   <- Manufacturer + ProductName + BiosVendor + BiosVersion + BiosMajorRelease + BiosMinorRelease
{75b4817e-50ec-5e63-a904-1175cd1abff6}   <- Manufacturer + Family + ProductName + ProductSku + BaseboardManufacturer + BaseboardProduct
{cdf510a8-d41c-54bf-b2c5-61ba10957019}   <- Manufacturer + Family + ProductName + ProductSku
{cc2bc434-a08a-59c0-85ac-2576ed611de6}   <- Manufacturer + Family + ProductName
{69c2fd0d-8593-575f-b6af-5f70f0299ea4}   <- Manufacturer + ProductSku + BaseboardManufacturer + BaseboardProduct
{aa2c30e9-117c-5aeb-a8aa-4b01761cf493}   <- Manufacturer + ProductSku
{b07028e2-19c1-577d-a3c9-2eabef35c2a1}   <- Manufacturer + ProductName + BaseboardManufacturer + BaseboardProduct
{5d018db8-6de6-55f8-8d8b-4b773caf8450}   <- Manufacturer + ProductName
{db7e6e61-56bf-531d-b594-e4b1660d04aa}   <- Manufacturer + Family + BaseboardManufacturer + BaseboardProduct
{ca2e5189-1d32-509f-88a0-d4ebcc721899}   <- Manufacturer + Family
{aca387a9-183e-5da9-8f9d-f460c3f50f54}   <- Manufacturer + EnclosureKind
{f199ec04-d0d9-542b-b035-209532a4d1f6}   <- Manufacturer + BaseboardManufacturer + BaseboardProduct
{cc0aea32-ad2c-5013-8bed-cede6be8c9f4}   <- Manufacturer

Thanks,
Haipeng