* Re: [PATCH v1 1/2] rtc: cmos: Enable ACPI alarm if advertised in ACPI FADT
From: Mario Limonciello (AMD) (kernel.org) @ 2026-03-20 19:26 UTC (permalink / raw)
To: Rafael J. Wysocki, linux-rtc; +Cc: LKML, Linux ACPI, Alexandre Belloni
In-Reply-To: <9618535.CDJkKcVGEf@rafael.j.wysocki>
On 3/14/2026 7:11 AM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> If the ACPI_FADT_FIXED_RTC flag is unset, the platform is declaring that
> it supports the ACPI RTC fixed event which should be used instead of a
> dedicated CMOS RTC IRQ. However, the driver only enables it when
> is_hpet_enabled() returns true, which is questionable because there is
> no clear connection between enabled HPET and signaling wakeup via the
> ACPI RTC fixed event (for instance, the latter can be expected to work
> on systems that don't include a functional HPET).
>
> Moreover, since use_hpet_alarm() returns false if use_acpi_alarm is set,
> the ACPI RTC fixed event is effectively used instead of the HPET alarm
> if the latter is functional, but there is no particular reason why it
> could not be used otherwise.
>
> Accordingly, on x86 systems with ACPI, set use_acpi_alarm if
> ACPI_FADT_FIXED_RTC is unset without looking at whether or not HPET is
> enabled.
>
> Also, do the ACPI FADT check in use_acpi_alarm_quirks() before the DMI
> BIOS year checks which are more expensive and it's better to skip them
> if ACPI_FADT_FIXED_RTC is set.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This makes sense to me.
Sorry for my delay, I kept on meaning to check a few machines and then
more things came up and it fell lower.
I did check 3 generations of AMD machines and I don't expect any
problems from this change.
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> drivers/rtc/rtc-cmos.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -817,6 +817,9 @@ static void rtc_wake_off(struct device *
> #ifdef CONFIG_X86
> static void use_acpi_alarm_quirks(void)
> {
> + if (acpi_gbl_FADT.flags & ACPI_FADT_FIXED_RTC)
> + return;
> +
> switch (boot_cpu_data.x86_vendor) {
> case X86_VENDOR_INTEL:
> if (dmi_get_bios_year() < 2015)
> @@ -830,8 +833,6 @@ static void use_acpi_alarm_quirks(void)
> default:
> return;
> }
> - if (!is_hpet_enabled())
> - return;
>
> use_acpi_alarm = true;
> }
>
>
>
^ permalink raw reply
* Re: [PATCH v1 2/2] rtc: cmos: Do not require IRQ if ACPI alarm is used
From: Alexandre Belloni @ 2026-03-20 18:00 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-rtc, LKML, Linux ACPI, Mario Limonciello
In-Reply-To: <6168746.MhkbZ0Pkbq@rafael.j.wysocki>
On 14/03/2026 13:12:44+0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> If the ACPI RTC fixed event is used, a dedicated IRQ is not required
> for the CMOS RTC alarm to work, so allow the driver to use the alarm
> without a valid IRQ in that case.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/rtc/rtc-cmos.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -216,6 +216,11 @@ static inline void cmos_write_bank2(unsi
>
> /*----------------------------------------------------------------*/
>
> +static bool cmos_no_alarm(struct cmos_rtc *cmos)
> +{
> + return !is_valid_irq(cmos->irq) && !cmos_use_acpi_alarm();
> +}
> +
> static int cmos_read_time(struct device *dev, struct rtc_time *t)
> {
> int ret;
> @@ -287,7 +292,7 @@ static int cmos_read_alarm(struct device
> };
>
> /* This not only a rtc_op, but also called directly */
> - if (!is_valid_irq(cmos->irq))
> + if (cmos_no_alarm(cmos))
> return -ETIMEDOUT;
>
> /* Basic alarms only support hour, minute, and seconds fields.
> @@ -520,7 +525,7 @@ static int cmos_set_alarm(struct device
> int ret;
>
> /* This not only a rtc_op, but also called directly */
> - if (!is_valid_irq(cmos->irq))
> + if (cmos_no_alarm(cmos))
> return -EIO;
>
> ret = cmos_validate_alarm(dev, t);
> @@ -1096,7 +1101,7 @@ cmos_do_probe(struct device *dev, struct
> dev_dbg(dev, "IRQ %d is already in use\n", rtc_irq);
> goto cleanup1;
> }
> - } else {
> + } else if (!cmos_use_acpi_alarm()) {
> clear_bit(RTC_FEATURE_ALARM, cmos_rtc.rtc->features);
> }
>
> @@ -1121,7 +1126,7 @@ cmos_do_probe(struct device *dev, struct
> acpi_rtc_event_setup(dev);
>
> dev_info(dev, "%s%s, %d bytes nvram%s\n",
> - !is_valid_irq(rtc_irq) ? "no alarms" :
> + cmos_no_alarm(&cmos_rtc) ? "no alarms" :
> cmos_rtc.mon_alrm ? "alarms up to one year" :
> cmos_rtc.day_alrm ? "alarms up to one month" :
> "alarms up to one day",
> @@ -1147,7 +1152,7 @@ cleanup0:
> static void cmos_do_shutdown(int rtc_irq)
> {
> spin_lock_irq(&rtc_lock);
> - if (is_valid_irq(rtc_irq))
> + if (!cmos_no_alarm(&cmos_rtc))
> cmos_irq_disable(&cmos_rtc, RTC_IRQMASK);
> spin_unlock_irq(&rtc_lock);
> }
>
>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply
* Re: [PATCH v1 1/2] rtc: cmos: Enable ACPI alarm if advertised in ACPI FADT
From: Alexandre Belloni @ 2026-03-20 18:00 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-rtc, LKML, Linux ACPI, Mario Limonciello
In-Reply-To: <9618535.CDJkKcVGEf@rafael.j.wysocki>
On 14/03/2026 13:11:20+0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> If the ACPI_FADT_FIXED_RTC flag is unset, the platform is declaring that
> it supports the ACPI RTC fixed event which should be used instead of a
> dedicated CMOS RTC IRQ. However, the driver only enables it when
> is_hpet_enabled() returns true, which is questionable because there is
> no clear connection between enabled HPET and signaling wakeup via the
> ACPI RTC fixed event (for instance, the latter can be expected to work
> on systems that don't include a functional HPET).
>
> Moreover, since use_hpet_alarm() returns false if use_acpi_alarm is set,
> the ACPI RTC fixed event is effectively used instead of the HPET alarm
> if the latter is functional, but there is no particular reason why it
> could not be used otherwise.
>
> Accordingly, on x86 systems with ACPI, set use_acpi_alarm if
> ACPI_FADT_FIXED_RTC is unset without looking at whether or not HPET is
> enabled.
>
> Also, do the ACPI FADT check in use_acpi_alarm_quirks() before the DMI
> BIOS year checks which are more expensive and it's better to skip them
> if ACPI_FADT_FIXED_RTC is set.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/rtc/rtc-cmos.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -817,6 +817,9 @@ static void rtc_wake_off(struct device *
> #ifdef CONFIG_X86
> static void use_acpi_alarm_quirks(void)
> {
> + if (acpi_gbl_FADT.flags & ACPI_FADT_FIXED_RTC)
> + return;
> +
> switch (boot_cpu_data.x86_vendor) {
> case X86_VENDOR_INTEL:
> if (dmi_get_bios_year() < 2015)
> @@ -830,8 +833,6 @@ static void use_acpi_alarm_quirks(void)
> default:
> return;
> }
> - if (!is_hpet_enabled())
> - return;
>
> use_acpi_alarm = true;
> }
>
>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply
* Re: [PATCH v1 0/2] rtc: cmos: Do not require IRQ if ACPI alarm is used
From: Rafael J. Wysocki @ 2026-03-20 15:56 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-rtc, LKML, Linux ACPI, Alexandre Belloni, Mario Limonciello
In-Reply-To: <3964452.kQq0lBPeGt@rafael.j.wysocki>
On Sat, Mar 14, 2026 at 1:13 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> Hi All,
>
> This series of patches allows the CMOS RTC alarm to be used on x86
> systems that don't include a functional HPET and may not configure
> an IRQ for the CMOS RTC, but have a functional ACPI RTC fixed event.
>
> The first patch allows the ACPI RTC fixed event to be used on systems
> without functional HPET because there is no fundamental dependency
> between HPET and the ACPI RTC fixed event being hooked up to the CMOS
> RTC.
>
> The second patch changes the driver to stop requiring an IRQ to be
> configured for the alarm functionality if the ACPI RTC fixed event
> is use for signaling events because it require a separate IRQ to
> be requested (the ACPI SCI is used for event signaling in that case).
If anyone has any objections or concerns regarding these patches,
please let me know.
In the absence of any, I'll queue them up for 7.1 on top of the
previous CMOS RTC driver changes.
Thanks!
^ permalink raw reply
* Re: (subset) [PATCH v4 4/5] dt-bindings: mfd: max77620: document optional RTC address for MAX77663
From: Lee Jones @ 2026-03-19 18:26 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lee Jones, Liam Girdwood,
Mark Brown, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Chanwoo Choi, Alexandre Belloni, Svyatoslav Ryhel
Cc: linux-gpio, devicetree, linux-kernel, linux-pm, linux-rtc
In-Reply-To: <20260312085258.11431-5-clamor95@gmail.com>
On Thu, 12 Mar 2026 10:52:57 +0200, Svyatoslav Ryhel wrote:
> Document an optional second I2C address for the MAX77663 PMIC's RTC
> device, to be used if the MAX77663 RTC is located at a non-default I2C
> address.
>
>
Applied, thanks!
[4/5] dt-bindings: mfd: max77620: document optional RTC address for MAX77663
commit: a526075f56fb8f2fd96f791654ff1557e6680bde
--
Lee Jones [李琼斯]
^ permalink raw reply
* Re: (subset) [PATCH v4 3/5] dt-bindings: mfd: max77620: convert to DT schema
From: Lee Jones @ 2026-03-19 18:23 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lee Jones, Liam Girdwood,
Mark Brown, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Chanwoo Choi, Alexandre Belloni, Svyatoslav Ryhel
Cc: linux-gpio, devicetree, linux-kernel, linux-pm, linux-rtc
In-Reply-To: <20260312085258.11431-4-clamor95@gmail.com>
On Thu, 12 Mar 2026 10:52:56 +0200, Svyatoslav Ryhel wrote:
> Convert max77620 devicetree bindings from TXT to YAML format. This patch
> does not change any functionality; the bindings remain the same. The
> thermal bindings are incorporated into the binding. GPIO controller
> function in MAX77620 has no dedicated node and is folded into the parent
> node itself.
>
>
> [...]
Applied, thanks!
[3/5] dt-bindings: mfd: max77620: convert to DT schema
commit: 77c8585abf5d7409990b71ba333e839bf4597cb5
--
Lee Jones [李琼斯]
^ permalink raw reply
* Re: [PATCH 05/15] dt-bindings: rtc: ingenic,rtc: Use generic power-controller schema
From: Paul Cercueil @ 2026-03-19 11:12 UTC (permalink / raw)
To: Peng Fan (OSS), Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rafael J. Wysocki, Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Alexandre Belloni,
Dmitry Osipenko, Heiko Stuebner, Joseph Chen, Chris Zhong,
Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-5-92c80e5e1744@nxp.com>
Hi,
Le lundi 16 mars 2026 à 22:47 +0800, Peng Fan (OSS) a écrit :
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert the binding to use the generic power-controller schema
> instead by
> referencing power-controller.yaml and removing the local
> `system-power-controller` property definition.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml
> b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml
> index
> de9879bdb3175a7e0f24304b5a084a8faa233c46..415566d8dba564ebad976689596
> bbcd699ed6021 100644
> --- a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> allOf:
> - $ref: rtc.yaml#
> + - $ref: /schemas/power/power-controller.yaml#
> - if:
> not:
> properties:
> @@ -53,12 +54,6 @@ properties:
> "#clock-cells":
> const: 0
>
> - system-power-controller:
> - description: |
> - Indicates that the RTC is responsible for powering OFF
> - the system.
> - type: boolean
> -
> ingenic,reset-pin-assert-time-ms:
> minimum: 0
> maximum: 125
^ permalink raw reply
* 社長のNG行動
From: 神田／ナレッジリンク @ 2026-03-18 4:30 UTC (permalink / raw)
To: linux-rtc
お世話になります。ナレッジリンクセミナー事務局です。
「社員のモチベーションを上げようと声をかける」
「部下の相談に乗り、一緒に悩んであげる」
「現場のトラブルに、自ら先頭に立って対応する」
もし社長がこれらを率先しているようであれば、
残念ながら、その組織の成長はそこで止まります。
社長のその“優しさ”が、社員の甘えを生み、責任感を奪い、
「指示待ち人間」を量産する装置になっているからです。
4,800社の経営者が衝撃を受けた、
良かれと思ってやってしまう「社長のNG行動」の正体。
組織を劇的に変えるための、
オンラインセミナーを開催いたします。
1つでも心当たりがあれば、一度ご視聴ください。
>>視聴予約はこちら
https://knowledge-corp.jp/shikigaku5/
----------------------------------------------
テーマ ： それ、危険です 『社長のNG行動』
〜 その行動が、組織崩壊を招く 〜
日 程 ： 3月19日（木）13:00〜15:00 残り14枠
4月14日（火）13:00〜15:00
4月21日（火）13:00〜15:00
※どちらの日程も内容は同じ
会 場 ：Zoom開催
定 員 ：先着100名（費用は不要）
----------------------------------------------
※経営層の方限定です
なぜ、社員は「言われたこと」しかやらないのか。
なぜ、次世代のリーダー候補が育たないのか。
それは、能力の問題ではなく、
良かれと思って続けている「社長の配慮」こそが、
組織成長を止める、最大のボトルネックかもしれません。
本セミナーでは、4,800社以上が導入した
独自の組織論「識学」に基づき、社長の「NG行動」と
真の経営者へ脱皮するためのマインドセットを伝授します。
【セミナー内容(一部抜粋)】
○ NG行動3選
○ なぜ優秀なNo.2や部長が育たないのか
○ マネジメントスタイルの変革について
○ 導入企業の事例
「管理職が育ったら任せる」ではなく「任せるから育つ」
という思考の逆転を提言。
現場から「冷たくなった」と思われることを恐れず、
機能的な階層構造（仕組み）を作ることで
結果として社員全員を守り、
利益を最大化させる道筋を明示します。
「優しさ」で人を動かすのではなく、
「正しさ」で組織を動かす。
音声やお顔が表に出ることはございませんので
お気軽にご視聴ください。
>>視聴予約はこちら
https://knowledge-corp.jp/shikigaku5/
-----------------------
一般社団法人 ナレッジリンク
東京都千代田区神田小川町1-8-3
電話：03-5256-7638
セミナーのご案内が不要な方は大変残念ではございますが、
下記URLより手続き下さいませ。
メール配信のワンクリック解除はこちら
https://fc-knowledgelink-corp.jp/mail/
^ permalink raw reply
* [PATCH] rtc: add data_race() in rtc_dev_poll()
From: Mauricio Faria de Oliveira @ 2026-03-17 23:22 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-rtc, linux-kernel, kernel-dev, syzbot+2d4127acca35ed7b31ad,
Mauricio Faria de Oliveira
The unlocked read of rtc->irq_data in rtc_dev_poll() can race with
the write in rtc_handle_legacy_irq() and also, theoretically, with
the write in rtc_dev_read().
These races should be safe (see inline comment), thus annotate the
read with data_race() for KCSAN.
Reported-by: syzbot+2d4127acca35ed7b31ad@syzkaller.appspotmail.com
Closes: https://syzbot.org/bug?extid=2d4127acca35ed7b31ad
Signed-off-by: Mauricio Faria de Oliveira <mfo@igalia.com>
---
Compile-tested on next-20260317.
---
drivers/rtc/dev.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/dev.c b/drivers/rtc/dev.c
index baf1a8ca8b2b1ea806c56b06926a03975b3636a8..8ba7c25d2565ef4139594976881aaee18e16a048 100644
--- a/drivers/rtc/dev.c
+++ b/drivers/rtc/dev.c
@@ -195,7 +195,16 @@ static __poll_t rtc_dev_poll(struct file *file, poll_table *wait)
poll_wait(file, &rtc->irq_queue, wait);
- data = rtc->irq_data;
+ /*
+ * This read can race with the write in rtc_handle_legacy_irq().
+ *
+ * - If this check misses a zero to non-zero transition the next check
+ * will pick it up (rtc_handle_legacy_irq() wakes up rtc->irq_queue).
+ * - Non-zero to non-zero transition misses do not change return value.
+ * - And a non-zero to zero transition is unlikely to be missed, since
+ * it occurs on rtc_dev_read(), during which polling is not expected.
+ */
+ data = data_race(rtc->irq_data);
return (data != 0) ? (EPOLLIN | EPOLLRDNORM) : 0;
}
---
base-commit: 8e5a478b6d6a5bb0a3d52147862b15e4d826af19
change-id: 20260317-irq_data-e0fcd79d533c
Best regards,
--
Mauricio Faria de Oliveira <mfo@igalia.com>
^ permalink raw reply related
* Re: [PATCH 00/15] Convert power-controller to dt-schema and update various yaml file to referencing it
From: Peng Fan @ 2026-03-17 5:45 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rafael J. Wysocki, Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Shree Ramamoorthy,
Jerome Neanne, Paul Cercueil, Alexandre Belloni, Dmitry Osipenko,
Heiko Stuebner, Joseph Chen, Chris Zhong, Zhang Qing,
Sebastian Reichel, Jonathan Neuschäfer, Lubomir Rintel,
Julien Panis, Matti Vaittinen, Alexander Kurz,
Krzysztof Kozlowski, André Draszik, devicetree, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-rtc, linux-rockchip,
linux-samsung-soc, Peng Fan
In-Reply-To: <20260316170034.31bee485@kemnade.info>
On Mon, Mar 16, 2026 at 05:00:34PM +0100, Andreas Kemnade wrote:
>On Mon, 16 Mar 2026 14:55:21 +0000
>Mark Brown <broonie@kernel.org> wrote:
>
>> On Mon, Mar 16, 2026 at 10:47:35PM +0800, Peng Fan (OSS) wrote:
>> > Convert power-controller.txt to dt-schema
>> > Update various dt-bindings to use generic power-controller.yaml without
>> > defining local property.
>>
>> Are there any dependencies here? It doesn't look like it. In general
>> please don't send a single series covering multiple subsystems unless
>> there are actual dependencies, it just makes it harder to figure out how
>> to handle things. Send a separate series to each subsystem instead.
>
>It seems that everything depends on Patch 1.
Krzysztof had similar comments. I reply here.
Yes, depends on patch 1, sorry for not being clear in cover-letter. I just
created a PR to dt-schema in github.
https://github.com/devicetree-org/dt-schema/pull/187
After that PR is merged, I will separate this patchset for each subsystem.
Thanks,
Peng
>
>Regards,
>Andreas
>
^ permalink raw reply
* Re: [PATCH 01/15] dt-bindings: power: power-controller: Convert to yaml format
From: Peng Fan @ 2026-03-17 5:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli, Andreas Kemnade, devicetree,
linux-kernel, linux-rpi-kernel, linux-arm-kernel, linux-rtc,
linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <e1e91ada-4d21-4384-983a-676a3aa09bd7@kernel.org>
Hi Krzysztof,
On Mon, Mar 16, 2026 at 03:49:46PM +0100, Krzysztof Kozlowski wrote:
>On 16/03/2026 15:47, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Convert power-controller.txt to yaml format. Drop the example because
>> there is already one in regulator/active-semi,act8846.yaml.
>>
>> +properties:
>> + system-power-controller:
>> + type: boolean
>> + description:
>> + Indicates that this device can be used to control the system power.
>
>Just like it was in case of other core properties, I think this should
>go to dtschema.
Thanks for giving a look. I just submited a PR
https://github.com/devicetree-org/dt-schema/pull/187
Thanks,
Peng
>
>Best regards,
>Krzysztof
>
^ permalink raw reply
* Re: [PATCH 04/15] dt-bindings: regulator: act8x: Use generic power-controller schema
From: Mark Brown @ 2026-03-16 17:47 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Shree Ramamoorthy,
Jerome Neanne, Paul Cercueil, Alexandre Belloni, Dmitry Osipenko,
Heiko Stuebner, Joseph Chen, Chris Zhong, Zhang Qing,
Sebastian Reichel, Andreas Kemnade, Jonathan Neuschäfer,
Lubomir Rintel, Julien Panis, Matti Vaittinen, Alexander Kurz,
Krzysztof Kozlowski, André Draszik, devicetree, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-rtc, linux-rockchip,
linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-4-92c80e5e1744@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
On Mon, Mar 16, 2026 at 10:47:39PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert the binding to use the generic power-controller schema instead by
> referencing power-controller.yaml and removing the local
> `system-power-controller` property definition.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* Re: [PATCH 03/15] dt-bindings: regulator: ti,tps65219: Use generic power-controller schema
From: Mark Brown @ 2026-03-16 17:46 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Shree Ramamoorthy,
Jerome Neanne, Paul Cercueil, Alexandre Belloni, Dmitry Osipenko,
Heiko Stuebner, Joseph Chen, Chris Zhong, Zhang Qing,
Sebastian Reichel, Andreas Kemnade, Jonathan Neuschäfer,
Lubomir Rintel, Julien Panis, Matti Vaittinen, Alexander Kurz,
Krzysztof Kozlowski, André Draszik, devicetree, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-rtc, linux-rockchip,
linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-3-92c80e5e1744@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
On Mon, Mar 16, 2026 at 10:47:38PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert the binding to use the generic power-controller schema instead by
> referencing power-controller.yaml and removing the local
> `system-power-controller` property definition.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* Re: [PATCH 00/15] Convert power-controller to dt-schema and update various yaml file to referencing it
From: Krzysztof Kozlowski @ 2026-03-16 16:39 UTC (permalink / raw)
To: Peng Fan (OSS), Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rafael J. Wysocki, Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
On 16/03/2026 15:47, Peng Fan (OSS) wrote:
> Convert power-controller.txt to dt-schema
> Update various dt-bindings to use generic power-controller.yaml without
> defining local property.
>
And here you explain the dependencies - external or within the patchset
- e.g. how what stops people from merging it. You cc-ed multiple
subsystems, so please think from the subsystem maintainer point of view
- what should they do here.
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH 00/15] Convert power-controller to dt-schema and update various yaml file to referencing it
From: Andreas Kemnade @ 2026-03-16 16:00 UTC (permalink / raw)
To: Mark Brown
Cc: Peng Fan (OSS), Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rafael J. Wysocki, Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Shree Ramamoorthy,
Jerome Neanne, Paul Cercueil, Alexandre Belloni, Dmitry Osipenko,
Heiko Stuebner, Joseph Chen, Chris Zhong, Zhang Qing,
Sebastian Reichel, Jonathan Neuschäfer, Lubomir Rintel,
Julien Panis, Matti Vaittinen, Alexander Kurz,
Krzysztof Kozlowski, André Draszik, devicetree, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-rtc, linux-rockchip,
linux-samsung-soc, Peng Fan
In-Reply-To: <f329f1b4-787e-4c8c-ba26-e419a047023b@sirena.org.uk>
On Mon, 16 Mar 2026 14:55:21 +0000
Mark Brown <broonie@kernel.org> wrote:
> On Mon, Mar 16, 2026 at 10:47:35PM +0800, Peng Fan (OSS) wrote:
> > Convert power-controller.txt to dt-schema
> > Update various dt-bindings to use generic power-controller.yaml without
> > defining local property.
>
> Are there any dependencies here? It doesn't look like it. In general
> please don't send a single series covering multiple subsystems unless
> there are actual dependencies, it just makes it harder to figure out how
> to handle things. Send a separate series to each subsystem instead.
It seems that everything depends on Patch 1.
Regards,
Andreas
^ permalink raw reply
* Re: [PATCH v4 3/5] dt-bindings: mfd: max77620: convert to DT schema
From: Daniel Lezcano @ 2026-03-16 15:03 UTC (permalink / raw)
To: Svyatoslav Ryhel, Linus Walleij, Bartosz Golaszewski, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Lee Jones, Liam Girdwood,
Mark Brown, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Chanwoo Choi, Alexandre Belloni
Cc: linux-gpio, devicetree, linux-kernel, linux-pm, linux-rtc
In-Reply-To: <20260312085258.11431-4-clamor95@gmail.com>
On 3/12/26 09:52, Svyatoslav Ryhel wrote:
> Convert max77620 devicetree bindings from TXT to YAML format. This patch
> does not change any functionality; the bindings remain the same. The
> thermal bindings are incorporated into the binding. GPIO controller
> function in MAX77620 has no dedicated node and is folded into the parent
> node itself.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
For the thermal part:
Acked-by: Daniel Lezcano <daniel.lezcano@kernel.org>
^ permalink raw reply
* Re: [PATCH 00/15] Convert power-controller to dt-schema and update various yaml file to referencing it
From: Mark Brown @ 2026-03-16 14:55 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Shree Ramamoorthy,
Jerome Neanne, Paul Cercueil, Alexandre Belloni, Dmitry Osipenko,
Heiko Stuebner, Joseph Chen, Chris Zhong, Zhang Qing,
Sebastian Reichel, Andreas Kemnade, Jonathan Neuschäfer,
Lubomir Rintel, Julien Panis, Matti Vaittinen, Alexander Kurz,
Krzysztof Kozlowski, André Draszik, devicetree, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-rtc, linux-rockchip,
linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
On Mon, Mar 16, 2026 at 10:47:35PM +0800, Peng Fan (OSS) wrote:
> Convert power-controller.txt to dt-schema
> Update various dt-bindings to use generic power-controller.yaml without
> defining local property.
Are there any dependencies here? It doesn't look like it. In general
please don't send a single series covering multiple subsystems unless
there are actual dependencies, it just makes it harder to figure out how
to handle things. Send a separate series to each subsystem instead.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply
* Re: [PATCH 01/15] dt-bindings: power: power-controller: Convert to yaml format
From: Krzysztof Kozlowski @ 2026-03-16 14:49 UTC (permalink / raw)
To: Peng Fan (OSS), Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Rafael J. Wysocki, Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-1-92c80e5e1744@nxp.com>
On 16/03/2026 15:47, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert power-controller.txt to yaml format. Drop the example because
> there is already one in regulator/active-semi,act8846.yaml.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> .../devicetree/bindings/power/power-controller.txt | 17 ------------
> .../bindings/power/power-controller.yaml | 30 ++++++++++++++++++++++
> 2 files changed, 30 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/power-controller.txt b/Documentation/devicetree/bindings/power/power-controller.txt
> deleted file mode 100644
> index e45affea80781292316c75ed387ba38402501c5b..0000000000000000000000000000000000000000
> --- a/Documentation/devicetree/bindings/power/power-controller.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -* Generic system power control capability
> -
> -Power-management integrated circuits or miscellaneous hardware components are
> -sometimes able to control the system power. The device driver associated with these
> -components might need to define this capability, which tells the kernel that
> -it can be used to switch off the system. The corresponding device must have the
> -standard property "system-power-controller" in its device node. This property
> -marks the device as able to control the system power. In order to test if this
> -property is found programmatically, use the helper function
> -"of_device_is_system_power_controller" from of.h .
> -
> -Example:
> -
> -act8846: act8846@5 {
> - compatible = "active-semi,act8846";
> - system-power-controller;
> -}
> diff --git a/Documentation/devicetree/bindings/power/power-controller.yaml b/Documentation/devicetree/bindings/power/power-controller.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..ff698365d778446c08ceeb5f3ef144d5e97d2f79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/power-controller.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
You relicensed the text, so you need to get some acks for that. Your
cover letter or patch changelog should explicitly ask for that and of
course you must Cc previous authors.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/power-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Generic System Power Control Capability
> +
> +maintainers:
> + - Rafael J. Wysocki <rafael@kernel.org>
> + - Ulf Hansson <ulf.hansson@linaro.org>
> +
> +description: |
> + Power-management integrated circuits or miscellaneous hardware components
> + are sometimes able to control the system power. The device driver associated
> + with these components might need to define this capability, which tells the
> + kernel that it can be used to switch off the system. The corresponding device
> + must have the standard property "system-power-controller" in its device node. This
> + property marks the device as able to control the system power.
> +
> + In order to test if this property is found programmatically, use the helper
> + function "of_device_is_system_power_controller" from of.h.
> +
> +properties:
> + system-power-controller:
> + type: boolean
> + description:
> + Indicates that this device can be used to control the system power.
Just like it was in case of other core properties, I think this should
go to dtschema.
Best regards,
Krzysztof
^ permalink raw reply
* [PATCH 15/15] dt-bindings: mfd: samsung,s2mpg10-pmic: Use generic power-controller schema
From: Peng Fan (OSS) @ 2026-03-16 14:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Switch the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
`system-power-controller` property definition.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/mfd/samsung,s2mpg10-pmic.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2mpg10-pmic.yaml b/Documentation/devicetree/bindings/mfd/samsung,s2mpg10-pmic.yaml
index 0ea1a440b983a47a55fc86d6251b89056ba51172..47418077b153d932e46a26b14024698ee6c50011 100644
--- a/Documentation/devicetree/bindings/mfd/samsung,s2mpg10-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/samsung,s2mpg10-pmic.yaml
@@ -18,6 +18,9 @@ description: |
GPIO interfaces and is typically complemented by S2MPG10 PMIC in a main/sub
configuration as the main PMIC.
+allOf:
+ - $ref: /schemas/power/power-controller.yaml#
+
properties:
compatible:
const: samsung,s2mpg10-pmic
@@ -36,8 +39,6 @@ properties:
description:
List of child nodes that specify the regulators.
- system-power-controller: true
-
wakeup-source: true
patternProperties:
@@ -71,7 +72,7 @@ required:
- interrupts
- regulators
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.37.1
^ permalink raw reply related
* [PATCH 14/15] dt-bindings: mfd: fsl,mc13xxx: Use generic power-controller schema
From: Peng Fan (OSS) @ 2026-03-16 14:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Switch the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
`system-power-controller` property definition.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
index cfa69f1f380adb21937d60da7c28b7ca246d28e1..c43dde9e6c339a540f1503886cee58b2cb287104 100644
--- a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
+++ b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
@@ -34,8 +34,6 @@ properties:
spi-cs-high: true
- system-power-controller: true
-
interrupts:
maxItems: 1
@@ -176,6 +174,7 @@ required:
- reg
allOf:
+ - $ref: /schemas/power/power-controller.yaml#
- if:
properties:
compatible:
@@ -235,7 +234,7 @@ allOf:
minItems: 1
maxItems: 1
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.37.1
^ permalink raw reply related
* [PATCH 13/15] dt-bindings: mfd: rohm,bd71828-pmic: Use generic power-controller schema
From: Peng Fan (OSS) @ 2026-03-16 14:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Switch the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
`system-power-controller` property definition.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
index 09e7d68e92bf3d91bbbdf2e1b6a942e87b5fe7a1..9818102e02c75a46f7c56de8776ecb9b91a77cdf 100644
--- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
@@ -15,6 +15,9 @@ description: |
single-cell linear charger. Also included is a Coulomb counter, a real-time
clock (RTC), and a 32.768 kHz clock gate.
+allOf:
+ - $ref: /schemas/power/power-controller.yaml#
+
properties:
compatible:
oneOf:
@@ -79,8 +82,6 @@ properties:
used to mark the pins which should not be configured for GPIO. Please see
the ../gpio/gpio.txt for more information.
- system-power-controller: true
-
required:
- compatible
- reg
@@ -91,7 +92,7 @@ required:
- gpio-controller
- "#gpio-cells"
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.37.1
^ permalink raw reply related
* [PATCH 12/15] dt-bindings: mfd: ti,tps6594: Use generic power-controller schema
From: Peng Fan (OSS) @ 2026-03-16 14:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Switch the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
`system-power-controller` property definition.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/mfd/ti,tps6594.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
index ca17fbdea691d46f53cc9a85f963767da733ee1f..6a35cd3585909075146ae69c4274521d51981727 100644
--- a/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml
@@ -15,6 +15,9 @@ description:
PFSM (Pre-configurable Finite State Machine) managing the state of the device.
TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
+allOf:
+ - $ref: /schemas/power/power-controller.yaml#
+
properties:
compatible:
enum:
@@ -38,8 +41,6 @@ properties:
device on the SPMI bus, and the secondary PMICs are the target devices
on the SPMI bus.
- system-power-controller: true
-
gpio-controller: true
gpio-line-names: true
@@ -104,7 +105,7 @@ required:
- reg
- interrupts
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.37.1
^ permalink raw reply related
* [PATCH 11/15] dt-bindings: mfd: ti,twl: Use generic power-controller schema
From: Peng Fan (OSS) @ 2026-03-16 14:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Switch the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
`system-power-controller` property.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/mfd/ti,twl.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
index 9cc3e4721612e9e9f9b2c950d35871c4d0154e24..4b6b68aaee766be15b5cfe5a32aacfbf0aad5044 100644
--- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
@@ -16,6 +16,7 @@ description: |
These chips are connected to an I2C bus.
allOf:
+ - $ref: /schemas/power/power-controller.yaml#
- if:
properties:
compatible:
@@ -205,8 +206,6 @@ properties:
interrupt-controller: true
- system-power-controller: true
-
"#interrupt-cells":
const: 1
--
2.37.1
^ permalink raw reply related
* [PATCH 10/15] dt-bindings: mfd: netronix,ntxec: Use generic power-controller schema
From: Peng Fan (OSS) @ 2026-03-16 14:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Convert the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
`system-power-controller` property.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml
index 37fbb953ea12e7e2718c169991d1a9dbcc8b6c11..2fa8b797c0dcf379e9e61a7e9bbd9f1f8c59a0c2 100644
--- a/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml
+++ b/Documentation/devicetree/bindings/mfd/netronix,ntxec.yaml
@@ -13,6 +13,9 @@ description: |
This EC is found in e-book readers of multiple brands (e.g. Kobo, Tolino), and
is typically implemented as a TI MSP430 microcontroller.
+allOf:
+ - $ref: /schemas/power/power-controller.yaml#
+
properties:
compatible:
const: netronix,ntxec
@@ -21,10 +24,6 @@ properties:
items:
- description: The I2C address of the EC
- system-power-controller:
- type: boolean
- description: See Documentation/devicetree/bindings/power/power-controller.txt
-
interrupts:
minItems: 1
description:
@@ -42,7 +41,7 @@ required:
- compatible
- reg
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.37.1
^ permalink raw reply related
* [PATCH 09/15] dt-bindings: mfd: ricoh,rn5t618: Use generic power-controller schema
From: Peng Fan (OSS) @ 2026-03-16 14:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil,
Alexandre Belloni, Dmitry Osipenko, Heiko Stuebner, Joseph Chen,
Chris Zhong, Zhang Qing, Sebastian Reichel, Andreas Kemnade,
Jonathan Neuschäfer, Lubomir Rintel, Julien Panis,
Matti Vaittinen, Alexander Kurz, Krzysztof Kozlowski,
André Draszik
Cc: devicetree, linux-kernel, linux-rpi-kernel, linux-arm-kernel,
linux-rtc, linux-rockchip, linux-samsung-soc, Peng Fan
In-Reply-To: <20260316-power-controller-v1-0-92c80e5e1744@nxp.com>
From: Peng Fan <peng.fan@nxp.com>
Convert the binding to use the generic power-controller schema instead by
referencing power-controller.yaml and removing the local
`system-power-controller` property.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml b/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml
index e3d64307b5315730e8374e863203a15abb9f83e3..d81691f4d5742f46bb6cf37be4270fc4a38f21f9 100644
--- a/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml
+++ b/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml
@@ -18,6 +18,7 @@ description: |
The RC5T619 additionally includes USB charger detection and an RTC.
allOf:
+ - $ref: /schemas/power/power-controller.yaml#
- if:
properties:
compatible:
@@ -68,15 +69,10 @@ properties:
interrupts:
maxItems: 1
- system-power-controller:
- type: boolean
- description: |
- See Documentation/devicetree/bindings/power/power-controller.txt
-
regulators:
type: object
-additionalProperties: false
+unevaluatedProperties: false
required:
- compatible
--
2.37.1
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox