* [PATCH] rtc: nvidia-vrs10: remove locking in IRQ handler
@ 2026-10-09 21:23 alexandre.belloni
2026-10-09 21:33 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: alexandre.belloni @ 2026-10-09 21:23 UTC (permalink / raw)
To: Shubhi Garg, Alexandre Belloni; +Cc: linux-tegra, linux-rtc, linux-kernel
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Remove locking in the interrupt handler as it is not necessary to be locked
while calling rtc_update_irq().
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-nvidia-vrs10.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-nvidia-vrs10.c b/drivers/rtc/rtc-nvidia-vrs10.c
index b15796698558..caac63f4e0fc 100644
--- a/drivers/rtc/rtc-nvidia-vrs10.c
+++ b/drivers/rtc/rtc-nvidia-vrs10.c
@@ -358,11 +358,8 @@ static irqreturn_t nvvrs_rtc_irq_handler(int irq, void *data)
if (ret < 0)
return IRQ_NONE;
- if (ret & NVVRS_INT_SRC1_RTC_MASK) {
- rtc_lock(info->rtc);
+ if (ret & NVVRS_INT_SRC1_RTC_MASK)
rtc_update_irq(info->rtc, 1, RTC_IRQF | RTC_AF);
- rtc_unlock(info->rtc);
- }
/* Clear all interrupts */
if (nvvrs_pseq_irq_clear(info) < 0)
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: nvidia-vrs10: remove locking in IRQ handler
2026-10-09 21:23 [PATCH] rtc: nvidia-vrs10: remove locking in IRQ handler alexandre.belloni
@ 2026-10-09 21:33 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-10-09 21:33 UTC (permalink / raw)
To: alexandre.belloni; +Cc: linux-rtc, Alexandre Belloni
> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> Remove locking in the interrupt handler as it is not necessary to be locked
> while calling rtc_update_irq().
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009212347.490403-1-alexandre.belloni@bootlin.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-09 21:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-09 21:23 [PATCH] rtc: nvidia-vrs10: remove locking in IRQ handler alexandre.belloni
2026-10-09 21:33 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox