* [PATCH] rtc: nvidia-vrs10: Disable IRQ wake when resume fails
@ 2026-11-13 23:13 Hungyu Lin
2026-11-13 23:16 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Hungyu Lin @ 2026-11-13 23:13 UTC (permalink / raw)
To: Shubhi Garg, Alexandre Belloni
Cc: linux-rtc, linux-tegra, linux-kernel, stable
nvvrs_rtc_suspend() enables IRQ wake, but nvvrs_rtc_resume() returns
early if the I2C access to clear FORCE_ACT fails. This leaves a wake
reference held across later suspend and resume cycles.
Disable IRQ wake on the error path before returning the I2C error.
Fixes: 9d6d6b06933c ("rtc: nvvrs: add NVIDIA VRS RTC device driver")
Cc: stable@vger.kernel.org
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/rtc/rtc-nvidia-vrs10.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-nvidia-vrs10.c b/drivers/rtc/rtc-nvidia-vrs10.c
index caac63f4e0fc..a5e73baf03a5 100644
--- a/drivers/rtc/rtc-nvidia-vrs10.c
+++ b/drivers/rtc/rtc-nvidia-vrs10.c
@@ -505,6 +505,7 @@ static int nvvrs_rtc_resume(struct device *dev)
if (ret < 0) {
dev_err(info->dev, "Failed to clear FORCE_ACT bit (%d)\n",
ret);
+ disable_irq_wake(info->irq);
return ret;
}
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: nvidia-vrs10: Disable IRQ wake when resume fails
2026-11-13 23:13 [PATCH] rtc: nvidia-vrs10: Disable IRQ wake when resume fails Hungyu Lin
@ 2026-11-13 23:16 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-13 23:16 UTC (permalink / raw)
To: Hungyu Lin; +Cc: linux-rtc, Alexandre Belloni
> nvvrs_rtc_suspend() enables IRQ wake, but nvvrs_rtc_resume() returns
> early if the I2C access to clear FORCE_ACT fails. This leaves a wake
> reference held across later suspend and resume cycles.
>
> Disable IRQ wake on the error path before returning the I2C error.
>
> Fixes: 9d6d6b06933c ("rtc: nvvrs: add NVIDIA VRS RTC device driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113231327.22109-1-dennylin0707@gmail.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-13 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13 23:13 [PATCH] rtc: nvidia-vrs10: Disable IRQ wake when resume fails Hungyu Lin
2026-11-13 23:16 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox