From: "D. Wythe" <alibuda@linux.alibaba.com>
To: Wenjia Zhang <wenjia@linux.ibm.com>,
kgraul@linux.ibm.com, jaka@linux.ibm.com
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [net-next 0/2] Deliver confirm/delete rkey message in parallel
Date: Wed, 8 Feb 2023 11:04:05 +0800 [thread overview]
Message-ID: <04e65f58-3ef3-6f5a-6f95-35d5b1555c7e@linux.alibaba.com> (raw)
In-Reply-To: <fe0d2dae-1a3e-e32f-e8b3-285a33d29422@linux.ibm.com>
On 2/8/23 7:29 AM, Wenjia Zhang wrote:
>
>
> On 07.02.23 08:36, D. Wythe wrote:
>> From: "D. Wythe" <alibuda@linux.alibaba.com>
>>
>> According to the SMC protocol specification, we know that all flows except
>> confirm_rkey adn delete_rkey are exclusive, confirm/delete rkey flows
>> can run concurrently (local and remote).
>>
>> However, although the protocol allows, all flows are actually mutually
>> exclusive in implementation, deus to we are waiting for LLC message
>> in serial.
>>
>> On the one hand, this implementation does not conform to the protocol
>> specification, on the other hand, this implementation aggravates the
>> time for establishing or destroying a SMC-R connection, connection
>> have to be queued in smc_llc_wait.
>>
>> This patch will improve the performance of the short link scenario
>> by about 5%. In fact, we all know that the performance bottleneck
>> of the short link scenario is not here.
>>
>> This patch try use rtokens or rkey to correlate a confirm/delete
>> rkey message with its response.
>>
>> This patch contains two parts.
>>
>> At first, we have added the process
>> of asynchronously waiting for the response of confirm/delete rkey
>> messages, using rtokens or rkey to be correlate with.
>>
>> And then, we try to send confirm/delete rkey message in parallel,
>> allowing parallel execution of start (remote) or initialization (local)
>> SMC_LLC_FLOW_RKEY flows.
>>
>> D. Wythe (2):
>> net/smc: allow confirm/delete rkey response deliver multiplex
>> net/smc: make SMC_LLC_FLOW_RKEY run concurrently
>>
>> net/smc/smc_core.h | 1 +
>> net/smc/smc_llc.c | 263 +++++++++++++++++++++++++++++++++++++++++------------
>> net/smc/smc_llc.h | 6 ++
>> net/smc/smc_wr.c | 10 --
>> net/smc/smc_wr.h | 10 ++
>> 5 files changed, 220 insertions(+), 70 deletions(-)
>>
>
> As we already discussed, on this changes we need to test them carefully so that we have to be sure that the communicating with z/OS should not be broken. We'll let you know as soon as the testing is finished.
Hi, Wenjia
Thanks again for your test.
Considering that we have reached an agreement on protocol extension,
we can temporarily postpone this modification until we introduce the protocol extension
into the Linux community version. Then we can avoid the compatibility with z/OS.
Best wishes.
D. Wythe
next prev parent reply other threads:[~2023-02-08 3:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 7:36 [net-next 0/2] Deliver confirm/delete rkey message in parallel D. Wythe
2023-02-07 7:36 ` [net-next 1/2] net/smc: allow confirm/delete rkey response deliver multiplex D. Wythe
2023-02-07 23:15 ` Wenjia Zhang
2023-02-08 2:58 ` D. Wythe
2023-02-07 7:36 ` [net-next 2/2] net/smc: make SMC_LLC_FLOW_RKEY run concurrently D. Wythe
2023-02-07 23:22 ` Wenjia Zhang
2023-02-07 23:29 ` [net-next 0/2] Deliver confirm/delete rkey message in parallel Wenjia Zhang
2023-02-08 3:04 ` D. Wythe [this message]
2023-02-08 3:09 ` D. Wythe
2023-02-21 18:41 ` Wenjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e65f58-3ef3-6f5a-6f95-35d5b1555c7e@linux.alibaba.com \
--to=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox