From: Tim Chen <tim.c.chen@linux.intel.com>
To: Heiko Carstens <hca@linux.ibm.com>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] tick-sched: fix idle and iowait sleeptime accounting vs CPU hotplug
Date: Mon, 22 Jan 2024 10:19:30 -0800 [thread overview]
Message-ID: <0928660b39aea2828a79a87fef57447e657d43b4.camel@linux.intel.com> (raw)
In-Reply-To: <20240115163555.1004144-1-hca@linux.ibm.com>
On Mon, 2024-01-15 at 17:35 +0100, Heiko Carstens wrote:
>
>
> + idle_sleeptime = ts->idle_sleeptime;
> + iowait_sleeptime = ts->iowait_sleeptime;
> memset(ts, 0, sizeof(*ts));
> + ts->idle_sleeptime = idle_sleeptime;
> + ts->iowait_sleeptime = iowait_sleeptime;
> }
Should idle_calls and idle_sleeps be preserved and
restored too?
Seems like if we preserve the
idle_sleeptime, and wish to compute the average
sleep time per sleep, we will need to know the value of
idle_sleeps that's also preserved across CPU offline/online.
Tim
next prev parent reply other threads:[~2024-01-22 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 16:35 [PATCH] tick-sched: fix idle and iowait sleeptime accounting vs CPU hotplug Heiko Carstens
2024-01-17 0:43 ` Frederic Weisbecker
2024-01-22 18:19 ` Tim Chen [this message]
2024-01-22 22:31 ` Frederic Weisbecker
2024-01-22 23:33 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0928660b39aea2828a79a87fef57447e657d43b4.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=agordeev@linux.ibm.com \
--cc=frederic@kernel.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox