From: "D. Wythe" <alibuda@linux.alibaba.com>
To: Tony Lu <tonylu@linux.alibaba.com>
Cc: kgraul@linux.ibm.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, matthieu.baerts@tessares.net
Subject: Re: [PATCH v2 net-next 3/3] net/smc: Fallback when handshake workqueue congested
Date: Mon, 7 Feb 2022 15:13:22 +0800 [thread overview]
Message-ID: <0c4902f4-e744-fe95-1a05-51ae936c4516@linux.alibaba.com> (raw)
In-Reply-To: <YfTDjXh8zP3WBAtg@TonyMac-Alibaba>
After some trial and thought, I found that the scope of netlink control
is too large, we should limit the scope to socket. Adding a socket
option may be a better choice, what do you think?
在 2022/1/29 下午12:33, Tony Lu 写道:
> On Fri, Jan 28, 2022 at 10:44:38PM +0800, D. Wythe wrote:
>> From: "D. Wythe" <alibuda@linux.alibaba.com>
>> @@ -19,3 +19,15 @@ config SMC_DIAG
>
> ...
>
>> +if SMC
>> +
>> +config SMC_AUTO_FALLBACK
>> + bool "SMC: automatic fallback to TCP"
>> + default y
>> + help
>> + Allow automatic fallback to TCP accroding to the pressure of SMC-R
>> + handshake process.
>> +
>> + If that's not what you except or unsure, say N.
>> +endif
>
> Using a netlink knob to control behavior with static key should be more
> flexible. As I appended in the previous version of this patch.
>
> Thank you,
> Tony Lu
next prev parent reply other threads:[~2022-02-07 7:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 14:44 [PATCH v2 net-next 0/3] net/smc: Optimizing performance in D. Wythe
2022-01-28 14:44 ` [PATCH v2 net-next 1/3] net/smc: Make smc_tcp_listen_work() independent D. Wythe
2022-01-31 12:45 ` Karsten Graul
2022-02-02 12:53 ` D. Wythe
2022-01-28 14:44 ` [PATCH v2 net-next 2/3] net/smc: Limits backlog connections D. Wythe
2022-01-29 4:37 ` Tony Lu
2022-02-02 14:01 ` D. Wythe
2022-01-28 14:44 ` [PATCH v2 net-next 3/3] net/smc: Fallback when handshake workqueue congested D. Wythe
2022-01-29 4:33 ` Tony Lu
2022-02-02 14:04 ` D. Wythe
2022-02-07 7:13 ` D. Wythe [this message]
2022-02-07 9:37 ` Tony Lu
2022-01-31 12:46 ` [PATCH v2 net-next 0/3] net/smc: Optimizing performance in Karsten Graul
2022-02-02 13:00 ` D. Wythe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c4902f4-e744-fe95-1a05-51ae936c4516@linux.alibaba.com \
--to=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox