From: Dave Hansen <hansendc@us.ibm.com>
To: Martin Peschke <mp3@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
jbaron@redhat.com, rostedt@goodmis.org, billh@gnuppy.monkey.org,
mingo@elte.hu, linux-s390@vger.kernel.org
Subject: Re: [RFC] [Patch 1/4] statistics: no include hell for users
Date: Wed, 06 Jun 2007 14:39:47 -0700 [thread overview]
Message-ID: <1181165987.22388.81.camel@spirit.sr71.net> (raw)
In-Reply-To: <1181165609.7133.20.camel@dix>
On Wed, 2007-06-06 at 23:33 +0200, Martin Peschke wrote:
>
> struct statistic_interface {
> /* private: */
> struct list_head list;
> - struct dentry *debugfs_dir;
> - struct dentry *data_file;
> - struct dentry *def_file;
> + void *debugfs_dir;
> + void *data_file;
> + void *def_file;
If you don't actually dereference the pointer, you should just be able
to declare:
struct dentry;
and be done with it, right? You don't _need_ the includes to have just
pointers.
-- Dave
next prev parent reply other threads:[~2007-06-06 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 21:33 [RFC] [Patch 1/4] statistics: no include hell for users Martin Peschke
2007-06-06 21:39 ` Dave Hansen [this message]
2007-06-07 0:32 ` Martin Peschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181165987.22388.81.camel@spirit.sr71.net \
--to=hansendc@us.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=billh@gnuppy.monkey.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mp3@de.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox