From: Ursula Braun <ubraun@linux.vnet.ibm.com>
To: David.Laight@aculab.com
Cc: Uschi IBM <ursula.braun@de.ibm.com>,
frank.blaschka@de.ibm.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [patch 4/7] [PATCH] ctcm: make ctcmpc debugging compilable
Date: Wed, 07 Mar 2012 17:53:12 +0100 [thread overview]
Message-ID: <1331139192.15095.12.camel@br9gv9yg.de.ibm.com> (raw)
In-Reply-To: <OFA80676C5.CF55E2E0-ONC12579BA.005B3444-C12579BA.005B44A4@de.ibm.com>
> From: "David Laight" <David.Laight@aculab.com>
> To: <frank.blaschka@de.ibm.com>, <davem@davemloft.net>
> Cc: <netdev@vger.kernel.org>, <linux-s390@vger.kernel.org>,
> <ursula.braun@de.ibm.com>
> Date: 07/03/2012 13:20
> Subject: RE: [patch 4/7] [PATCH] ctcm: make ctcmpc debugging compilable
>
> What is wrong with:
> char addr[24];
> snprintf(addr, sizeof addr, "%p", rptr);
>
> There seemed to be other 'dangerous' unbounded string
> operations in that code as well.
>
> David
David,
nothing is wrong with your proposal to make use of %p here. Quite the
contrary - it improves the ctcmpc-code. I will keep your proposal in my
mind for a future follow-on ctcmpc-patch. Thanks!
My patch targets compilability of ctcmpc debugging code only.
Ursula
next parent reply other threads:[~2012-03-07 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OFA80676C5.CF55E2E0-ONC12579BA.005B3444-C12579BA.005B44A4@de.ibm.com>
2012-03-07 16:53 ` Ursula Braun [this message]
2012-03-07 12:06 [patch 0/7] s390: network driver fixes for net-next frank.blaschka
2012-03-07 12:06 ` [patch 4/7] [PATCH] ctcm: make ctcmpc debugging compilable frank.blaschka
2012-03-07 12:20 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331139192.15095.12.camel@br9gv9yg.de.ibm.com \
--to=ubraun@linux.vnet.ibm.com \
--cc=David.Laight@aculab.com \
--cc=frank.blaschka@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ursula.braun@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox