From: Nico Boehr <nrb@linux.ibm.com>
To: Eric Farman <farman@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH kvm-unit-tests v1 4/6] s390x: smp: Create and use a non-waiting CPU stop
Date: Mon, 07 Mar 2022 14:31:07 +0100 [thread overview]
Message-ID: <1342ba11026d58fecf4e596a0e3942076ef53051.camel@linux.ibm.com> (raw)
In-Reply-To: <20220303210425.1693486-5-farman@linux.ibm.com>
On Thu, 2022-03-03 at 22:04 +0100, Eric Farman wrote:
[...]
> --- a/s390x/smp.c
> +++ b/s390x/smp.c
> @@ -76,14 +76,8 @@ static void test_restart(void)
>
> static void test_stop(void)
> {
> - smp_cpu_stop(1);
> - /*
> - * The smp library waits for the CPU to shut down, but let's
> - * also do it here, so we don't rely on the library
> - * implementation
> - */
> - while (!smp_cpu_stopped(1)) {}
> - report_pass("stop");
> + smp_cpu_stop_nowait(1);
Now that this can fail because of CC=2, should we check the return
value here?
next prev parent reply other threads:[~2022-03-07 13:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 21:04 [PATCH kvm-unit-tests v1 0/6] s390x: SIGP fixes Eric Farman
2022-03-03 21:04 ` [PATCH kvm-unit-tests v1 1/6] lib: s390x: smp: Retry SIGP SENSE on CC2 Eric Farman
2022-03-07 11:50 ` Nico Boehr
2022-03-07 15:20 ` Claudio Imbrenda
2022-03-03 21:04 ` [PATCH kvm-unit-tests v1 2/6] s390x: smp: Test SIGP RESTART against stopped CPU Eric Farman
2022-03-04 10:43 ` Janosch Frank
2022-03-04 14:20 ` Eric Farman
2022-03-07 12:42 ` Nico Boehr
2022-03-07 15:22 ` Claudio Imbrenda
2022-03-03 21:04 ` [PATCH kvm-unit-tests v1 3/6] s390x: smp: Fix checks for SIGP STOP STORE STATUS Eric Farman
2022-03-04 10:40 ` Janosch Frank
2022-03-04 14:38 ` Eric Farman
2022-03-07 18:30 ` Eric Farman
2022-03-03 21:04 ` [PATCH kvm-unit-tests v1 4/6] s390x: smp: Create and use a non-waiting CPU stop Eric Farman
2022-03-07 13:31 ` Nico Boehr [this message]
2022-03-07 19:01 ` Eric Farman
2022-03-07 15:30 ` Claudio Imbrenda
2022-03-07 19:03 ` Eric Farman
2022-03-08 10:31 ` Claudio Imbrenda
2022-03-08 21:18 ` Eric Farman
2022-03-09 9:27 ` Claudio Imbrenda
2022-03-03 21:04 ` [PATCH kvm-unit-tests v1 5/6] s390x: smp: Create and use a non-waiting CPU restart Eric Farman
2022-03-07 15:31 ` Claudio Imbrenda
2022-03-03 21:04 ` [PATCH kvm-unit-tests v1 6/6] lib: s390x: smp: Convert remaining smp_sigp to _retry Eric Farman
2022-03-04 10:56 ` Janosch Frank
2022-03-04 14:15 ` Eric Farman
2022-03-07 14:42 ` Nico Boehr
2022-03-07 20:15 ` Eric Farman
2022-03-08 9:03 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342ba11026d58fecf4e596a0e3942076ef53051.camel@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox