From: Paul Bolle <pebolle@tiscali.nl>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] locking: remove three unused Kconfig symbols
Date: Mon, 08 Apr 2013 17:30:15 +0200 [thread overview]
Message-ID: <1365435015.1830.113.camel@x61.thuisdomein> (raw)
In-Reply-To: <20130408151609.GA13640@gmail.com>
On Mon, 2013-04-08 at 17:16 +0200, Ingo Molnar wrote:
> * Paul Bolle <pebolle@tiscali.nl> wrote:
> > The Kconfig symbols ARCH_INLINE_READ_UNLOCK_IRQ,
> > ARCH_INLINE_SPIN_UNLOCK_IRQ, and ARCH_INLINE_WRITE_UNLOCK_IRQ were added
> > in v2.6.33, but have never actually been used. It is safe to remove
> > these.
> >
> Erm, if you look at the code in question you'll see that they are unused I think
> due to a bug:
>
> config INLINE_READ_UNLOCK_IRQ
> def_bool y
> depends on !PREEMPT || ARCH_INLINE_READ_UNLOCK_BH
>
> Shouldn't that depend on ARCH_INLINE_READ_UNLOCK_IRQ?
>
> Similarly for the others.
Yes, that seems correct. I must admit that I didn't spot that
possibility, but then again this Kconfig file is near unreadable (too
much repetition for human readers).
Would you have any idea why this problem wasn't noticed in 16 (!)
releases? Fedora 17, which I did this patch on, has Kconfig symbolk
PREEMPT not set. Is it perhaps commit to not enable that option?
Paul Bolle
next prev parent reply other threads:[~2013-04-08 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 13:35 [PATCH] locking: remove three unused Kconfig symbols Paul Bolle
2013-04-08 15:16 ` Ingo Molnar
2013-04-08 15:30 ` Paul Bolle [this message]
2013-04-08 15:32 ` Paul Bolle
2013-04-08 15:36 ` Ingo Molnar
2013-05-17 8:51 ` [PATCH v2] locking: Fix copy/paste errors "ARCH_INLINE_*_UNLOCK_BH" Paul Bolle
2013-05-17 10:18 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365435015.1830.113.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=a.p.zijlstra@chello.nl \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox