From: Pierre Morel <pmorel@linux.ibm.com>
To: david@redhat.com
Cc: linux-kernel@vger.kernel.org, cohuck@redhat.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
frankja@linux.ibm.com, akrowiak@linux.ibm.com,
borntraeger@de.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com
Subject: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL
Date: Wed, 22 Aug 2018 18:51:56 +0200 [thread overview]
Message-ID: <1534956717-14087-5-git-send-email-pmorel@linux.ibm.com> (raw)
In-Reply-To: <1534956717-14087-1-git-send-email-pmorel@linux.ibm.com>
BUG: the crycbd must be tested for null even if
not crossing a page boundary (which will never
occur in this case anyway).
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
---
arch/s390/kvm/vsie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
index 0b12916..7ee4329 100644
--- a/arch/s390/kvm/vsie.c
+++ b/arch/s390/kvm/vsie.c
@@ -172,7 +172,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
if ((crycb_addr & PAGE_MASK) != ((crycb_addr + 128) & PAGE_MASK))
return set_validity_icpt(scb_s, 0x003CU);
- else if (!crycb_addr)
+ if (!crycb_addr)
return set_validity_icpt(scb_s, 0x0039U);
/* copy only the wrapping keys */
--
2.7.4
next prev parent reply other threads:[~2018-08-22 16:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 16:51 [PATCH v2 0/5] KVM: s390: vsie: Consolidate CRYCB validation Pierre Morel
2018-08-22 16:51 ` [PATCH v2 1/5] KVM: s390: vsie: BUG correction by shadow_crycb Pierre Morel
2018-08-22 16:53 ` David Hildenbrand
2018-08-23 6:40 ` Pierre Morel
2018-08-23 7:27 ` Cornelia Huck
2018-08-23 8:03 ` Pierre Morel
2018-08-23 8:02 ` Janosch Frank
2018-08-23 8:08 ` Pierre Morel
2018-08-22 16:51 ` [PATCH v2 2/5] KVM: s390: vsie: Only accept FORMAT1 CRYCB for guest2 Pierre Morel
2018-08-22 16:55 ` David Hildenbrand
2018-08-23 7:42 ` Pierre Morel
2018-08-22 16:51 ` [PATCH v2 3/5] KVM: s390: vsie: Allow support for a host without AP Pierre Morel
2018-08-22 17:06 ` David Hildenbrand
2018-08-23 6:44 ` Pierre Morel
2018-08-23 7:15 ` David Hildenbrand
2018-08-23 7:54 ` Pierre Morel
2018-08-23 6:52 ` Pierre Morel
2018-08-22 16:51 ` Pierre Morel [this message]
2018-08-22 17:07 ` [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL David Hildenbrand
2018-08-23 6:57 ` Pierre Morel
2018-08-22 16:51 ` [PATCH v2 5/5] KVM: s390: vsie: Do the CRYCB validation first Pierre Morel
2018-08-22 17:15 ` David Hildenbrand
2018-08-23 7:17 ` Pierre Morel
2018-08-23 7:31 ` David Hildenbrand
2018-08-23 8:01 ` Pierre Morel
2018-08-23 8:34 ` Janosch Frank
2018-08-23 8:40 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534956717-14087-5-git-send-email-pmorel@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox