From: Jeff Xie <chongguiguzi@gmail.com>
To: chwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Cc: rppt@linux.vnet.ibm.com, akpm@linux-foundation.org,
mhocko@suse.com, keescook@chromium.org, chongguiguzi@gmail.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] s390:tty3270:move spin_lock_bh to spin_lock in tasklet
Date: Wed, 20 Mar 2019 00:12:36 +0800 [thread overview]
Message-ID: <1553011956-28747-1-git-send-email-chongguiguzi@gmail.com> (raw)
It is unnecessary to call spin_lock_bh in a tasklet.
Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
---
drivers/s390/char/tty3270.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c
index 2b0c36c2..2963396 100644
--- a/drivers/s390/char/tty3270.c
+++ b/drivers/s390/char/tty3270.c
@@ -563,7 +563,7 @@ tty3270_read_tasklet(struct raw3270_request *rrq)
char *input;
int len;
- spin_lock_bh(&tp->view.lock);
+ spin_lock(&tp->view.lock);
/*
* Two AID keys are special: For 0x7d (enter) the input line
* has to be emitted to the tty and for 0x6d the screen
@@ -590,7 +590,7 @@ tty3270_read_tasklet(struct raw3270_request *rrq)
tp->update_flags = TTY_UPDATE_ALL;
tty3270_set_timer(tp, 1);
}
- spin_unlock_bh(&tp->view.lock);
+ spin_unlock(&tp->view.lock);
/* Start keyboard reset command. */
raw3270_request_reset(tp->kreset);
--
2.7.4
next reply other threads:[~2019-03-19 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 16:12 Jeff Xie [this message]
2019-03-20 7:27 ` [PATCH] s390:tty3270:move spin_lock_bh to spin_lock in tasklet Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553011956-28747-1-git-send-email-chongguiguzi@gmail.com \
--to=chongguiguzi@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chwidefsky@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox