From: patchwork-bot+netdevbpf@kernel.org
To: Simon Horman <horms@kernel.org>
Cc: wintera@linux.ibm.com, twinkler@linux.ibm.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com,
borntraeger@linux.ibm.com, svens@linux.ibm.com,
netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH net-next] s390: ism: Pass string literal as format argument of dev_set_name()
Date: Tue, 22 Apr 2025 09:10:59 +0000 [thread overview]
Message-ID: <174531305924.1477965.8234488898422063716.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20250417-ism-str-fmt-v1-1-9818b029874d@kernel.org>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Apr 2025 11:28:23 +0100 you wrote:
> GCC 14.2.0 reports that passing a non-string literal as the
> format argument of dev_set_name() is potentially insecure.
>
> drivers/s390/net/ism_drv.c: In function 'ism_probe':
> drivers/s390/net/ism_drv.c:615:2: warning: format not a string literal and no format arguments [-Wformat-security]
> 615 | dev_set_name(&ism->dev, dev_name(&pdev->dev));
> | ^~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- [net-next] s390: ism: Pass string literal as format argument of dev_set_name()
https://git.kernel.org/netdev/net-next/c/199561a48f02
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2025-04-22 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 10:28 [PATCH net-next] s390: ism: Pass string literal as format argument of dev_set_name() Simon Horman
2025-04-17 11:08 ` Heiko Carstens
2025-04-24 16:28 ` Simon Horman
2025-04-22 9:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174531305924.1477965.8234488898422063716.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=andrew+netdev@lunn.ch \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox